Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

right click on library above entry table not possible #6485

Closed
ilippert opened this issue May 15, 2020 · 6 comments
Closed

right click on library above entry table not possible #6485

ilippert opened this issue May 15, 2020 · 6 comments
Labels
good first issue An issue intended for project-newcomers. Varies in difficulty. type: enhancement

Comments

@ilippert
Copy link

According to
https://docs.jabref.org/setup/databaseproperties
it should be possible to perform

right clicking on the tab of the database and choosing "Database properties".

This should be restored - though as "Library properties".

@Siedlerchr
Copy link
Member

Yes, I am missing that right click feature as well.
However, as workaround you can still access them using the library menu.

@Siedlerchr Siedlerchr added good first issue An issue intended for project-newcomers. Varies in difficulty. type: enhancement labels May 15, 2020
@Siedlerchr Siedlerchr added this to Normal priority in Features & Enhancements via automation May 15, 2020
@ilippert
Copy link
Author

as workaround you can still access them using the library menu.
confirmed

@Oltman-B
Copy link
Contributor

Hello,

I'm new to open source but I'm interested in working on this issue. I've found examples of the context menu and mouse event handling in the code, but I'm not exactly sure where to implement. I'm assuming this would be somewhere in the JabRefFrame. Can anybody give me a little direction for starting? Thank you!

@Siedlerchr
Copy link
Member

@Oltman-B Thanks for your interest! Please read through our contribution guide
The TabbedPane is indeed initialized in JabRef Frame.
You probably need to add the menu handling to the add method, there the tabs are added for each library:

public void addTab(BasePanel basePanel, boolean raisePanel) {

Oltman-B added a commit to Oltman-B/jabref that referenced this issue May 22, 2020
fixes issue JabRef#6485 to implement context menu on library tabs
with the "Library properties" menu item.
@calixtus
Copy link
Member

calixtus commented May 22, 2020

To be honest, I personally think that an additional right click menu with just the menu entry for library properties is just polluting JabRef.
I don't think that opening the library properties via the menu bar is really a work around, bot merly a the UI cleaned up. I don't believe that anybody really needs the library properties on short dial and cannot spent another 2 seconds to call the library properties via the menu bar.

@koppor
Copy link
Member

koppor commented May 26, 2020

We merged the PR and created a follow-up issue at #6527.

@koppor koppor closed this as completed May 26, 2020
@tobiasdiez tobiasdiez moved this from Normal priority to Done in Features & Enhancements May 29, 2020
koppor pushed a commit that referenced this issue Apr 1, 2023
41531558a8 Fix unsigned newspaper articles throughout Chicago 17 (#6486)
7678212826 Create trames.csl (#6479)
0cae26ac85 Update hochschule-fur-soziale-arbeit-fhnw.csl (#6480)
85c4b693a2 Update to UP Harvard Theology & Religion (#6485)
c273aa7e43 Update ieee.csl (#6481)
fe67b80e47 Update open-window.csl (#6367)
f2229705ef Create iainutuban-tarbiyah.csl (#6361)
1867a56a26 Create business-and-human-rights-journal (#6359)
1371dbdf26 Update iso690-author-date-es.csl (#6477)
6953a43efd Update ieee.csl (#6478)
f56d5ef1cc Create czech-journal-of-international-relations.csl (#6453)
678b53f99c Update harvard-stellenbosch-university.csl (#6464)
3074938038 Update ucl-university-college-apa.csl (#6475)
27dab9ea0f Update iso690-author-date-es.csl (#6476)
a8aea63d00 Create elsevier-american-chemical-society.csl (#6342)
f8f290fa63 Update iso690-author-date-es.csl (#6472)
7fdc621eee Update journal-of-neolithic-archaeology (#6466)
7025568e70 Update offa.csl (#6465)
2d69299b19 Create uni-fribourg-theologie.csl (#6473)
8db531a73e Create travail-et-emploi.csl (#6351)
c8b54fc531 Make monash-university-harvard dependent style (#6470)
b95f59ff5c Update journal-of-the-marine-biological-association-of-the-united-kingdom.csl (#6456)
a12b513119 Update universite-du-quebec-a-montreal.csl (#6463)
048e6641e4 Update zeitschrift-fur-geschichtsdidaktik.csl (#6454)
f0d3d7ef15 Update journal-fur-kulturpflanzen-journal-of-cultivated-plants.csl (#6447)
3b814fe048 Update the-accounting-review.csl (#6459)
f24befd580 Update survey-of-ophthalmology.csl from ama.csl to its own independent style (#6460)
c868ab54f6 Create vancouver-alphabetical.csl (#6461)
782e39cfe1 Update american-institute-of-physics.csl (#6457)
a56cf03e3c Fix Chicago Cases & Newspaper sorting (#6458)

git-subtree-dir: buildres/csl/csl-styles
git-subtree-split: 41531558a873b2533f2d17d8d6484c2408174fce
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue An issue intended for project-newcomers. Varies in difficulty. type: enhancement
Projects
Archived in project
Development

No branches or pull requests

5 participants