-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dark theme: Entry table: Header of index without the proper color #6796
Comments
Our team @ISD14-LNMIIT wants to work on this issue. Please assign this issue to us! |
Thanks for taking this issue! At the same time you could also take a look at #6791 also an issue with the dark theme. Probably some color definitions confused. For getting started please read through our Contribution guide |
Surely, our team will loook into this issue too |
@Siedlerchr,
Unfortunately I can't keep the header text "#" AND tooltip at the same time. ))) |
@Gena928 Thanks for taking this. |
Another idea would be to add a style class to the node in https://github.com/JabRef/jabref/blob/master/src/main/java/org/jabref/gui/maintable/MainTableColumnFactory.java#L132 which sets the right font color. |
@tobiasdiez Can I create a pull request? |
Are there any examples where "text-unchanged" is also used? |
I found only one more entry in package |
I was able to solve the same issue with these small changes to: I'm not sure which is the better solution. The methods createIndexColumn and createGroupColumn work very differently from the other column creation methods (for example createFilesColumn). They should possibly be reworked completely to be more consistent with the rest of the design. |
Thank you all for your proposals, but I don't think that either one is a real solution for this issue. As the css-class text-unchanged for the header is used for something completly unrelated to the header text color, following this proposal would result in strange behaviour, if someone later decides to change the color of text-unchanged to something else, if he want's to change the color of unchanged texts in the diff/merge dialog. I think a better solution would then either be to introduce another css-class for main table headings or to debug, why the standard color is not applied in the main table headers. The other solution to use an icon would work in this case, but I think it's more a workaround but a solution. We would end up again in this issue as soon as someone tries to add another column with a text header.
In fact they work pretty much the same, but a few columns were outsourced (in the literal meaning) to new packages, to make the factory class a bit more easy to read. But you can move the the logic of createIndexColumn and the createGroupColumn to their own packages / classes, if you think it's worth it. Should be a nice little programming exercise. |
I agree completely with @calixtus. I think, a new css class for the header would be the best solution. |
Good day everyone.
Then I added this css class to MainTableColumnFactory.java After line 132
So does it looks like correct solution? |
Sounds reasonable. Does it work? |
@calixtus So now I have only this in
and this in |
@Gena928 Yes, that's good, so go ahead and crate your PR! |
Looks good. Can you please also check some of the dialogs that use a table that they are fine too? |
Sorry, can't find them. )) I see that
Sorry, are there any dialogs, that use |
Ooops, did not think before writing. Sorry. :-D |
@Gena928 Thank you for fixing this! |
JabRef 5.1--2020-08-26--fd5bc52
Linux 4.9.0-13-amd64 amd64
Java 15-ea
A tiny issue: the header of the index column (with the symbol #) does not follow the color scheme of the dark theme. The symbol is black while it should be gray.
![Capture du 2020-08-27 08-22-02](https://user-images.githubusercontent.com/6931104/91399849-01436880-e83f-11ea-972c-5ced8435c880.png)
See top left-hand corner:
The text was updated successfully, but these errors were encountered: