Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix adding and removing selected entries to group context menu #10408

Merged
merged 2 commits into from
Sep 25, 2023
Merged

Fix adding and removing selected entries to group context menu #10408

merged 2 commits into from
Sep 25, 2023

Conversation

Siedlerchr
Copy link
Member

@Siedlerchr Siedlerchr commented Sep 24, 2023 •
edited by koppor

Fixes 10403 Fixes #10404
Fixes #10317
Fixes #10374

grafik

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Sep 24, 2023
@github-actions
Copy link
Contributor

Your code currently does not meet JabRef's code guidelines. The tool reviewdog already placed comments on GitHub to indicate the places. See the tab "Files" in you PR. Please carefully follow the setup guide for the codestyle. Afterwards, please run checkstyle locally and fix the issues.

More information on code quality in JabRef is available at https://devdocs.jabref.org/getting-into-the-code/development-strategy.html.

@Siedlerchr
remove globals
dce48a8 
fix checkstyle
@Siedlerchr
Copy link
Member Author

@mlep can you test this version once it's ready? The bot will comment when the upload is done

@koppor
Copy link
Member

koppor commented Sep 24, 2023

The changelog reads as follows:

  • We fixed an issue where it was no longer possible to add or remove selected entries to groups via context menu #10404, #10317 #10374

I changed 10403 to 10404 in the description - I think, now, the numbers are right.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 24, 2023 •
edited

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.

@koppor
Copy link
Member

koppor commented Sep 24, 2023

#10374 is fixed:

image

However, the group "By rating" is still highlighted. Only re-selecting the entry unhighlights the group:

image

@koppor
Copy link
Member

koppor commented Sep 24, 2023

For reference: Refs #9574

@koppor
Copy link
Member

koppor commented Sep 24, 2023

I can confirm #10404 is fixed. Similar groups-tree update issue: The number of items is increased, but the color does not change from gray to green.

image

image

@Siedlerchr Siedlerchr added this pull request to the merge queue Sep 25, 2023
Merged via the queue into main with commit b06e443 Sep 25, 2023
15 checks passed
@Siedlerchr Siedlerchr deleted the fixGroupsAddingEntries branch September 25, 2023 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions left review comments

@koppor koppor koppor approved these changes

Assignees
No one assigned
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Milestone
No milestone
2 participants
@Siedlerchr @koppor