Fix partial 578 - Git integration #10422

lbenicio · 2023-09-26T18:01:34Z

This is a partial pull request just to track down the development progress and to any suggestions.

Here we want to outline:

We implemented both SSH and Username/Password auth method
Added support to local and remote git repositories
Stills needs to add support for GPG signing
Stills needs to add user interface messages on git errors
Stills must implement unit testing
Stills has to update documentation
The Credentials input dialog box should be updated. Currently, we open two dialog boxes, asking for username and then password

Mandatory checks

Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
Tests created for changes (if applicable)
Manually tested changed features in running JabRef (always required)
Screenshots added in PR description (for UI changes)
Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

koppor

Small comments.

I strongly do advice you use JUnit for development, too.

IntelliJ offers a play button at each test case. Thus, debugging is very easy!

koppor · 2023-09-27T07:27:54Z

src/main/java/org/jabref/logic/git/GitHandler.java

+                String gitPassword = "";
+
+                if (dialogService != null) {
+                    gitUsername = dialogService.showInputDialogAndWait(Localization.lang("Git credentials"), Localization.lang("git username")).get();


Please check how JabRef handles proxy credentials. Username/password stored in preferences. You should do that, too,

koppor · 2023-09-27T07:29:10Z

src/main/java/org/jabref/gui/exporter/SaveDatabaseAction.java

@@ -243,6 +243,11 @@ private boolean save(Path targetPath, SaveDatabaseMode mode) {
                libraryTab.resetChangedProperties();
            }
            dialogService.notify(Localization.lang("Library saved"));
+
+            if (success) {
+                SaveGitDatabaseAction saveGit = new SaveGitDatabaseAction(targetPath.getParent(), dialogService);


Please commit and push the current file only. Nothing else!

koppor · 2023-09-27T07:29:24Z

build.gradle

@@ -128,7 +128,7 @@ dependencies {
    // required for reading write-protected PDFs - see https://github.com/JabRef/jabref/pull/942#issuecomment-209252635
    implementation 'org.bouncycastle:bcprov-jdk18on:1.76'

-    implementation 'commons-cli:commons-cli:1.5.0'
+    implementation ('commons-cli:commons-cli:1.5.0')


Please keep the style of the build.gradle file. --> no braces here.

koppor · 2023-09-27T07:30:52Z

src/main/java/org/jabref/logic/git/GitHandler.java

-    String gitUsername = Optional.ofNullable(System.getenv("GIT_EMAIL")).orElse("");
-    String gitPassword = Optional.ofNullable(System.getenv("GIT_PW")).orElse("");
-    final CredentialsProvider credentialsProvider = new UsernamePasswordCredentialsProvider(gitUsername, gitPassword);


This change will break the SLR feature, doesn't it?

Maybe, you can also rely that a user provided username and password in the environment variables GIT_EMAIL and GIT_PW.

koppor · 2023-09-27T07:32:44Z

src/main/java/org/jabref/logic/git/GitHandler.java

            }
        }
    }

+    /**
+     * Get currently checked out branch.
+     * If checking out fails, it fails silently.


I don't see any checkout call there. -- Maybe you mean something else? Maybe demonstrate using a @Test?

Siedlerchr · 2023-10-08T12:24:14Z

Why did you close the PR?

koppor · 2023-10-22T21:18:54Z

This PR implements koppor#578

koppor · 2023-10-25T22:47:16Z

A new PR was submitted --> #10586

marcelojunior1 and others added 9 commits September 21, 2023 21:40

test: push

10a4779

fix build error

2c25b5f

test: push

91a12f1

fix build error

1126bc2

refactor

f3ae12e

fix: commit and push

c312817

code refactoring

7ffe7f1

add silent exception on git pull and push

905eda9

add username and password git credentials input

b104b99

lbenicio mentioned this pull request Sep 26, 2023

Add (simple) git support koppor/jabref#578

Open

Siedlerchr changed the title ~~Fix partial 578~~ Fix partial 578 - Git integration Sep 26, 2023

lbenicio changed the title ~~Fix partial 578 - Git integration~~ Fix **partial** 578 - Git integration Sep 26, 2023

koppor reviewed Sep 27, 2023

View reviewed changes

lbenicio and others added 11 commits October 2, 2023 20:44

fix style and git logic to add one file only

bf33ca0

add git preferences files

375e689

inject dialog service

d3a8014

add initial support to git credentials dialog view

a1e8ca0

fix: git failed silently and style

e4dd331

fix git http push

4c81e54

refactor git credentials dialog to single dialog with two inputs

df3e4bb

user and password menu without Keyring

298d86e

refact credentials view to other file

6109741

fix git pref panel

27b95bf

user git preferences when pushing new commits

e935882

lbenicio closed this Oct 8, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix partial 578 - Git integration #10422

Fix partial 578 - Git integration #10422

lbenicio commented Sep 26, 2023 •

edited

Loading

koppor left a comment

koppor Sep 27, 2023

koppor Sep 27, 2023

koppor Sep 27, 2023

koppor Sep 27, 2023

koppor Sep 27, 2023

Siedlerchr commented Oct 8, 2023

koppor commented Oct 22, 2023

koppor commented Oct 25, 2023

Fix **partial** 578 - Git integration #10422

Fix **partial** 578 - Git integration #10422

Conversation

lbenicio commented Sep 26, 2023 • edited Loading

Mandatory checks

koppor left a comment

Choose a reason for hiding this comment

koppor Sep 27, 2023

Choose a reason for hiding this comment

koppor Sep 27, 2023

Choose a reason for hiding this comment

koppor Sep 27, 2023

Choose a reason for hiding this comment

koppor Sep 27, 2023

Choose a reason for hiding this comment

koppor Sep 27, 2023

Choose a reason for hiding this comment

Siedlerchr commented Oct 8, 2023

koppor commented Oct 22, 2023

koppor commented Oct 25, 2023

Fix partial 578 - Git integration #10422

Fix partial 578 - Git integration #10422

lbenicio commented Sep 26, 2023 •

edited

Loading