Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paging support for fetchers #5507 #10916

Closed
wants to merge 3 commits into from
Closed

Conversation

Ajitaganguly3
Copy link

@Ajitaganguly3 Ajitaganguly3 commented Feb 25, 2024

Description

Fixes #5507
This pull request adds a next button, a previous button and pagination for the Fetchers.

Changes Made

  • Added new classes WebImportEntriesDialog, and, WebImportViewModel that adds the previous button, next button and pagination.
  • Added the disable feature to the Previous button. The previous button will be disabled at first.
  • Implemented the logic so that the Fetcher only shows 20 data per page
  • Added WebImportEntriesDialog.FXML file which shows the buttons and the pagination

@koppor
Copy link
Member

koppor commented Feb 26, 2024

I tried it out with "ArXiv". The "Next" button does not work:

image

Expected: When clicking on "Next", items 21..40 are fetched.

When searching in the web for "test", there are more than 160.000 entries.

https://arxiv.org/search/?query=test&searchtype=all&source=header

image

@Ajitaganguly3
Copy link
Author

Thank you @koppor for providing insight on this. I'll try to make the necessary modifications on the code so that it works fine with all the Fetchers.

@koppor
Copy link
Member

koppor commented Feb 27, 2024

Take this as exercise for agile development with feedback loops. Typically, customers don't know what they exactly want at the beginning. It will come to light while presenting intermediate results.

BTW: I like the idea that Next also works with non-paged fetchers. Maybe the dialogs can be unified again so that the same dialog can be used for page based and non-page based fetchers.

@koppor koppor marked this pull request as draft February 28, 2024 22:34
@koppor
Copy link
Member

koppor commented Mar 11, 2024

Closing this issue due to inactivity 💤

Please ping us if you intend to resume work on this one.

@koppor koppor closed this Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI: Paging support for fetchers
2 participants