Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to use JavaFX ea builds #10918

Merged
merged 23 commits into from
Feb 28, 2024
Merged

Try to use JavaFX ea builds #10918

merged 23 commits into from
Feb 28, 2024

Conversation

koppor
Copy link
Member

@koppor koppor commented Feb 26, 2024

Follow-up to #10904

Fixes https://github.com/JabRef/jabref-issue-melting-pot/issues/359

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@koppor
Copy link
Member Author

koppor commented Feb 27, 2024

@koppor
Copy link
Member Author

koppor commented Feb 27, 2024

JabRef 5.13-PullRequest10918.214--2024-02-27--ac4563f
Windows 11 10.0 amd64 
Java 23-ea 
JavaFX 23-ea+3

@koppor
Copy link
Member Author

koppor commented Feb 27, 2024

I am now trying to add arch64 build from #10867 to here.

Siedlerchr
Siedlerchr previously approved these changes Feb 27, 2024
@calixtus
Copy link
Member

Failed because of a network error. Retrying.

Feb 27, 2024 11:34:17 PM org.apache.http.impl.execchain.RetryExec execute INFO: I/O exception (java.net.SocketException) caught when processing request to {s}->https://beallslist.net:443: Network is unreachable Feb 27, 2024 11:34:17 PM org.apache.http.impl.execchain.RetryExec execute INFO: Retrying request to {s}->[https://beallslist.net:443](https://beallslist.net/) Feb 27, 2024 11:34:17 PM org.apache.http.impl.execchain.RetryExec execute INFO: I/O exception (java.net.SocketException) caught when processing request to {s}->https://beallslist.net:443: Network is unreachable Feb 27, 2024 11:34:17 PM org.apache.http.impl.execchain.RetryExec execute INFO: Retrying request to {s}->[https://beallslist.net:443](https://beallslist.net/) Feb 27, 2024 11:34:17 PM org.apache.http.impl.execchain.RetryExec execute INFO: I/O exception (java.net.SocketException) caught when processing request to {s}->https://beallslist.net:443: Network is unreachable Feb 27, 2024 11:34:17 PM org.apache.http.impl.execchain.RetryExec execute INFO: Retrying request to {s}->[https://beallslist.net:443](https://beallslist.net/) Error: Exception in thread "main" kong.unirest.UnirestException: java.net.SocketException: Network is unreachable

@calixtus
Copy link
Member

@koppor seems to work now.

@koppor
Copy link
Member Author

koppor commented Feb 28, 2024

Not sure about the file names...

@koppor
Copy link
Member Author

koppor commented Feb 28, 2024

Network error during predatory journal list fetching:

INFO: I/O exception (java.net.SocketException) caught when processing request to {s}->https://beallslist.net:443: Network is unreachable

Will retry

@koppor
Copy link
Member Author

koppor commented Feb 28, 2024

We get following warning:

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache/restore@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

This is due to awalsh128/cache-apt-pkgs-action#126 (comment)

Copy link
Contributor

github-actions bot commented Feb 28, 2024

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.

@koppor koppor marked this pull request as ready for review February 28, 2024 21:23
@koppor
Copy link
Member Author

koppor commented Feb 28, 2024

image

@Siedlerchr Siedlerchr added this pull request to the merge queue Feb 28, 2024
Merged via the queue into main with commit 5c7766b Feb 28, 2024
39 checks passed
@Siedlerchr Siedlerchr deleted the add-javafx-to-ea branch February 28, 2024 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants