Fix cursor jumping #11282

koppor · 2024-05-07T00:20:27Z

Fixes Cursors jumps to the beginning #5904
Also fixes When saving: The libary has been modified by another program #4877

Draft, because some white space issues. And my "fix" for ## seems to have broken something.

Mandatory checks

Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
Tests created for changes (if applicable)
Manually tested changed features in running JabRef (always required)
Screenshots added in PR description (for UI changes)
Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

koppor · 2024-06-04T22:11:13Z

I don't know about the discrepancy about local and remote test execution

CI: FAILURE: Executed 8661 tests in 4m 28s (3 failed, 29 skipped)
local: FAILURE: Executed 8661 tests completed, 51 failed, 16 skipped

# Conflicts: # src/main/java/org/jabref/gui/entryeditor/EntryEditor.java # src/main/java/org/jabref/gui/entryeditor/RelatedArticlesTab.java

src/main/java/org/jabref/gui/fieldeditors/FieldEditors.java

src/test/java/org/jabref/logic/bibtex/FieldWriterTest.java

github-actions · 2024-06-17T20:17:16Z

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.

LoayGhreeb · 2024-06-19T03:17:15Z

@koppor, an exception is thrown when trying to use Ctrl+Z on any text field in the entry editor.

2024-06-19 06:13:03 [JavaFX Application Thread] org.jabref.gui.FallbackExceptionHandler.uncaughtException()
ERROR: Uncaught exception occurred in Thread[#54,JavaFX Application Thread,5,main]: java.lang.NullPointerException: Cannot read field "next" because "this.undoChange" is null
	at javafx.controls@22.0.1/javafx.scene.control.TextInputControl.updateUndoRedoState(TextInputControl.java:1250)
	at javafx.controls@22.0.1/javafx.scene.control.TextInputControl.undo(TextInputControl.java:1201)
	at javafx.controls@22.0.1/com.sun.javafx.scene.control.behavior.TextInputControlBehavior.undo(TextInputControlBehavior.java:553)
	at javafx.controls@22.0.1/com.sun.javafx.scene.control.behavior.TextInputControlBehavior.lambda$new$30(TextInputControlBehavior.java:180)
	at javafx.controls@22.0.1/com.sun.javafx.scene.control.behavior.TextInputControlBehavior.lambda$keyMapping$62(TextInputControlBehavior.java:344)
	at javafx.controls@22.0.1/com.sun.javafx.scene.control.inputmap.InputMap.handle(InputMap.java:274)
	at javafx.base@22.0.1/com.sun.javafx.event.CompositeEventHandler$NormalEventHandlerRecord.handleBubblingEvent(CompositeEventHandler.java:247)
	at javafx.base@22.0.1/com.sun.javafx.event.CompositeEventHandler.dispatchBubblingEvent(CompositeEventHandler.java:80)
	at javafx.base@22.0.1/com.sun.javafx.event.EventHandlerManager.dispatchBubblingEvent(EventHandlerManager.java:232)
	at javafx.base@22.0.1/com.sun.javafx.event.EventHandlerManager.dispatchBubblingEvent(EventHandlerManager.java:189)
	at javafx.base@22.0.1/com.sun.javafx.event.CompositeEventDispatcher.dispatchBubblingEvent(CompositeEventDispatcher.java:59)
	at javafx.base@22.0.1/com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(BasicEventDispatcher.java:58)
	at javafx.base@22.0.1/com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(EventDispatchChainImpl.java:114)
	at javafx.base@22.0.1/com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(BasicEventDispatcher.java:56)
	at javafx.base@22.0.1/com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(EventDispatchChainImpl.java:114)
	at javafx.base@22.0.1/com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(BasicEventDispatcher.java:56)
	at javafx.base@22.0.1/com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(EventDispatchChainImpl.java:114)
	at javafx.base@22.0.1/com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(BasicEventDispatcher.java:56)
	at javafx.base@22.0.1/com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(EventDispatchChainImpl.java:114)
	at javafx.base@22.0.1/com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(BasicEventDispatcher.java:56)
	at javafx.base@22.0.1/com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(EventDispatchChainImpl.java:114)
	at javafx.base@22.0.1/com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(BasicEventDispatcher.java:56)
	at javafx.base@22.0.1/com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(EventDispatchChainImpl.java:114)
	at javafx.base@22.0.1/com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(BasicEventDispatcher.java:56)
	at javafx.base@22.0.1/com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(EventDispatchChainImpl.java:114)
	at javafx.base@22.0.1/com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(BasicEventDispatcher.java:56)
	at javafx.base@22.0.1/com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(EventDispatchChainImpl.java:114)
	at javafx.base@22.0.1/com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(BasicEventDispatcher.java:56)
	at javafx.base@22.0.1/com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(EventDispatchChainImpl.java:114)
	at javafx.base@22.0.1/com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(BasicEventDispatcher.java:56)
	at javafx.base@22.0.1/com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(EventDispatchChainImpl.java:114)
	at javafx.base@22.0.1/com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(BasicEventDispatcher.java:56)
	at javafx.base@22.0.1/com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(EventDispatchChainImpl.java:114)
	at javafx.base@22.0.1/com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(BasicEventDispatcher.java:56)
	at javafx.base@22.0.1/com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(EventDispatchChainImpl.java:114)
	at javafx.base@22.0.1/com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(BasicEventDispatcher.java:56)
	at javafx.base@22.0.1/com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(EventDispatchChainImpl.java:114)
	at javafx.base@22.0.1/com.sun.javafx.event.EventUtil.fireEventImpl(EventUtil.java:74)
	at javafx.base@22.0.1/com.sun.javafx.event.EventUtil.fireEvent(EventUtil.java:54)
	at javafx.base@22.0.1/javafx.event.Event.fireEvent(Event.java:198)
	at javafx.graphics@22.0.1/javafx.scene.Scene.processKeyEvent(Scene.java:2195)
	at javafx.graphics@22.0.1/javafx.scene.Scene$ScenePeerListener.keyEvent(Scene.java:2716)
	at javafx.graphics@22.0.1/com.sun.javafx.tk.quantum.GlassViewEventHandler$KeyEventNotification.run(GlassViewEventHandler.java:218)
	at javafx.graphics@22.0.1/com.sun.javafx.tk.quantum.GlassViewEventHandler$KeyEventNotification.run(GlassViewEventHandler.java:150)
	at java.base/java.security.AccessController.doPrivileged(AccessController.java:400)
	at javafx.graphics@22.0.1/com.sun.javafx.tk.quantum.GlassViewEventHandler.lambda$handleKeyEvent$1(GlassViewEventHandler.java:250)
	at javafx.graphics@22.0.1/com.sun.javafx.tk.quantum.QuantumToolkit.runWithoutRenderLock(QuantumToolkit.java:430)
	at javafx.graphics@22.0.1/com.sun.javafx.tk.quantum.GlassViewEventHandler.handleKeyEvent(GlassViewEventHandler.java:249)
	at javafx.graphics@22.0.1/com.sun.glass.ui.View.handleKeyEvent(View.java:542)
	at javafx.graphics@22.0.1/com.sun.glass.ui.View.notifyKey(View.java:966)
	at javafx.graphics@22.0.1/com.sun.glass.ui.win.WinApplication._runLoop(Native Method)
	at javafx.graphics@22.0.1/com.sun.glass.ui.win.WinApplication.lambda$runLoop$3(WinApplication.java:184)
	at java.base/java.lang.Thread.run(Thread.java:1583)

koppor added 26 commits May 6, 2024 23:20

Modernize tests in BibEntryWriterTest

dcb6e31

Add tests for current behavior

d75c1a5

Improve comments and code

197e723

Re-order tests

0331c2e

Extract method

42faa91

Fix handling of ##

6594317

Fix detection of multiline fields

05d9cbf

Fix space removal

60efa87

Fix trimming of content

1b62eb3

Codestyle: Tests

548bec4

Remove standard cleanups

e32f712

Add CHANGELOG.md entry

8b7dc30

Right trim multiline fields

06805f7

Add links to CHANGELOG.md

5f2dde2

Merge remote-tracking branch 'upstream/main' into fix-5904

ab6e5fd

Test case cleanup

e901b32

Fix whitespace formatting

2f2d256

Reformat comment (and add TODO marker)

febbcc8

More whitespace tweaking

09f7c80

Merge branch 'main' into fix-5904

1a1a8e6

Use our builder if possible

2a6da5e

Fix whitespace at import

49adca5

Merge remote-tracking branch 'origin/main' into fix-5904

f03a172

Try to get gradle executing all tests on GitHub CI

94afc94

Tweak parallel tests

18b41ea

Optimize build

185698a

koppor mentioned this pull request Jun 4, 2024

Disable whole CiteSeer since it does not work as of 2024-05-20 #11315

Merged

6 tasks

koppor added 2 commits June 5, 2024 00:33

Trim whole field content

c1524a3

Fix variable name

49540f0

koppor added 13 commits June 17, 2024 11:10

Adapt MathSciNetTest to new normalizing approach

0c5a401

Fix DBLP tests

450b87b

Use "List.of()" instead of "Collections.singletonList"

4fd160b

Add @nonnull annotation

67c65fb

Merge remote-tracking branch 'origin/main' into fix-5904

42514e3

# Conflicts: # src/main/java/org/jabref/gui/entryeditor/EntryEditor.java # src/main/java/org/jabref/gui/entryeditor/RelatedArticlesTab.java

Remove obsolete JavaDoc comment

caf7562

Fix NPE at tests

dfa13d3

Incease heap space (again)

9f6d3c2

Fix missing dependency injection

96a1486

Merge branch 'hotfix' into fix-5904

e033f20

Fix NPE

ce1ad83

Fix checkstyle

6922762

Merge remote-tracking branch 'origin/main' into fix-5904

b8a9e62

koppor marked this pull request as ready for review June 17, 2024 12:36

koppor mentioned this pull request Jun 17, 2024

Proper handling of "default" tsantalis/RefactoringMiner#746

Closed

koppor enabled auto-merge June 17, 2024 12:47

calixtus reviewed Jun 17, 2024

View reviewed changes

src/main/java/org/jabref/gui/fieldeditors/FieldEditors.java Outdated Show resolved Hide resolved

calixtus reviewed Jun 17, 2024

View reviewed changes

src/test/java/org/jabref/logic/bibtex/FieldWriterTest.java Show resolved Hide resolved

This was referenced Jun 17, 2024

Improve diff for implements becoming extends pouryafard75/RM-ASTDiff#107

Closed

Append call to text block pouryafard75/RM-ASTDiff#108

Closed

koppor added 2 commits June 17, 2024 22:05

Refine comment

b88b27a

Add more comments

b2d5ec4

Siedlerchr approved these changes Jun 17, 2024

View reviewed changes

koppor added this pull request to the merge queue Jun 17, 2024

Merged via the queue into main with commit d51b52b Jun 17, 2024
25 of 26 checks passed

koppor deleted the fix-5904 branch June 17, 2024 20:26

koppor mentioned this pull request Jun 24, 2024

Ctrl+Z (undo) not working any more #11420

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix cursor jumping #11282

Fix cursor jumping #11282

koppor commented May 7, 2024 •

edited

Loading

koppor commented Jun 4, 2024

github-actions bot commented Jun 17, 2024 •

edited

Loading

LoayGhreeb commented Jun 19, 2024

Fix cursor jumping #11282

Fix cursor jumping #11282

Conversation

koppor commented May 7, 2024 • edited Loading

Mandatory checks

koppor commented Jun 4, 2024

github-actions bot commented Jun 17, 2024 • edited Loading

LoayGhreeb commented Jun 19, 2024

koppor commented May 7, 2024 •

edited

Loading

github-actions bot commented Jun 17, 2024 •

edited

Loading