Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix when editing a bibEntry field the searchbar would be focused #1961

Merged
merged 1 commit into from Sep 12, 2016
Merged

Fix when editing a bibEntry field the searchbar would be focused #1961

merged 1 commit into from Sep 12, 2016

Conversation

chriba
Copy link
Contributor

@chriba chriba commented Sep 12, 2016

Fix for #1549

Steps to reproduce:

  • Select a bibentry
  • Edit a field
  • save the change (eg. click outside the field)
  • the searchbar would be focused

searchField.setText(searchTerm);
// to hinder the autocomplete window to popup
autoCompleteSupport.setVisible(false);
}

public void dontSelectSearchBar(boolean dontSelectSearchBar) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rename either the method or the parameter.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

already fixed

@boceckts
Copy link
Contributor

LGTM 👍

@boceckts boceckts added status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers and removed stupro-ready-for-internal-review labels Sep 12, 2016
@koppor koppor merged commit 304c783 into JabRef:master Sep 12, 2016
@chriba chriba deleted the fixEditEntrySearchbarFocus branch September 12, 2016 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants