Integrity checker improvements #2349
Merged
+43
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefan-kolb
added
the
status: ready-for-review
# Conflicts: # src/main/java/net/sf/jabref/gui/actions/IntegrityCheckAction.java
|
I did a quick check and it appears to work. |
|
Uhh... Browsing this from my mobile I'm not Sure... But @tobiasdiez you have closed the PR and not merged it 😉 |
Siedlerchr
reviewed
Dec 9, 2016
| public synchronized Optional<BibEntry> getEntryById(String id) { | ||
| for (BibEntry entry : entries) { | ||
| if (entry.getId().equals(id)) { | ||
| return Optional.of(entry); |
There was a problem hiding this comment.
Stream with findFirst or findAny
There was a problem hiding this comment.
You can directly edit this if you find it more intuitive.
|
Anything that needs to be changed here? |
Siedlerchr
approved these changes
Dec 12, 2016
|
From my point of view, it's good. I merge it in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up for #1779
Linking to Bibentries inside the integrity checker should be done via a reference to the entry not the key.