Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Complete rework of the auto completion #2965

Merged
merged 11 commits into from Jul 11, 2017
Merged

[WIP] Complete rework of the auto completion #2965

merged 11 commits into from Jul 11, 2017

Conversation

tobiasdiez
Copy link
Member

This PR reenables the auto completion in the entry editor. It is more or less a complete rewrite of this feature using JavaFX techniques. Now a dropdown box shows the suggestions instead of the previously used inline overwrite.

Current status: the auto completion in the search bar does not work and the code needs further cleanup. However, in the entry editor it should be feature complete. It would be nice if you could test it and give early feedback. Thanks.

  • Change in CHANGELOG.md described
  • Tests created for changes
  • Screenshots added (for bigger UI changes)
  • Manually tested changed features in running JabRef
  • Check documentation status (Issue created for outdated help page at help.jabref.org?)
  • If you changed the localization: Did you run gradle localizationUpdate?

@Siedlerchr
Copy link
Member

codewise it looks good so far. But I have not yet tested it

@lenhard
Copy link
Member

lenhard commented Jul 10, 2017

If played around a little with a running JabRef. When I enabled the autocompletion in the preferences, first my entry editor seemed to have crashed. Clicking around in it had no effect and eventually it closed. When I reopened it, the autocompletion was working fine. So that doesn't seem to be a blocking issue.

I have to say that I quite like the dropdowns :) This looks way better than the old autocompletion functionality! But before this goes life, the search should be fixed as well. When I start entering terms there (for example the letter N in some bibliography of mine) it is giving me expressions of the form Author{firstPart='Norman E.', firstAbbr='N. E.', vonPart='null', lastPart='Fenton', jrPart='null'}.

@tobiasdiez
Copy link
Member Author

Thanks for the feedback.
The search bar now should work again. Since I don't expect that someone has the desire to review the 3k line differences, I'll merge this PR now. However, as usually, if you find some problematic code I commit to fix it.

@tobiasdiez tobiasdiez merged commit b9bd27c into master Jul 11, 2017
@tobiasdiez tobiasdiez deleted the autocomplete branch July 11, 2017 14:27
Siedlerchr added a commit that referenced this pull request Jul 15, 2017
* upstream/master: (30 commits)
  Add preference migration for keybdingings (#3007)
  Shutdown previus AutosaveManager and BackupManager during SaveAs  (#2994)
  Run Checkstyle task after Test task (#3010)
  Mark LibraryOfCongressTest as a fetcher test (#3012)
  When browsing through the MainTable remember which EntryEditor tab was open (#3011)
  Improve performance of journal abbreviation loader (#3009)
  Update checkstyle 7.6.1 -> 8.0
  Don't abort build when there are checkstyle violations (#3006)
  Reimplement content selectors (#3003)
  Only do a back up for bigger changes or if a different field is edited (#3004)
  Listen to change events for setting dirty status of database (#3001)
  Fix #2967: MathSciNet tab works again
  Fix #2902: Tab in entry editor moves to next text area
  Fix #2946: external changes are now correctly shown in the entry editor
  Fix #2998: improve auto completion (#3002)
  Fix mac keybinding by replacing ctrl it with meta key (#3000)
  Less backups (#2995)
  [WIP] Complete rework of the auto completion (#2965)
  Eclipse J
  Add switch indentation for Eclipse and add some new missing formatting options
  ...
Siedlerchr added a commit that referenced this pull request Jul 15, 2017
* upstream/master:
  Add preference migration for keybdingings (#3007)
  Shutdown previus AutosaveManager and BackupManager during SaveAs  (#2994)
  Run Checkstyle task after Test task (#3010)
  Mark LibraryOfCongressTest as a fetcher test (#3012)
  When browsing through the MainTable remember which EntryEditor tab was open (#3011)
  Improve performance of journal abbreviation loader (#3009)
  Update checkstyle 7.6.1 -> 8.0
  Don't abort build when there are checkstyle violations (#3006)
  Reimplement content selectors (#3003)
  Only do a back up for bigger changes or if a different field is edited (#3004)
  Listen to change events for setting dirty status of database (#3001)
  Fix #2967: MathSciNet tab works again
  Fix #2902: Tab in entry editor moves to next text area
  Fix #2946: external changes are now correctly shown in the entry editor
  Fix #2998: improve auto completion (#3002)
  Fix mac keybinding by replacing ctrl it with meta key (#3000)
  Less backups (#2995)
  [WIP] Complete rework of the auto completion (#2965)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants