Inline loc.org xsds #3740
Merged
Inline loc.org xsds #3740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefan-kolb
added
the
status: ready-for-review
LinusDietz
approved these changes
Feb 19, 2018
There was a problem hiding this comment.
I have tested it and the xjc can now be generated without being connected to the internet!
Simultaneously I have created a PR that updates MODS to the newest version, so we first can merge this, and then the other. #3741
|
We have combined our two efforts in inlining and updating the MODS XSD files. This PR fixes #3737 and koppor#307 |
tobiasdiez
approved these changes
Feb 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3737
Not sure if this works and is the way to go.
If we need to update the mods schema we need to alter the paths again.
Also, I don't know if we may inline this here.