Pressing escape during search clears search field & selects first entry #3747
Conversation
updating jabref, 19.2.2018
…e entry when available
mohamean
changed the title
|
Thank you very much for your contribution! Codewise looks good! |
CHANGELOG.md
Outdated
| @@ -34,6 +34,7 @@ The new default removes the linked file from the entry instead of deleting the f | |||
| - The group editing window can now also be called by double-clicking the group to be edited. [koppor#277](https://github.com/koppor/jabref/issues/277) | |||
| - The magnifier icon at the search shows the [search mode](https://help.jabref.org/en/Search#search-modes) again. [#3535](https://github.com/JabRef/jabref/issues/3535) | |||
| - We added a new cleanup operation that replaces ligatures with their expanded form. [#3613](https://github.com/JabRef/jabref/issues/3613) | |||
| - Pressing ESC while searching will clear the search field and select the first entry, if available, in the table. [koppor#293](https://github.com/koppor/jabref/issues/293) | |||
There was a problem hiding this comment.
Just one minor thing: you should wrap keycodes in kbd tags, like <kbd>ESC</kbd>
There was a problem hiding this comment.
Oh so that's what was meant by wrapping keys in the changelog. Didn't know it actually means keycodes. My bad.
There was a problem hiding this comment.
While you are on it, could you do that here? ESC?
|
Will do, no worries. Are both branches maintable-beta & javafxGlobalEverything equivalent or should I choose one over the other? |
|
Please base it at |
Siedlerchr
added
the
status: ready-for-review
| /** | ||
| * Clears the search bar and select first entry, if available | ||
| * | ||
| * @author Aly Mohamed |
There was a problem hiding this comment.
Please do not add @author tags even if the exercise sheet requested it.
There was a problem hiding this comment.
Should I then push a new commit with the author tag removed or should I do that in the new pull request which would be based on the branch javafxGlobalEverything?
There was a problem hiding this comment.
Just remove it on this PR. Then, this PR is ready for merge.
Please create a new branch based on javafxGlobalEverything. I think, the implementation will differ much, so you can start from scratch? 😇
There was a problem hiding this comment.
Of course, no problem 😃 I'm actually enjoying this myself and am learning a lot about developing larger-scale open-source projects so starting from scratch sounds fun 😄.
CHANGELOG.md
Outdated
| @@ -34,6 +34,7 @@ The new default removes the linked file from the entry instead of deleting the f | |||
| - The group editing window can now also be called by double-clicking the group to be edited. [koppor#277](https://github.com/koppor/jabref/issues/277) | |||
| - The magnifier icon at the search shows the [search mode](https://help.jabref.org/en/Search#search-modes) again. [#3535](https://github.com/JabRef/jabref/issues/3535) | |||
| - We added a new cleanup operation that replaces ligatures with their expanded form. [#3613](https://github.com/JabRef/jabref/issues/3613) | |||
| - Pressing <kbd>ESC<kbd> while searching will clear the search field and select the first entry, if available, in the table. [koppor#293](https://github.com/koppor/jabref/issues/293) | |||
There was a problem hiding this comment.
The / got lost at this quick fix. Note that the closing XML element is </kbd>.
koppor
removed
the
status: ready-for-review
|
@mohamean I just merged the globalEveryThing branch into "maintable-beta" thus you can now use the latter as the base. |
Fixes: koppor#293
Allows the user to clear the search field by pressing the escape key. As requested as well, the first entry in the table is automatically selected afterwards, if such an entry exists.