Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set auto-update checkbox enable/disable when reading preferences #4446

Merged
merged 4 commits into from
Nov 6, 2018
Merged

Set auto-update checkbox enable/disable when reading preferences #4446

merged 4 commits into from
Nov 6, 2018

Conversation

sbeitzel
Copy link
Contributor

@sbeitzel sbeitzel commented Nov 1, 2018 •
edited
Loading

This patch addresses issue #4427. Added a call to the existing event handler (which enables/disables the checkbox in response to user clicks) when we set the checkbox value from the preferences.

  • Change in CHANGELOG.md described
  • Tests created for changes
  • Manually tested changed features in running JabRef
  • Screenshots added in PR description (for bigger UI changes) N/A
  • Ensured that the git commit message is a good one
  • Check documentation status (Issue created for outdated help page at help.jabref.org?) N/A

@sbeitzel
When initializing the UI from prefs, fire an event to make sure depen…
2b95982 
…dent controls get updated.

Drive-by code cleanup -- enums are singletons; don't call enum.equals(), just use ==.
@sbeitzel
Update changelog to document fix.
f13fb65
@stefan-kolb stefan-kolb added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Nov 2, 2018
Siedlerchr
Siedlerchr requested changes Nov 3, 2018
View reviewed changes
Copy link
Member

@Siedlerchr Siedlerchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you use javafx bindings, this should be better.
And please remove the changelog entry, as this issue was introduced with the conversion to javafx and therefore not present in the stable version

@Siedlerchr
Copy link
Member

Behavior should be
Use timestamp checked - > update timestamp is enabled (can be checked /unchecked)
Use timestamp unchecked - > update timestamp disabled

tobiasdiez
tobiasdiez approved these changes Nov 6, 2018
View reviewed changes
Copy link
Member

@tobiasdiez tobiasdiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. @Siedlerchr is this ok for merge?

Siedlerchr
Siedlerchr approved these changes Nov 6, 2018
View reviewed changes
Copy link
Member

@Siedlerchr Siedlerchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to approve the changes to the binding!

@Siedlerchr Siedlerchr merged commit 5548f8f into JabRef:master Nov 6, 2018
@sbeitzel sbeitzel deleted the feature/4427_update_ts_pref branch November 6, 2018 21:15
Siedlerchr added a commit that referenced this pull request Nov 9, 2018
@Siedlerchr
Merge remote-tracking branch 'upstream/master' into fixgroupsmove
dccf476 
* upstream/master:
  Add eprint cleanup (#4445)
  respect preference state (#4468)
  Set auto-update checkbox enable/disable when reading preferences (#4446)
  Improve MathSciNet fetcher and add ISBN fetcher to entry editor toolbar  (#4444)
  New translations JabRef_en.properties (German) (#4455)
Siedlerchr added a commit that referenced this pull request Nov 10, 2018
@Siedlerchr
Merge remote-tracking branch 'upstream/master' into ooPanel
b7ee084 
* upstream/master:
  Fix move to group always moves first entry (#4457)
  Add eprint cleanup (#4445)
  respect preference state (#4468)
  Set auto-update checkbox enable/disable when reading preferences (#4446)
  Improve MathSciNet fetcher and add ISBN fetcher to entry editor toolbar  (#4444)
  New translations JabRef_en.properties (German) (#4455)
Siedlerchr added a commit that referenced this pull request Nov 17, 2018
@Siedlerchr
Merge remote-tracking branch 'upstream/master' into docbookfive
c169517 
* upstream/master:
  Change location of some fields in the entry editor (#4448)
  Bump applicationinsights-core from 2.2.0 to 2.2.1 (#4488)
  Added feature to add server timezone when connecting to shared database (#4483)
  Bump applicationinsights-logging-log4j2 from 2.2.0 to 2.2.1 (#4487)
  fix save button
  Update archunit from 0.9.1 -> 0.9.2
  Fix move to group always moves first entry (#4457)
  Add eprint cleanup (#4445)
  respect preference state (#4468)
  Set auto-update checkbox enable/disable when reading preferences (#4446)
  Improve MathSciNet fetcher and add ISBN fetcher to entry editor toolbar  (#4444)
  New translations JabRef_en.properties (German) (#4455)
  New Crowdin translations (#4454)
  Fix error in l10n file: Toogle -> Toggle (#4453)
  Remove depandabot
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Siedlerchr Siedlerchr Siedlerchr approved these changes

@tobiasdiez tobiasdiez tobiasdiez approved these changes

Assignees
No one assigned
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sbeitzel @Siedlerchr @tobiasdiez @stefan-kolb