Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding additional modifiers to be used in bibtex key generator #4722

Merged
merged 1 commit into from
Mar 6, 2019

Conversation

matthiasgeiger
Copy link
Member

As I currently wanted to have a possibility to have "Capitalized Shorttitles" in my bibtex keys I reused the already existing CapitalizeFormatter, TitleCaseFormatter and SentenceCaseFormatter as "modifiers" to be used also for the BibtexKeyGenerator.

This implements #1506 and is more flexible as the solution developed by @oscargus at the time in #1894 as it can be applied to all other fields and not only to titles.


@matthiasgeiger matthiasgeiger added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Mar 5, 2019
Copy link
Member

@tobiasdiez tobiasdiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. The build error's appear to come from somewhere else (they don't concern the classes changed in this PR).

Please also change the help accordingly after merge.

@Siedlerchr
Copy link
Member

If you merge the current master in, the build errors should be resolved. (I accidentally pushed some changes to master yesterday)

@matthiasgeiger
Copy link
Member Author

As build is now passing after rebase I'll merge now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants