Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix overwriting of date in RIS import #4821

Merged
merged 2 commits into from
Mar 29, 2019
Merged

Fix overwriting of date in RIS import #4821

merged 2 commits into from
Mar 29, 2019

Conversation

Siedlerchr
Copy link
Member

@Siedlerchr Siedlerchr commented Mar 28, 2019

Now the first valid year is taken into account. Previously the year was overwritten when another field containing year was found.
Adjusted the tests to reflect the new behavior. This required adjusting the month field in the test files

Fixes #4816


  • Change in CHANGELOG.md described
  • Tests created for changes
  • Manually tested changed features in running JabRef
  • Screenshots added in PR description (for bigger UI changes)
  • Ensured that the git commit message is a good one
  • Check documentation status (Issue created for outdated help page at help.jabref.org?)

Now the first valid year is taken into account
Adjusted the tests to reflect the new behvaiour
@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Mar 28, 2019
Copy link
Member

@tobiasdiez tobiasdiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Siedlerchr Siedlerchr merged commit ee0f42c into master Mar 29, 2019
@Siedlerchr Siedlerchr deleted the fixRISImportDate branch March 29, 2019 14:04
@CodeSJS
Copy link

CodeSJS commented Mar 30, 2019

Thanks for working on this.

The import is now correct for the example I supplied, but it may not be a solid fix. If for some reason the Y2 field precedes Y1 or PY, then I confirmed that the JabRef development master still gets the publication year wrong.

Y2 is access year, should never be imported as publication year, so I guess JabRef should ignore this field. PY, publication year, should be the desired field. Y1 is "primary date". I searched, but could not find out how primary date differs from publication year, other than is a full year-month-day.

Regards,
Sherwin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants