Convert ExternalFileTypeEntryEditor to javafx #4885

Siedlerchr · 2019-04-14T12:18:39Z

Last but one swing dialog. The other is PushToApplication.

Change in CHANGELOG.md described
Tests created for changes
Manually tested changed features in running JabRef
Screenshots added in PR description (for bigger UI changes)
Ensured that the git commit message is a good one
Check documentation status (Issue created for outdated help page at help.jabref.org?)

tobiasdiez

Thanks! Mostly looks good to me, only a few minor remarks from my side.

tobiasdiez · 2019-04-14T17:00:41Z

src/main/java/org/jabref/gui/externalfiletype/CustomizeExternalFileTypesDialog.java

@@ -64,7 +64,7 @@ public void initialize() {
                .install(fileTypesTableIconColumn);
        new ValueTableCellFactory<ExternalFileType, Boolean>()
                .withGraphic(none -> IconTheme.JabRefIcons.EDIT.getGraphicNode())
-                .withOnMouseClickedEvent((type, none) -> event -> viewModel.edit(type))
+                                                              .withOnMouseClickedEvent((type, none) -> event -> viewModel.edit(type, false))


the indent seems to be off

tobiasdiez · 2019-04-14T17:03:21Z

src/main/java/org/jabref/gui/externalfiletype/CustomizeExternalFileTypesViewModel.java

    }

    public ObservableList<ExternalFileType> getFileTypes() {
        return fileTypes;
    }

-    public void edit(ExternalFileType type) {
+    public void edit(ExternalFileType type, boolean add) {


please add a public add(ExternalFileType) method and make this one here private (I'm not a big fan of these boolean toggles that completely alter the nature of the method).

I found a better solution.

src/main/java/org/jabref/gui/externalfiletype/EditExternalFileTypeDialog.java

tobiasdiez · 2019-04-14T17:07:18Z

src/main/java/org/jabref/gui/externalfiletype/EditExternalFileTypeDialog.java

+
+import com.airhacks.afterburner.views.ViewLoader;
+
+public class EditExternalFileTypeDialog extends BaseDialog<Void> {


I would remove the Edit from the name since it is now add/edit combined.

I would actually leave it with Edit, for the linked files dialog we also have edit, although one can add files there, too
And as we already have another dialog with the name customizeExternalFileTypeDialog, removing the edit would just make things confusing,
I therefore decided to rename it to EditExternalFileTypeEntryDialog

…alfiles * upstream/master: Fix saving of Strings (#4876)

1f706cd Update health-services-research.csl (#4939) 76bcd1d Update journal-of-the-royal-society-of-western-australia.csl (#4932) e79640e Create afro-asia.csl (#4934) c601aa4 Update lancaster-university-harvard.csl (#4938) 184fd90 Update collection-du-centre-jean-berard.csl (#4936) 82f9aec fix et-al & add DOI thyroid.csl (#4937) 4af169f Create universidade-estadual-de-alagoas-uneal-abnt (#4885) 47165b3 Update and rename medical-physics.csl to dependent/medical-physics.csl (AMA) (#4905) 3cab27d Update thieme-german.csl (#4931) eb2c977 Create zeitschrift-fur-zahnarztliche-implantologie.csl (#4925) 4adb1ea Create karstenia.csl (#4929) 530a136 Fix author substitute in Universita Cattolica git-subtree-dir: src/main/resources/csl-styles git-subtree-split: 1f706cd

7cab2f7 Create depro-ufs.csl (JabRef#4947) 2fcda1f Create journal-of-sport-science-and-medicine.csl (JabRef#4949) cd457d4 Update american-marketing-association.csl (JabRef#4945) cacc4ee Create nejm-catalyst.csl (JabRef#4943) bd769b9 Update and rename dependent/chinese-medical-journal.csl to chinese-me… (JabRef#4941) 1f706cd Update health-services-research.csl (JabRef#4939) 76bcd1d Update journal-of-the-royal-society-of-western-australia.csl (JabRef#4932) e79640e Create afro-asia.csl (JabRef#4934) c601aa4 Update lancaster-university-harvard.csl (JabRef#4938) 184fd90 Update collection-du-centre-jean-berard.csl (JabRef#4936) 82f9aec fix et-al & add DOI thyroid.csl (JabRef#4937) 4af169f Create universidade-estadual-de-alagoas-uneal-abnt (JabRef#4885) 47165b3 Update and rename medical-physics.csl to dependent/medical-physics.csl (AMA) (JabRef#4905) 3cab27d Update thieme-german.csl (JabRef#4931) eb2c977 Create zeitschrift-fur-zahnarztliche-implantologie.csl (JabRef#4925) 4adb1ea Create karstenia.csl (JabRef#4929) 530a136 Fix author substitute in Universita Cattolica git-subtree-dir: src/main/resources/csl-styles git-subtree-split: 7cab2f7

827b986 add DOI preprint to american-society-for-microbiology.csl (JabRef#4946) 7cab2f7 Create depro-ufs.csl (JabRef#4947) 2fcda1f Create journal-of-sport-science-and-medicine.csl (JabRef#4949) cd457d4 Update american-marketing-association.csl (JabRef#4945) cacc4ee Create nejm-catalyst.csl (JabRef#4943) bd769b9 Update and rename dependent/chinese-medical-journal.csl to chinese-me… (JabRef#4941) 1f706cd Update health-services-research.csl (JabRef#4939) 76bcd1d Update journal-of-the-royal-society-of-western-australia.csl (JabRef#4932) e79640e Create afro-asia.csl (JabRef#4934) c601aa4 Update lancaster-university-harvard.csl (JabRef#4938) 184fd90 Update collection-du-centre-jean-berard.csl (JabRef#4936) 82f9aec fix et-al & add DOI thyroid.csl (JabRef#4937) 4af169f Create universidade-estadual-de-alagoas-uneal-abnt (JabRef#4885) 47165b3 Update and rename medical-physics.csl to dependent/medical-physics.csl (AMA) (JabRef#4905) 3cab27d Update thieme-german.csl (JabRef#4931) eb2c977 Create zeitschrift-fur-zahnarztliche-implantologie.csl (JabRef#4925) 4adb1ea Create karstenia.csl (JabRef#4929) 530a136 Fix author substitute in Universita Cattolica git-subtree-dir: src/main/resources/csl-styles git-subtree-split: 827b986

* Squashed 'src/main/resources/csl-styles/' changes from 586e0b8..c5f14e2 c5f14e2 Update journal-of-plant-ecology.csl (#4837) b5d00ab Hotfix: pravnik.csl & iso690-full-note-cs.csl (#4833) fb8d48a add PMID and DOI (#4832) 7ebdfff Update lancaster-university-harvard.csl (#4836) 8771e21 Create journal-of-clinical-neurology.csl (#4835) 70beb7b Harvard Lancaster: Fix in-text locator 0709b73 Update informal-logic.csl (#4831) d18d133 Update gost-r-7-0-5-2008.csl (#4829) cfb5389 Update gost-r-7-0-5-2008-numeric.csl (#4828) 0fc46ea Update gost-r-7-0-5-2008-numeric-alphabetical.csl (#4827) fac26cb Create feminist-theory.csl (#4830) a2721e6 Update pravnik.csl, masarykova-univerzita-pravnicka-fakulta.csl, and iso690-full-note-cs.csl (#4826) 2f0d735 Improve localization of DGfP 683d7d1 Create zeitschrift-fur-theologie-und-philosophie.csl (#4813) 7c82406 always show DOI in aps.csl (#4820) 1eb531d Update journal-of-international-business-studies.csl (#4819) 9caf926 Create interdisziplinare-anthropologie.csl (#4818) 00210e1 UKSW2 (#4807) 015db6e UKSW1 (#4800) f706ef5 Update masarykova-univerzita-pravnicka-fakulta.csl (#4822) 096108d Update epilepsia.csl (#4823) 07ebdc3 Update eksploatacja-i-niezawodnosc.csl (#4824) 3d50f3c Create ABNT-Universidade-Federal-de-Pernambuco-CFCH.csl (#4798) df94fa1 Update eksploatacja-i-niezawodnosc.csl (#4808) 4089be5 Update bulletin-de-la-societe-prehistorique-francaise.csl (#4810) f130aa7 Update molecular-biology-and-evolution.csl (#4814) 86f452f Create heiliger-dienst.csl (#4815) 5ccd3e9 Update revista-brasileira-de-ciencia-do-solo.csl (#4817) 0eea734 Fix a delimiter in journal-of-the-royal-society-of-western-australia.csl (#4811) 1cbe790 Delete heiliger-dienst.csl 19fa29f Create heiliger-dienst.csl (#4787) 888bad1 Update RMIT Harvard to match Easy Cite (#4788) 46011dd Create universite-nangui-abrogoua-ufr-sn (#4676) 174adab Create apa-6th-edition-no-ampersand.csl (#4767) 03cf65f Create journal-of-plant-protection-research.csl (#4797) c749084 Update eksploatacja-i-niezawodnosc.csl (#4782) 17e1501 Update masarykova-univerzita-pravnicka-fakulta.csl (#4783) 5596d18 Update revista-brasileira-de-ciencia-do-solo.csl (#4790) 9c1a381 create csl for the journal Textual Cultures (#4785) 8345762 Update taylor-and-francis-national-library-of-medicine.csl (#4786) 5ec1acf Create british-journal-of-criminology.csl (#4789) 68550ac Update angewandte-chemie.csl (#4791) 09e2755 Create shock.csl (#4792) d46e49e Update antioxidants-and-redox-signaling.csl (#4793) git-subtree-dir: src/main/resources/csl-styles git-subtree-split: c5f14e2 * Squashed 'src/main/resources/csl-styles/' changes from c5f14e2..716f635 716f635 Update changes in Harvard-Stellenbosch (#4862) a6a9a1a Create alkoholizmus-a-drogove-zavislosti.csl (#4859) 0560ca0 Update journal-of-the-american-college-of-surgeons.csl (#4858) 9e16631 create independent style for cellular-and-molecular-gastroenterology-and-hepatology.csl (#4852) 87b0853 Update antiquity.csl (#4841) cb4e7f7 Update heart-rhythm.csl (#4850) b3b55ee Create iisue-moderno (#4846) 63973a7 Create etasr.csl (#4848) 9942138 Create style for Journal of Vertebrate Biology (#4849) 7c7f3d3 Add Future Medicine dependents (#4838) abe2066 Update methods-of-information-in-medicine.csl (#4847) c64d98b create independent style for new-zealand-journal-of-forestry-science (#4844) 28265f9 Create continuity-and-change.csl (#4839) d065fdd Create journal-of-clinical-ethics.csl (#4842) b9fbfa3 Update future-medicine.csl (#4843) ceb56fa Create future-medicine.csl (#4834) git-subtree-dir: src/main/resources/csl-styles git-subtree-split: 716f635 * Squashed 'src/main/resources/csl-styles/' changes from 716f635..a995c63 a995c63 Create errata.csl (#4894) 883b9cd Update archeologie-medievale.csl (#4892) a942b5c Update rmit-university-harvard.csl (#4890) 5d535fc Update universidade-do-porto-faculdade-de-engenharia-chicago.csl (#4891) f2a8fe3 Fix AVMA style c5a2d7e Create universidade-do-porto-faculdade-de-engenharia-chicago.csl (#4872) 9f106eb Update rmit-university-harvard.csl (#4884) 5213c2f Update universitetet-i-oslo-rettsvitenskap.csl (#4886) 7e0828d Update uclouvain-centre-charles-de-visscher-pour-le-droit-internation… (#4871) ae5eba3 Create revue-archeologique-de-lest.csl (#4881) 58a1672 Create pacific-conservation-biology.csl (#4880) 381106e Update national-institute-of-organisation-dynamics-australia-harvard.csl (#4879) c66a5c0 Create society-of-biblical-literature-author-date.csl (#4812) 008073c Create ruhr-universitat-bochum-medizinische-fakultat-variante-a.csl (#4874) 193385a Update manchester (#4878) fa9ef11 Create Faculty of Psychology and Education Sciences, Porto (#4856) 2f70b14 Add "personal communication" to remaining APA locales (#4866) 2b4f831 Fixed page-range-format (#4863) d5661ba universitat-bern-institut-fur-musikwissenschaft add missing cs:sort to cs:bibliography (#4860) e433c99 fix delimiter issue for bioscience.csl (#4876) 4d97aab update et-al settings for stroke.csl (#4875) 342b9e3 Update masarykova-univerzita-pravnicka-fakulta.csl (#4868) 91fe25e Add article number to IEEE (#4867) git-subtree-dir: src/main/resources/csl-styles git-subtree-split: a995c63 * Squashed 'src/main/resources/csl-styles/' changes from a995c63..bf698ac bf698ac Create common-market-law-review.csl (#4910) c962eca Create harvard-prifysgol-caerdydd.csl (#4922) 0c24e7f Update gewerblicher-rechtsschutz-und-urheberrecht.csl (#4923) d2ec1a7 Create Tijdschrift-voor-Geneeskunde.csl (#4907) 5df7250 Update harvard-institut-fur-praxisforschung-de.csl (#4918) 093fd91 Update universite-de-montreal-apa.csl (#4916) a3e41d4 Update thieme-german.csl (#4919) 648765a add DOI to aerosol-science-and-technology.csl (#4909) bc1ebee Reindent/reorder a8dc18a Fix documentation link for epidemiology & infection aab403a Fix AGLC Newspaper date 4c018d5 Add period between editor and translator (SBL styles) (#4906) 42f7491 Create geographische-zeitschrift.csl (#4898) a4002a6 Create german-kunstwissenschaft.csl (#4896) b01910b Disambiguation of names (#4895) git-subtree-dir: src/main/resources/csl-styles git-subtree-split: bf698ac * Squashed 'src/main/resources/csl-styles/' changes from bf698ac..7cab2f7 7cab2f7 Create depro-ufs.csl (#4947) 2fcda1f Create journal-of-sport-science-and-medicine.csl (#4949) cd457d4 Update american-marketing-association.csl (#4945) cacc4ee Create nejm-catalyst.csl (#4943) bd769b9 Update and rename dependent/chinese-medical-journal.csl to chinese-me… (#4941) 1f706cd Update health-services-research.csl (#4939) 76bcd1d Update journal-of-the-royal-society-of-western-australia.csl (#4932) e79640e Create afro-asia.csl (#4934) c601aa4 Update lancaster-university-harvard.csl (#4938) 184fd90 Update collection-du-centre-jean-berard.csl (#4936) 82f9aec fix et-al & add DOI thyroid.csl (#4937) 4af169f Create universidade-estadual-de-alagoas-uneal-abnt (#4885) 47165b3 Update and rename medical-physics.csl to dependent/medical-physics.csl (AMA) (#4905) 3cab27d Update thieme-german.csl (#4931) eb2c977 Create zeitschrift-fur-zahnarztliche-implantologie.csl (#4925) 4adb1ea Create karstenia.csl (#4929) 530a136 Fix author substitute in Universita Cattolica git-subtree-dir: src/main/resources/csl-styles git-subtree-split: 7cab2f7 * Squashed 'src/main/resources/csl-styles/' changes from 7cab2f7..827b986 827b986 add DOI preprint to american-society-for-microbiology.csl (#4946) git-subtree-dir: src/main/resources/csl-styles git-subtree-split: 827b986 * Squashed 'src/main/resources/csl-styles/' changes from 827b986..eb0d37e eb0d37e Create natbib-plainnat-author-dat.csl (#4967) fb1592a Update journal-of-fish-biology.csl (#4969) f6876cb Update .travis.yml (#4970) d6d400b Create london-review-of-international-law.csl (#4966) d2a5ae1 Update harvard-stellenbosch-university.csl (#4965) 9c62141 Create phytopathologia-mediterranea.csl (#4964) 8ca2ea1 Update historical-materialism.csl (#4960) 80456dc Update historical-materialism.csl be2d910 Update historical-materialism.csl 1d1cf09 Create atlande.csl (#4930) 89f41d4 Create juristische-zitierweise-oeffentliches-recht.csl (#4944) 8c677a0 Create korean-journal-of-gastroenterology.csl (#4954) eadb950 Create historical-materialism.csl (#4955) 5553dcd Create revista-materia.csl (#4957) d23a3ab Bug fix in APA 6 original publication macro (#4959) 66f9974 Always print publisher in APA 6th edition (#4899) 868809c Create agora.csl (#4940) 99c19c3 Update anthropologie-et-societes.csl (#4952) ee17423 Create critical-reviews-in-solid-state-and-materials-science.csl (#4951) 7a13a7d Create korean-journal-of-internal-medicine.csl (#4953) git-subtree-dir: src/main/resources/csl-styles git-subtree-split: eb0d37e * Merged new library actions * l10n * Removed unused constructor * Fixed checkstyle failed check * Fixed one more checkstyle issue Co-authored-by: github actions <jabrefmail+webfeedback@gmail.com>

* Squashed 'src/main/resources/csl-styles/' changes from bf698ac..827b986 827b986 add DOI preprint to american-society-for-microbiology.csl (#4946) 7cab2f7 Create depro-ufs.csl (#4947) 2fcda1f Create journal-of-sport-science-and-medicine.csl (#4949) cd457d4 Update american-marketing-association.csl (#4945) cacc4ee Create nejm-catalyst.csl (#4943) bd769b9 Update and rename dependent/chinese-medical-journal.csl to chinese-me… (#4941) 1f706cd Update health-services-research.csl (#4939) 76bcd1d Update journal-of-the-royal-society-of-western-australia.csl (#4932) e79640e Create afro-asia.csl (#4934) c601aa4 Update lancaster-university-harvard.csl (#4938) 184fd90 Update collection-du-centre-jean-berard.csl (#4936) 82f9aec fix et-al & add DOI thyroid.csl (#4937) 4af169f Create universidade-estadual-de-alagoas-uneal-abnt (#4885) 47165b3 Update and rename medical-physics.csl to dependent/medical-physics.csl (AMA) (#4905) 3cab27d Update thieme-german.csl (#4931) eb2c977 Create zeitschrift-fur-zahnarztliche-implantologie.csl (#4925) 4adb1ea Create karstenia.csl (#4929) 530a136 Fix author substitute in Universita Cattolica git-subtree-dir: src/main/resources/csl-styles git-subtree-split: 827b986 * Squashed 'src/main/resources/csl-styles/' changes from 827b986..eb0d37e eb0d37e Create natbib-plainnat-author-dat.csl (#4967) fb1592a Update journal-of-fish-biology.csl (#4969) f6876cb Update .travis.yml (#4970) d6d400b Create london-review-of-international-law.csl (#4966) d2a5ae1 Update harvard-stellenbosch-university.csl (#4965) 9c62141 Create phytopathologia-mediterranea.csl (#4964) 8ca2ea1 Update historical-materialism.csl (#4960) 80456dc Update historical-materialism.csl be2d910 Update historical-materialism.csl 1d1cf09 Create atlande.csl (#4930) 89f41d4 Create juristische-zitierweise-oeffentliches-recht.csl (#4944) 8c677a0 Create korean-journal-of-gastroenterology.csl (#4954) eadb950 Create historical-materialism.csl (#4955) 5553dcd Create revista-materia.csl (#4957) d23a3ab Bug fix in APA 6 original publication macro (#4959) 66f9974 Always print publisher in APA 6th edition (#4899) 868809c Create agora.csl (#4940) 99c19c3 Update anthropologie-et-societes.csl (#4952) ee17423 Create critical-reviews-in-solid-state-and-materials-science.csl (#4951) 7a13a7d Create korean-journal-of-internal-medicine.csl (#4953) git-subtree-dir: src/main/resources/csl-styles git-subtree-split: eb0d37e * Adapt arxiv phrase test Co-authored-by: github actions <jabrefmail+webfeedback@gmail.com>

Siedlerchr added 2 commits April 14, 2019 14:18

[WIP] Convert ExternalFileTypeEntryEditor to javafx

a87c64e

convert rest of the dialog

8aa09b9

Siedlerchr changed the title ~~[WIP] Convert ExternalFileTypeEntryEditor to javafx~~ Convert ExternalFileTypeEntryEditor to javafx Apr 14, 2019

Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Apr 14, 2019

tobiasdiez requested changes Apr 14, 2019

View reviewed changes

Siedlerchr added 3 commits April 14, 2019 20:47

Merge remote-tracking branch 'upstream/master' into converteditextern…

287021d

…alfiles * upstream/master: Fix saving of Strings (#4876)

Pass l10n dialog title as parameter

1263b5d

rename to EditExternalFileTypeEntryDialog

56db85c

Siedlerchr mentioned this pull request Apr 14, 2019

Convert/rework rest of the Swing Dialogs to javafx #3861

Closed

36 tasks

Siedlerchr merged commit 0190a10 into master Apr 14, 2019

Siedlerchr deleted the converteditexternalfiles branch April 14, 2019 19:11

luizphilipe2 mentioned this pull request Jun 26, 2021

Convert AutoLinkFilesAction to JavafX luizphilipe2/jabref_experiment#32

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Convert ExternalFileTypeEntryEditor to javafx #4885

Convert ExternalFileTypeEntryEditor to javafx #4885

Siedlerchr commented Apr 14, 2019 •

edited

tobiasdiez left a comment

tobiasdiez Apr 14, 2019

tobiasdiez Apr 14, 2019

Siedlerchr Apr 14, 2019

tobiasdiez Apr 14, 2019

Siedlerchr Apr 14, 2019


		import com.airhacks.afterburner.views.ViewLoader;

		public class EditExternalFileTypeDialog extends BaseDialog<Void> {

Convert ExternalFileTypeEntryEditor to javafx #4885

Convert ExternalFileTypeEntryEditor to javafx #4885

Conversation

Siedlerchr commented Apr 14, 2019 • edited

tobiasdiez left a comment

Choose a reason for hiding this comment

tobiasdiez Apr 14, 2019

Choose a reason for hiding this comment

tobiasdiez Apr 14, 2019

Choose a reason for hiding this comment

Siedlerchr Apr 14, 2019

Choose a reason for hiding this comment

tobiasdiez Apr 14, 2019

Choose a reason for hiding this comment

Siedlerchr Apr 14, 2019

Choose a reason for hiding this comment

Siedlerchr commented Apr 14, 2019 •

edited