Draft proposal for improving FindUnlinkedFilesDialog #5453
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a draft proposal for #4652 FindUnlinkedFilesDialog.java will be converted to the MVVM pattern. The relevant thing to see ATM is the tests defined for the implementation at FindUnlinkedFilesViewModelTest.java
Siedlerchr
reviewed
Oct 16, 2019
| import org.jabref.gui.util.FileFilterConverter; | ||
| import org.jabref.logic.util.StandardFileType; | ||
|
|
||
| import com.sun.star.util.DateTime; |
There was a problem hiding this comment.
Please use the java 8 date classes, the LocalDateTime: https://www.baeldung.com/java-8-date-time-intro
|
For creating the FXML we use the Scene Builder: https://gluonhq.com/products/scene-builder/ (java 11+) |
|
First impression: Looks good. 🎉 |
|
@cmoralesmx Could you add a screenshot please? |
|
@cmoralesmx I feel sad that there was no follow-up here. I will close the PR. Feel free to reopen the PR when you resume working on the issue. |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the discussion at #4652, findUnlinkedFilesDialog.java will be converted to the MVVM pattern and filtering functionality based on the date of file creation will be added.
The relevant thing to see ATM is the tests defined for the proposed implementation at FindUnlinkedFilesViewModelTest.java