Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support latest version of Jpackage #5559

Merged
merged 3 commits into from Nov 3, 2019

Conversation

@UltimaBGD
Copy link
Contributor

UltimaBGD commented Nov 3, 2019

This PR addresses the problems discussed in #5520 regarding the version update of JPackage.

We noted that the wix file created had a name change, so we took a copy of the wix file and stored it in the buildres folder for windows. As a result, the windows script needed to be changed to locate the wix file.


  • Change in CHANGELOG.md described - No, all internal, no visible changes
  • Tests created for changes -> None created, was made to ensure the build passes
  • Manually tested changed features in running JabRef -> No, regards building JabRef
  • Screenshots added in PR description (for bigger UI changes) - No UI changes
  • Ensured that the git commit message is a good one - I tried
  • Check documentation status (Issue created for outdated help page at help.jabref.org?) - Unsure what this one is asking
@UltimaBGD

This comment has been minimized.

Copy link
Contributor Author

UltimaBGD commented Nov 3, 2019

I was unsure what to do about the checklist at the bottom as this sort of PR tends not to check many of the boxes. I can remove it if you would like a cleaner message.

@Siedlerchr

This comment has been minimized.

Copy link
Contributor

Siedlerchr commented Nov 3, 2019

@UltimaBGD Thank you very much for your PR. For such cases you can ignore the checklists.

@Siedlerchr Siedlerchr merged commit b9eac2e into JabRef:master Nov 3, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@stefan-kolb stefan-kolb mentioned this pull request Nov 5, 2019
9 of 22 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.