Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various fixes to the dark theme #5764

Merged
merged 4 commits into from
Dec 18, 2019
Merged

Conversation

calixtus
Copy link
Member

@calixtus calixtus commented Dec 17, 2019

Some visual bugs were still in the dark theme present. This is a quick fix:

  • Many icons where dark black. They use the standard text color now.
  • Wrong highlight color of the mark symbol in menus is now highlight text color.
  • The thin white line between the menubar and the toolbar is gone. ( fixes White line on screens scaled != 100% #5753 )
  • The background on starting up JabRef was white until a library was loaded.
  • The unselected checkbox border was black, only while the unselected radio-buttons were grey. Now they are all grey in various shades. (less then 50)
  • The group color indicator was unreadable, as the grey border was too ... grey. It's more lightweight now.
  • The CodeArea in the in the entry source editor and in the preview preferences had the wrong background color, caret color, selection background color, line number colors and some highlights were unreadable. They use the common color scheme now. ( refs #5522-comment )
  • The citations tab was bright white, had some windows specific fonts encoded and some obscure font size settings. It uses the common color scheme now and the font settings are a bit equalized.
  • The dark tab header bar in the preview preferences was too heavy. It uses the common background color now.
  • The related articles tab in the entry editor presents the gdpr warning some smaller font size, it wraps according to the window width, shows a heading and has a fancy yellow border around it.
  • Fixed a typo ("Mr DLib." instead of "Mr. DLib")
  • The TexParserResult dialog is now presented in a SplitPane.

Except the Mr. DLib tab, the light theme should not be affected.

Some screenshots before:
bright checks dark tabbar
indist group indicator inconsistent control colors
search icon

And after:
better group bars source editor icons mrdlib
previewprefs
checkboxes and icons

  • Change in CHANGELOG.md described (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for bigger UI changes)
  • Checked documentation: Is the information available and up to date? If not: Issue created at https://github.com/JabRef/user-documentation/issues.

@Siedlerchr
Copy link
Member

Thanks for the good work! Loosk good to me! I merge now.
It's just a bit confusing that github actions are not running on upstream but on your fork when you create a PR.

@Siedlerchr Siedlerchr merged commit 28d3439 into JabRef:master Dec 18, 2019
@calixtus
Copy link
Member Author

Maybe GitHub likes me more than you. 😁
No, in fact it's annoying to me too, because I get an email every half an hour, that a build could not be uploaded to builds.jabref.org .

@calixtus calixtus deleted the dark_theme_polish branch December 18, 2019 08:10
@Siedlerchr
Copy link
Member

@calixtus That's the first thing I disabled: https://github.com/settings/notifications

Siedlerchr added a commit that referenced this pull request Dec 20, 2019
# By Tobias Diez (11) and others
# Via GitHub (1) and Tobias Diez (1)
* upstream/master: (29 commits)
  Improve things arround change detection (#5770)
  Revert "Update to most recent journal abbreviation list" (#5769)
  Various fixes to the dark theme (#5764)
  Bump mockito-core from 3.2.0 to 3.2.4 (#5760)
  Bump classgraph from 4.8.58 to 4.8.59 (#5761)
  Improve dependency update rules
  Update jpackage to build 27 (#5758)
  Persistent column sortorder (#5730)
  Fix medline fetcher/importer when using installer (#5752)
  New Crowdin translations (#5751)
  Bump byte-buddy-parent from 1.10.4 to 1.10.5 (#5750)
  Fix checkstyle
  Fix filename
  Update to most recent journal abbreviation list
  Remove obsolete string
  Revert "Switch back to development"
  Switch back to development
  Next development cycle
  Release 5.0-beta (#5684)
  Fix multiple entries allowed in crossref (issue #5284) (#5724)
  ...

# Conflicts:
#	src/main/java/org/jabref/gui/collab/ChangeDisplayDialog.java
#	src/main/java/org/jabref/gui/collab/EntryChangeViewModel.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

White line on screens scaled != 100%
2 participants