Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reintroducing master table index column #5844

Merged
merged 3 commits into from
Jan 21, 2020

Conversation

calixtus
Copy link
Member

@calixtus calixtus commented Jan 18, 2020

Missed me?

index column

fixes #5675

  • Change in CHANGELOG.md described (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for bigger UI changes)
  • Checked documentation: Is the information available and up to date? If not: Issue created at https://github.com/JabRef/user-documentation/issues.

@calixtus calixtus changed the title Added master table index column Reintroducing master table index column Jan 18, 2020
@calixtus calixtus added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Jan 18, 2020
Copy link
Member

@tobiasdiez tobiasdiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

(Do I understand it correctly, that the index column is not shown by default? That would be namely the solution that I prefer.)

@calixtus
Copy link
Member Author

Yes. It's off by default and can be added by the main table column preferences, just like any other column.

@Siedlerchr
Copy link
Member

Thanks, looks good to me! I think someone in the forum was requesting this feature, would be nice if you could answer there

@Siedlerchr Siedlerchr merged commit f4847b1 into JabRef:master Jan 21, 2020
@calixtus calixtus deleted the number_column branch January 21, 2020 07:56
Siedlerchr added a commit that referenced this pull request Jan 26, 2020
# By dependabot-preview[bot] (2) and others
# Via GitHub (1) and github actions (1)
* upstream/master:
  New Crowdin translations (#5864)
  Bump antlr4 from 4.7.2 to 4.8-1 (#5852)
  Reintroducing master table index column (#5844)
  Bump antlr4-runtime from 4.7.2 to 4.8-1 (#5851)
  Improve performance by throttling database change events (#5843)
  Squashed 'src/main/resources/csl-styles/' changes from 9c0f5c6..f0c7374

# Conflicts:
#	src/main/resources/l10n/JabRef_en.properties
Siedlerchr added a commit that referenced this pull request Jan 30, 2020
* master: (297 commits)
  Replace link to Workspace set-up with new one (#5896)
  Fixes making paths of linked files relative (web urls will not be touched anymore) (#5879)
  Switch to our IntelliJ config (#5881)
  Bump unirest-java from 3.4.00 to 3.4.01 (#5874)
  Bump junit-vintage-engine from 5.5.2 to 5.6.0 (#5875)
  Bump checkstyle from 8.28 to 8.29 (#5876)
  Bump junit-jupiter from 5.5.2 to 5.6.0 (#5877)
  Bump junit-platform-launcher from 1.5.2 to 1.6.0 (#5878)
  Change \ to /
  Bump byte-buddy-parent from 1.10.6 to 1.10.7 (#5873)
  Fix opening pdf with okular in linux (#5253) (#5855)
  Fixed Test
  Refactored constructors, PreferencesService and some minor improvements.
  Remove ampersand escape when writing to bib file (#5869)
  Fix #5862. It was indeed the throttler (at least it is working now for me) (#5868)
  duplicate query parameter removed (#5865)
  New Crowdin translations (#5864)
  Minor refactoring, and changed comment
  Bump antlr4 from 4.7.2 to 4.8-1 (#5852)
  Reintroducing master table index column (#5844)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Counts of selected items
3 participants