Integrate gradle validation in normal test workflow #6001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobiasdiez
added
the
status: ready-for-review
Siedlerchr
reviewed
Feb 23, 2020
| @@ -208,3 +208,11 @@ jobs: | |||
| CI: "false" # we pretend to run locally - even if tests fail on the CI, they count towards test coverage | |||
| CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }} | |||
| DBMS: "postgresql" | |||
| # This is https://github.com/marketplace/actions/gradle-wrapper-validation | |||
| # It ensures that the jar file is from gradle and not by a strange third party. | |||
| gradlevalidation: | |||
There was a problem hiding this comment.
It should run before any gradle task otherwise it's nonsene
There was a problem hiding this comment.
They run in parallel as you see below...
There was a problem hiding this comment.
Maybe it's even easier to just include the step before running any Gradle actions, i.e. first step after checkout uses: gradle/wrapper-validation-action@v1. Dunno how long the task takes, but in that case we are sure that the test action fails which will be valued a lot more than just a parallel task that can be ignored?
But it's ok like that as well.
There was a problem hiding this comment.
It's unlikely that we get get a malicious file...
Siedlerchr
added a commit
that referenced
this pull request
Feb 26, 2020
* upstream/master: (21 commits) Squashed 'src/main/resources/csl-locales/' changes from 4fa753374e..d73af4a3fe Squashed 'src/main/resources/csl-styles/' changes from 9e81857..f03dece Add deep link to uni Basel Refine information on codacy New Crowdin translations (#6020) Fix l10n New Crowdin translations (#6016) Fix teamscale link - and sort list alphabetically Update code-quality.md Update link to codacy/JabRef Integrate gradle validation in normal test workflow (#6001) Update CleanupUrlFormatter.java Update URLUtil.java Fix modernizer warnings Remove unused error prone Use Java version class Remove commented out code Upgrade deprecated gradle API Add plugin scope New menu "Lookup" ...
Siedlerchr
added a commit
that referenced
this pull request
Mar 6, 2020
* upstream/master: Fix teamscale link - and sort list alphabetically Update code-quality.md Update link to codacy/JabRef Integrate gradle validation in normal test workflow (#6001) Fixed group drag-n-drop not working after inserting an article into a group (#6008) New Crowdin translations (#5998) Bump richtextfx from 0.10.3 to 0.10.4 (#6007) Bump unirest-java from 3.5.00 to 3.6.00 (#6006) Bump com.github.ben-manes.versions from 0.27.0 to 0.28.0 (#6004) Bump classgraph from 4.8.64 to 4.8.65 (#6003) Bump mockito-core from 3.2.4 to 3.3.0 (#6005)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think we need an extra workflow for the gradle wrapper validation.