delete bug fix #7580
delete bug fix #7580
Conversation
|
Can you please explain your changes and what you did and why? |
|
I was kind of overwhelmed at first so I went ahead and read the code and the places i was pointed towards. I found that the keybindings part of the code did not have a delete function in it. So going I added the delete function in the use case function and tested it out again manually and found that the bug was not repeated. |
|
Please always at least refer to a concrete issue and add a small explanation.this helps us to understand the changes and their context |
|
@BenArou Which OS are you using? Is your intention to change the key binding for delete? |
|
I'm using windows 10, my intention is to make the delete function consistent and not interfere with other functions |
|
I think this could cause issues on mac, will need to test this |
|
Okay, I test it on mac and seems to work. I still don't understand why you added them, does this fix a bug? If yes please describe? Is there a related issue? @BenArou |
|
Can one configure a key binding for the delete functionality now? |
|
Please provide a screenshot of the keybindings dialog, if possible. |
koppor
added
the
status: waiting-for-feedback
|
Summary: The reconfiguration of the DELETE key was not applied to the main table. We added a CHANGELOG entry: add694a |
* upstream/main: (354 commits) Fix ScienceDirect fetcher (#7684) Refactor NoBibTexFieldCheckerTest to increase mutation coverage (#7697) Update Gradle from 6.8.3 to 7.0 (#7619) Fixes #7305: the RFC fetcher is not compatible with the draftFix for issue 7305 (#7674) Refactoring existing unit tests (#7693) cover boundary cases & add more unit tests (#7694) Bump classgraph from 4.8.104 to 4.8.105 (#7688) Bump java-diff-utils from 4.9 to 4.10 (#7692) Fix arXiv fetcher tests (#7686) Make key for ScienceDirect configurable (#7683) migration of timestamp (#7671) Fix CCSB and DOAJ (#7426) [Bot] Update CSL styles (#7680) MS Office XML: Export month name (#7677) linkfix (#7678) readd fix (#7675) Fix threading cleanup in performSearch (#7672) add missing changelog delete bug fix (#7580) Add more unit tests to three gui classes (#7636) ... # Conflicts: # build.gradle
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)