Add query validation for web search #7809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Carl Christian Snethlage <50491877+calixtus@users.noreply.github.com>
koppor
added
the
status: ready-for-review
1 task
Co-authored-by: Carl Christian Snethlage <50491877+calixtus@users.noreply.github.com>
koppor
removed
the
status: ready-for-review
|
Commit We have the issue that the validation message itself is not shown. @calixtus can you have a look? |
koppor
commented
Jun 9, 2021
src/main/java/org/jabref/gui/importer/fetcher/WebSearchPane.java
Outdated
Show resolved
Hide resolved
Siedlerchr
reviewed
Jun 9, 2021
src/main/java/org/jabref/gui/importer/fetcher/WebSearchPaneViewModel.java
Show resolved
Hide resolved
|
Seems like something with the visualization is not right. Very strange, since inverse it works...
|
|
We need to show the error message in a text field (which is shown if an error message is available) |
Co-authored-by: Carl Christian Snethlage <50491877+calixtus@users.noreply.github.com> Co-authored-by: Christoph <siedlerkiller@gmail.com>
Siedlerchr
added
the
status: ready-for-review
koppor
removed
the
status: ready-for-review
tobiasdiez
reviewed
Jun 21, 2021
tobiasdiez
reviewed
Jun 21, 2021
| if (stateManager.getActiveDatabase().isEmpty()) { | ||
| dialogService.notify(Localization.lang("Please open or start a new library before searching")); | ||
| return; | ||
| } | ||
|
|
||
| SearchBasedFetcher activeFetcher = getSelectedFetcher(); | ||
| Globals.getTelemetryClient().ifPresent(client -> client.trackEvent("search", Map.of("fetcher", activeFetcher.getName()), Map.of())); |
There was a problem hiding this comment.
here as well, and please no globals...
|
I've got a small cleanup branch for the preferences dialog in the pipeline, that will be made a PR in the next days addressing the remaining issues. |
Siedlerchr
added a commit
that referenced
this pull request
Jun 22, 2021
* upstream/main: New Crowdin updates (#7843) Refactoring and addition of unit tests (#7597) CLI option to write XMP metadata to pdfs (#7814) Add query validation for web search (#7809) change eclipse default output dir (#7842) Bump lucene-queryparser from 8.8.2 to 8.9.0 (#7835) Bump libreoffice from 7.1.3 to 7.1.4 (#7836) Bump postgresql from 42.2.21 to 42.2.22 (#7839) Bump org.eclipse.jgit (#7838) Bump byte-buddy-parent from 1.11.2 to 1.11.5 (#7837) Bump unoloader from 7.1.3 to 7.1.4 (#7841) Ms Office Export patent author as inventor (#7831) Abbreviation toggle within the JournalEditorViewModel now ignores curly braces (issue #7773) (#7807)
Siedlerchr
added a commit
that referenced
this pull request
Jun 30, 2021
* upstream/main: (26 commits) Add unit test to four test classes (#7651) Fix IEEE test (#7852) New Crowdin updates (#7859) Fix markdown syntax of ADRs add missing l10n (#7857) New Crowdin updates (#7847) Bump mockito-core from 3.11.1 to 3.11.2 (#7856) Bump checkstyle from 8.43 to 8.44 (#7855) Fix for issue #4652: Add Find Unlinked Files Filter based on Date (#7846) Fix for entering a backslash in the custom entry preview dialog (#7851) Fixed INSPIREFetcherTest Fixed TitleFetcherTest Ignore baeldung.com and tldrlegal.com from out link checks New Crowdin updates (#7845) New Crowdin updates (#7843) Refactoring and addition of unit tests (#7597) CLI option to write XMP metadata to pdfs (#7814) Add query validation for web search (#7809) change eclipse default output dir (#7842) Bump lucene-queryparser from 8.8.2 to 8.9.0 (#7835) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7411
Refs #7575
CHANGELOG not required, because last released version contained a query validator (see #7391 (comment)). We removed it, because we switched to a general lucene query syntax in #7350
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)