Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add doc tests #8242

Merged
merged 5 commits into from
Dec 1, 2021
Merged

Add doc tests #8242

merged 5 commits into from
Dec 1, 2021

Conversation

koppor
Copy link
Member

@koppor koppor commented Nov 14, 2021

This adds test cases mirroring our documentation at https://docs.jabref.org/finding-sorting-and-cleaning-entries/search#general-syntax.

Currently, fails, because the search requires "RegEx" to be enabled, even if the search term does not contain any regex (and the help doesn't demand either).

Either this needs to be solved or #8206 be finished (with the decisions there).

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@koppor koppor added the search label Nov 14, 2021
@Siedlerchr
Copy link
Member

The doc clearly says that RegEx has to be enabled!
grafik

@koppor
Copy link
Member Author

koppor commented Nov 14, 2021

The doc clearly says that RegEx has to be enabled!

Oh, wow. Very strange expectation, isn't it?

@Siedlerchr
Copy link
Member

I think in older versions this was named "advanced search mode"

@koppor
Copy link
Member Author

koppor commented Nov 14, 2021

Added RegEx. anykeyword and anyfield still not working

@koppor
Copy link
Member Author

koppor commented Nov 23, 2021

I disabled the non-working tests.

Proposal: Merge and then get this running the context of #8206

@Siedlerchr Siedlerchr marked this pull request as ready for review November 23, 2021 22:06
@koppor koppor requested a review from calixtus November 28, 2021 23:57
@Siedlerchr
Copy link
Member

Can you add a test for #8287

@koppor
Copy link
Member Author

koppor commented Nov 30, 2021

Not now. Can we do that as follow-up?

@ThiloteE
Copy link
Member

What i reported in #8287 is annoying and i think being able to search for a whole sentence rather than a single word would be something that should be within the standard repertoire of Jabrefs search syntax (grouping words together into a single phrase for exact matches) but at the same time for me personally it is not an issue that i would deem urgent at the moment.

If you are thinking about implementing a whole new search syntax (Lucene) and Lucene would be better than what we currently have (i don't know enough about the current search syntax and Lucene to make this call), then implementing Lucene should be considered to precede issue #8287.

@Siedlerchr Siedlerchr merged commit 4f11b08 into main Dec 1, 2021
@Siedlerchr Siedlerchr deleted the add-doc-tests branch December 1, 2021 19:26
Siedlerchr added a commit that referenced this pull request Dec 4, 2021
* upstream/main: (259 commits)
  Fix exception on preview style edit and selection (#8293)
  Fix icon picker excpetion in groups dialog (#8290)
  Add doc tests (#8242)
  fix merge conflict
  Squashed 'buildres/csl/csl-locales/' changes from 0cc3885f61..d5ee85de8e
  Squashed 'buildres/csl/csl-styles/' changes from 3a6a0a7..3bb4b5f
  Consider directory pattern when checking if a file can be moved (#8244)
  Bump byte-buddy-parent from 1.12.1 to 1.12.2 (#8285)
  Bump unirest-java from 3.13.3 to 3.13.4 (#8283)
  Bump checkstyle from 9.1 to 9.2 (#8284)
  Bump classgraph from 4.8.135 to 4.8.137 (#8282)
  Do not resize main table columns in search dialog window (#8253)
  Fix NegativeArraySizeException (#8270)
  Update deployment.yml
  TEst
  Grand unified library properties (GRULPS) (#8264)
  Fixes RFC fetcher test case (#8271)
  Update Gradle Wrapper from 7.2 to 7.3 (#8246)
  Observable Preferences H (WorkingDir, getUser, NameFormatter, Version, SpecialFields) (#8260)
  Bump checkstyle from 9.0.1 to 9.1 (#8266)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants