Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for opening console on active database #8492

Merged
merged 7 commits into from
Feb 9, 2022
Merged

Fix for opening console on active database #8492

merged 7 commits into from
Feb 9, 2022

Conversation

RyanEubank
Copy link
Contributor

Fixes #8466

Opening console from drop down menu on toolbar now opens console at the location of the currently active
database as intended.

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@RyanEubank
Fix an issue opening console from menu
89bf361 
The change fixes an issue where opening the console at the current library caused a null reference exception. The original error occurred due to an explicit null value being passed into the action's constructor. The fix supplies the correct database to the action when called.

See: JabRef#8466
@RyanEubank
Add unit test for opening console
40a28d2 
Added Junit tests cases to verify that commands retrieve the correct database, and that the command defaults to the active database otherwise.

Tests cases added in response to a bug fix, see: JabRef#8466
@RyanEubank
Merge branch 'JabRef:main' into fix-for-issue-8466
d8fb84d
@RyanEubank
Update CHANGELOG.md
1734657 
Update for style correction
@RyanEubank
Merge branch 'fix-for-issue-8466' of https://github.com/RyanEubank/ja…
4a11923 
…bref into fix-for-issue-8466
@RyanEubank
Update CHANGELOG.md
4b2a4e4
@RyanEubank
Merge branch 'fix-for-issue-8466' of https://github.com/RyanEubank/ja…
90fc6a6 
…bref into fix-for-issue-8466
@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Feb 9, 2022
Siedlerchr
Siedlerchr approved these changes Feb 9, 2022
View reviewed changes
Copy link
Member

@Siedlerchr Siedlerchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix and also a huge plus for the tests ❤️

@Siedlerchr Siedlerchr merged commit de114d5 into JabRef:main Feb 9, 2022
Siedlerchr added a commit that referenced this pull request Sep 2, 2022
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into dbsync
08f243a 
* upstream/main:
  Update Gradle Wrapper from 7.3.3 to 7.4. (#8499)
  Bump flexmark-ext-gfm-strikethrough from 0.62.2 to 0.64.0 (#8500)
  Bump tika-core from 2.2.1 to 2.3.0 (#8501)
  Bump classgraph from 4.8.138 to 4.8.139 (#8502)
  Fix for opening console on active database (#8492)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Siedlerchr Siedlerchr Siedlerchr approved these changes

Assignees
No one assigned
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Menu "Open terminal here" causes an uncaught exception
2 participants
@RyanEubank @Siedlerchr