Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix links and add sloppy_names for IDL plugin upgrade #282

Merged
merged 8 commits into from
Aug 30, 2021
Merged

Conversation

rnc
Copy link
Member

@rnc rnc commented Aug 29, 2021

No description provided.

@rnc rnc force-pushed the BR1 branch 2 times, most recently from f1d7514 to b3bbc2a Compare August 29, 2021 17:53
@jwillemsen
Copy link
Contributor

You could use a schedule to run your action weekly even when there are no changes and a workflow_dispatch so that you can start the action also manually, see https://github.com/RemedyIT/axcioma/blob/03692f37e17b33cd72088d15ac2d9f720472c627/.github/workflows/linux.yml#L14 for an example

@rnc
Copy link
Member Author

rnc commented Aug 30, 2021

You could use a schedule to run your action weekly even when there are no changes and a workflow_dispatch so that you can start the action also manually, see RemedyIT/axcioma@03692f3/.github/workflows/linux.yml#L14 for an example

@jwillemsen That doesn't avoid the problem that its giving broken updates (See the spring revert changes). Security changes only would be ok but they can only be configured by the UI not in the config file currently in the v2 schema I believe. Therefore its seems more trouble than its worth.

@jwillemsen
Copy link
Contributor

@jwillemsen That doesn't avoid the problem that its giving broken updates (See the spring revert changes). Security changes only would be ok but they can only be configured by the UI not in the config file currently in the v2 schema I believe. Therefore its seems more trouble than its worth.

The schedule/workflow_dispatch isn't related to updates, schedule runs your action on a crontab so that it also runs for example weekly without any changes, that way when something on github action changes you know at least the action works, and the workflow_dispatch enabled you to manually run the action independent of a PR

@rnc
Copy link
Member Author

rnc commented Aug 30, 2021

@jwillemsen That doesn't avoid the problem that its giving broken updates (See the spring revert changes). Security changes only would be ok but they can only be configured by the UI not in the config file currently in the v2 schema I believe. Therefore its seems more trouble than its worth.

The schedule/workflow_dispatch isn't related to updates, schedule runs your action on a crontab so that it also runs for example weekly without any changes, that way when something on github action changes you know at least the action works, and the workflow_dispatch enabled you to manually run the action independent of a PR

Sorry I thought you were referring to the dependabot removal. The GH action has been configured to run on PR and deploy on snapshot ; that configuration I have used successfully in e.g. https://github.com/release-engineering/pom-manipulation-ext

@jwillemsen
Copy link
Contributor

Ok, good to hear that it works. We did have cases where github changes something on their runners which broke our action, the schedule is now helpful to at least detect that in a quiet development period.

@rnc rnc merged commit 961dfd6 into JacORB:master Aug 30, 2021
@rnc rnc deleted the BR1 branch August 30, 2021 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants