Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make use of new List widget item refresh #99

Closed
2 tasks done
Jacalz opened this issue Aug 14, 2023 · 6 comments
Closed
2 tasks done

Make use of new List widget item refresh #99

Jacalz opened this issue Aug 14, 2023 · 6 comments
Assignees
Labels
performance Improve application performance
Milestone

Comments

@Jacalz
Copy link
Owner

Jacalz commented Aug 14, 2023

Checklist

  • I have searched the issue tracker for open issues that relate to the same feature, before opening a new one.
  • This issue only relates to a single feature. I will open new issues for any other features.

Is your feature request related to a problem?

We are currently refreshing the whole list (it probably only updates the visible items but anyhow) when we only have changed one item. Fyne v2.4.0 has a new API for refreshing an item at a specific ID. Using that would improve the performance for refreshing items.

Describe the solution you'd like to see.

We might want to keep track of the item id in the item struct and have it call refresh item. Deleting an item would have to update all of the item ids and keep some kind of lock to make sure that we don't refresh the wrong item (or crash).

@Jacalz Jacalz added enhancement New feature or request performance Improve application performance and removed enhancement New feature or request labels Aug 14, 2023
@Jacalz Jacalz added this to the v3.6.0 milestone Aug 23, 2023
@Jacalz Jacalz added the good first issue Good for newcomers label Oct 17, 2023
@Jacalz Jacalz self-assigned this Oct 26, 2023
@Jacalz Jacalz removed the good first issue Good for newcomers label Oct 26, 2023
@GalihFajar
Copy link

Hey @Jacalz I just worked on this one, didn't realize you were assigned 😅 . Feel free to drop my PR.

@Jacalz Jacalz assigned Jacalz and unassigned Jacalz Oct 26, 2023
@Jacalz
Copy link
Owner Author

Jacalz commented Oct 26, 2023

Like I stated on the PR, the approach isn't the right one unfortunately and it is a bit complicated to get right (why I removed the good-first-issue) tag. If you want me to take this on instead I can do that.

@GalihFajar
Copy link

Sure, I'll withdraw the PR instead. I didn't really get the expected solution

@Jacalz
Copy link
Owner Author

Jacalz commented Oct 26, 2023

Sure. I hope you didn't take any offence. I'm very glad of your work and finally seeing some contributions here :)

@GalihFajar
Copy link

surely none taken 😆

Jacalz added a commit that referenced this issue Oct 30, 2023
Only refresh the item in the list corresponding to the specific transfer.

Fixes #99
@Jacalz
Copy link
Owner Author

Jacalz commented Oct 30, 2023

I've fixed this with e546ab5 initially. Might need some more locking but I'd have to think about that to avoid introducing potential for deadlocks.

@Jacalz Jacalz closed this as completed Oct 30, 2023
Jacalz added a commit that referenced this issue Oct 31, 2023
Only refresh the item in the list corresponding to the specific transfer.

Fixes #99
Jacalz added a commit that referenced this issue Dec 29, 2023
Only refresh the item in the list corresponding to the specific transfer.

Fixes #99
Jacalz added a commit that referenced this issue Jan 24, 2024
Only refresh the item in the list corresponding to the specific transfer.

Fixes #99
Jacalz added a commit that referenced this issue Mar 18, 2024
Only refresh the item in the list corresponding to the specific transfer.

Fixes #99
Jacalz added a commit that referenced this issue Apr 12, 2024
Only refresh the item in the list corresponding to the specific transfer.

Fixes #99
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Improve application performance
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants