-
-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make use of new List widget item refresh #99
Comments
Hey @Jacalz I just worked on this one, didn't realize you were assigned 😅 . Feel free to drop my PR. |
Like I stated on the PR, the approach isn't the right one unfortunately and it is a bit complicated to get right (why I removed the good-first-issue) tag. If you want me to take this on instead I can do that. |
Sure, I'll withdraw the PR instead. I didn't really get the expected solution |
Sure. I hope you didn't take any offence. I'm very glad of your work and finally seeing some contributions here :) |
surely none taken 😆 |
Only refresh the item in the list corresponding to the specific transfer. Fixes #99
I've fixed this with e546ab5 initially. Might need some more locking but I'd have to think about that to avoid introducing potential for deadlocks. |
Only refresh the item in the list corresponding to the specific transfer. Fixes #99
Only refresh the item in the list corresponding to the specific transfer. Fixes #99
Only refresh the item in the list corresponding to the specific transfer. Fixes #99
Only refresh the item in the list corresponding to the specific transfer. Fixes #99
Only refresh the item in the list corresponding to the specific transfer. Fixes #99
Checklist
Is your feature request related to a problem?
We are currently refreshing the whole list (it probably only updates the visible items but anyhow) when we only have changed one item. Fyne v2.4.0 has a new API for refreshing an item at a specific ID. Using that would improve the performance for refreshing items.
Describe the solution you'd like to see.
We might want to keep track of the item id in the item struct and have it call refresh item. Deleting an item would have to update all of the item ids and keep some kind of lock to make sure that we don't refresh the wrong item (or crash).
The text was updated successfully, but these errors were encountered: