Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eyeD3.js: genre field should be of type string #6

Closed
wants to merge 2 commits into from
Closed

eyeD3.js: genre field should be of type string #6

wants to merge 2 commits into from

Conversation

yashafromrussia
Copy link
Contributor

Genre field for eyeD3: All is possible: std ID3 genre names, ids and any other
If you set genre field to a string value, eyeD3 fails with the following message:

Error: Command failed: /bin/sh: 1: B: not found
Usage
=====
eyeD3 [OPTS] file [file...]
eyeD3: error: File/directory argument(s) required

@coveralls
Copy link

Coverage Status

Coverage remained the same at 80.38% when pulling 0a8888a on gorjuspixels:master into 72ac031 on Jack12816:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.14%) to 80.24% when pulling e99fd64 on gorjuspixels:master into 72ac031 on Jack12816:master.

@Jack12816
Copy link
Owner

Sounds good. :) Is the --to-v2.3 flag supported by eyeD3 0.6 and 0.7? And could you change the commit messages to fit the schema? ([Writer][eyeD3] ...)

@Jack12816
Copy link
Owner

After some thinking it looks like two features. Could you split it into multiple MRs?

@yashafromrussia
Copy link
Contributor Author

Okk, created a new pull request for the genre bug: #7
Pull request for --to-v2.3 flag is moved to #8

Closing this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants