Fix: #21 Note count off settings not respected

JackGruber · Aug 7, 2021 · 8573716 · 8573716
1 parent c1f4d0b
commit 8573716
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/src/noteoverview.ts b/src/noteoverview.ts
@@ -522,16 +522,20 @@ export namespace noteoverview {
   }
 
   export async function loadGlobalSettings() {
+    globalSettings = {};
     globalSettings.dateFormat = await joplin.settings.globalValue("dateFormat");
     globalSettings.timeFormat = await joplin.settings.globalValue("timeFormat");
     globalSettings.statusText = await noteoverview.getDefaultStatusText();
     globalSettings.coloring = await noteoverview.getDefaultColoring();
     const showNoteCount = await joplin.settings.value("showNoteCount");
-    if (showNoteCount !== false) {
+    if (showNoteCount !== "off") {
       globalSettings.showNoteCount = {
+        enable: true,
         position: showNoteCount,
         text: await joplin.settings.value("showNoteCountText"),
       };
+    } else {
+      globalSettings.showNoteCount = { enable: false };
     }
   }
 

diff --git a/src/settings.ts b/src/settings.ts
@@ -20,14 +20,14 @@ export namespace settings {
         description: "0 = disable automatic note overview creation",
       },
       showNoteCount: {
-        value: "Off",
+        value: "off",
         type: SettingItemType.String,
         section: "noteOverviewSection",
         isEnum: true,
         public: true,
         label: "Show note count",
         options: {
-          false: "Off",
+          off: "Off",
           above: "Above",
           below: "Below",
         },