update to v1.3 #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # docs/getting-started/upgrading.md
# Conflicts: # docs/getting-started/upgrading.md
remember old input upon form submit
* Validate fields without ajax Validate fields without ajax * Remove without ajax comments
It was not possibile to delete a file uploaded in settings
$this->getContentBasedOnType() returns null if thereis no file uploaded.
* Manage deletion of uploaded files Transfer remove method from VoyagerMediaController to VoyagerBaseController Created new route changed permission check remove file and thumbnails from file system * fixed template for posts * Disambiguation Changed route and method name * Removed unused dependency
* Fix media picker formfield default expanded issue Although there is an option to expand the media picker as a formfield by default, this line will cause the media picker to be collapsed by default every time regardless of the value. * Change docs to match default expanded
* validateBread must take array as an attribute validateBread must take array as an attribute in /src/Http/Controllers/Controller.php but not Request object. Cause it returns `Validator::make($request, $rules, $messages, $customAttributes);` And as we know `Validator::make` works with arrays. * Rename variables
* Avoid urlencoded title of Breadcrumb If the route contains space, breadcrumb shows the URL encoded text as breadcrumb item. Like, if Route is 'Consumer Report', Breadcrumb will show Consumer%20report, it should be 'Consumer Report'. I changed the Breadcrumb title URL decoded. * Fixed the code
Also fixed that when selecting the "None" option it would just be added to the list instead of removing all options. Works also for
* Change faulty route-usage * Remove non-existing multilingual.js from read-view This file is included from the main app.js already and doesn't exist in /published
* Use custom guard-name throughout Voyager * Apply fixes from StyleCI (#4382) * Remove voyager.user.namespace config and use guard instead * Add docs, fix some small problems Add docs to use a different user-table. Other models use other keys for roles - hardcoded them * Update docs * Hide profile button if custom guard is set and no datatype exists * Update docs Co-Authored-By: Adam Nielsen <iwasherefirst2@users.noreply.github.com> * Apply fixes from StyleCI (#4391)
* Update roles-and-permissions.md Include introductions how to use permissions for custom pages and hiding it in the menu. * Update roles-and-permissions.md I added in detail that one has to add a custom gate * Compile assets * Update docs/core-concepts/roles-and-permissions.md Co-Authored-By: Christoph Schweppe <info@cschweppe.de> * Update docs/core-concepts/roles-and-permissions.md Co-Authored-By: Christoph Schweppe <info@cschweppe.de> * Update docs/core-concepts/roles-and-permissions.md Co-Authored-By: Christoph Schweppe <info@cschweppe.de> * Update docs/core-concepts/roles-and-permissions.md Co-Authored-By: Christoph Schweppe <info@cschweppe.de> * Update docs/core-concepts/roles-and-permissions.md Co-Authored-By: Christoph Schweppe <info@cschweppe.de> * Update docs/core-concepts/roles-and-permissions.md Co-Authored-By: Christoph Schweppe <info@cschweppe.de> * Revert "Merge branch '1.2' into patch-1" This reverts commit 225119c, reversing changes made to 3034f14. * Revert non-existing changes from 1.2
When loading a TinyMCE instance over HTTPS, a mixed content may arise. The bug and the solution is described in this issue : #4137
* add ư and ơ characters * lowercase o
* Migrating test/code-coverage from TravisCI to github actions * Adding asset compilation task * commenting steps * Rmoving unnecessary events * Adding npm setup to compile workflow
* Fixed wrong order change fieldName after we use the original value * Added tests Co-authored-by: Eric Fletcher <fletch3555@users.noreply.github.com>
Change VoyagerBreadController (default) to VoyagerRoleController into DataTypesTableSeeder
* Remove duplicate route "voyager.roles.update" * Override, params roles in Role Route Co-authored-by: Eric Fletcher <fletch3555@users.noreply.github.com>
In case $dataRow didn't exists a string was passed to _field_trans instead of a json array. Just the default language is enough in json array. Co-authored-by: Eric Fletcher <fletch3555@users.noreply.github.com>
Co-authored-by: Eric Fletcher <fletch3555@users.noreply.github.com>
Routes needed to be defined on install for old Voyager versions because MenuItemsTableSeeder used to seed the full url into database. That's not the case anymore so this can be removed. This part of code was also causing routes on tests to be defined in a different order than normal use because on install Route was called before seeding DataTypes.
Because current example doesn't work and it doesn't really make any sense. Co-authored-by: Christoph Schweppe <info@cschweppe.de>
Merge old files with new ones Test for upload of second file Fixes #4196
* Updating initial changes to include a way to output more than 3 widgets on dashboard page. dimmers.blade.php now runs through an array filled with widgetGroups Voyager.php's 'dimmers()' function now returns an array filled wih WidgetGroups * Updating dimmers method in Voyager facade * Update dimmers.blade.php Removing old, commented code that is not needed anymore. * Updating voyager.php to fit with comment styling guidelines * Updating VoyagerTest.php Updating test and test documentation to fit with the current Dimmer paradigm Adding in a new test to go over a new constraint through this update. That a dimmer group can only have a max three dimmers. * update VoyagerTest.php * Update VoyagerTest.php Removing unnecessary test Co-authored-by: Eric Fletcher <fletch3555@users.noreply.github.com> Co-authored-by: Christoph Schweppe <info@cschweppe.de>
Co-authored-by: Eric Fletcher <fletch3555@users.noreply.github.com>
"CONSIDER ASKING IN SLACK FIRST" made it sound optional but since we are enforcing it I changed the sentence.
Intervention has updated the ImageServiceProvider from Laravel 5 to LaravelRecent for compatibility with Laravel6
Bumps [tinymce](https://github.com/tinymce/tinymce-dist) from 4.9.6 to 4.9.7. - [Release notes](https://github.com/tinymce/tinymce-dist/releases) - [Changelog](https://github.com/tinymce/tinymce-dist/blob/4.9.7/changelog.txt) - [Commits](tinymce/tinymce-dist@4.9.6...4.9.7) Signed-off-by: dependabot[bot] <support@github.com>
Direction set in BREAD settings, with server side enabled, was ignored. Changed logic for client side also because it was failing after the fix. Co-authored-by: Eric Fletcher <fletch3555@users.noreply.github.com>
With #4601 value was preserved but match for selected was still done with saved value not last submitted one. Co-authored-by: Eric Fletcher <fletch3555@users.noreply.github.com>
When there is a belongsTo relationship foreign key filed is removed with removeRelationshipField. When we try to get the $orderColumn we use collection index that is now skipping a value resulting on wrong or non existent column ordered in datatable VoyagerBaseController.php#L152
* Fix prepare translations check Right all traslatable fields need to be sent for add/update to succed. This PR intersect translatable with rows enabled for add/edit, so that check is performed only for rows that are supposed to be saved. While saving BREAD configuration this intersecttion is ignored. There is another PR #4620 fixing this bug that takes another approach. * remove use of reference Co-authored-by: Eric Fletcher <fletch3555@users.noreply.github.com>
* Eagerload data rows translations Eager load data rows and dataTypeContent translations. Currently only dataTypeContent is eagerloaded and only in brwose view. * StyleCI fixes Co-authored-by: Eric Fletcher <fletch3555@users.noreply.github.com>
* Eager load Menu Items translations When multilingual is enabled this PR removes one query for each menu item and adds one query for each nested group. * removed eagerload for non admin menu because it's already done inside the template -_-' Co-authored-by: Eric Fletcher <fletch3555@users.noreply.github.com>
is_bread_translatable doesn't work on collection, that's why $model was used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.