Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API: add unique user to storage stats #392

Merged
merged 11 commits into from
Apr 4, 2024

Conversation

TheMarstonConnell
Copy link
Member

Port of #391

@TheMarstonConnell TheMarstonConnell added the enhancement New feature or request label Dec 15, 2023
@TheMarstonConnell TheMarstonConnell self-assigned this Dec 15, 2023
Copy link
Member

@karnthis karnthis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why the inconsistent casing in proto/canine_chain/storage/query.proto? please update

Copy link

codecov bot commented Apr 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 46.81%. Comparing base (a13f5b5) to head (5c21cbe).

Files Patch % Lines
x/storage/keeper/grpc_query_storage_stats.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #392      +/-   ##
==========================================
- Coverage   46.83%   46.81%   -0.03%     
==========================================
  Files         211      211              
  Lines        6574     6577       +3     
==========================================
  Hits         3079     3079              
- Misses       3237     3240       +3     
  Partials      258      258              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TheMarstonConnell TheMarstonConnell merged commit 0abf4ca into master Apr 4, 2024
8 of 11 checks passed
@TheMarstonConnell TheMarstonConnell deleted the marston/unique-user-api branch April 4, 2024 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants