Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE]: Optionally add sklearn's TimeSeriesSplit #166

Closed
kspieks opened this issue Dec 7, 2023 · 3 comments
Closed

[FEATURE]: Optionally add sklearn's TimeSeriesSplit #166

kspieks opened this issue Dec 7, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@kspieks
Copy link
Collaborator

kspieks commented Dec 7, 2023

Our current time-based splitter only returns one split of the data. If users want multiple time-based splits, they would need to make multiple calls. We could definitely write a short function that wrap ours, but I'll just also share this as another option. It would require the data to already be sorted by time
https://scikit-learn.org/stable/modules/generated/sklearn.model_selection.TimeSeriesSplit.html

@kspieks kspieks added the enhancement New feature or request label Dec 7, 2023
@JacksonBurns
Copy link
Owner

@kspieks this would be a cool one to have - this would ignore the requested split sizes, right?

@kspieks
Copy link
Collaborator Author

kspieks commented Jan 8, 2024

Yes this specific splitter would ignore the split size arguments. Not sure if that would be confusing to the user but it would be consistent with the function call for TimeSeriesSplit()

@JacksonBurns
Copy link
Owner

Following up on this after some time - now that astartes is used in a few different places, we see that it is easier to require the end users to make repeat calls rather than for us to implement it here. Going to go ahead and close this, but leave it as not completed since this may change in the future.

@JacksonBurns JacksonBurns closed this as not planned Won't fix, can't repro, duplicate, stale Aug 14, 2024
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants