Add typescript support #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyj1991
reviewed
May 28, 2019
| @@ -159,27 +162,28 @@ exports.read = function (response, encoding) { | |||
| } | |||
|
|
|||
| return new Promise((resolve, reject) => { | |||
| const makeReadTimeoutError = (err) => { | |||
| const makeReadTimeoutError = () => { | |||
There was a problem hiding this comment.
这样改的话，就不知道 err 对象是具体哪个阶段生成的了
There was a problem hiding this comment.
堆栈永远在 makeReadTimeoutError 这个函数里，之前分散到各个调用 makeReadTimeoutError 的地方是为了看到 error 是由哪里产生的吧
hyj1991
reviewed
May 28, 2019
lib/index.d.ts
Outdated
| 'data'?: string|Buffer|undefined; | ||
| } | ||
|
|
||
| export function request<T>(url: string, options: Options): Promise<IncomingMessage>; |
|
更新了 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.