-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/movie generation #27
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Restructured the codebase for movie generation - Changed the flythrough movie type to be more dynamic and allow for custom path creation - Added documentation to the entire movie processing codebase
… the flythrough widget. Added the option to save and load movie generation options.
…to feat/movie_generation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests refreshes the movie generation feature of VesselVio.
First, the widget has been redesigned to a vertical orientation, allowing users to more easily access the rendering window during movie generation.
Next, the Flythough movie type has been updated, allowing users to create their own movie paths, rather than only being able to generate a 'straight shot' flythrough scene. The flythrough path generation allows users to create linear paths or smoothed (quadratic spline) paths.
Next, importantly, as I move to improve the documentation and professionalism of the codebase, the
movie_widgets.py
andmovie_processing.py
files have a clear model-view function and object separation, and the documentation of both files is greatly improved. As I continue updating the rest of the app, this updated form of documentation and separation will be parsed throughout the codebase.