Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce initial project code standards #6

Merged
merged 1 commit into from
Mar 30, 2024
Merged

Conversation

JacobCallahan
Copy link
Owner

Added and applied code standards for both Rust and Python. pre-commit hooks are now available and will be enforced in pull requests.

@JacobCallahan JacobCallahan force-pushed the standards branch 7 times, most recently from 6cb1534 to c990323 Compare March 30, 2024 02:32
@JacobCallahan
Copy link
Owner Author

I was hoping to have the test running in windows, but that doesn't seem to be possible at the moment due to this error on both architectures. We'll just have to settle for installing for now.

> raise BuildError(chunk['error'], result_stream)
E docker.errors.BuildError: no matching manifest for windows/amd64 10.0.20348 in the manifest list entries

@JacobCallahan JacobCallahan force-pushed the standards branch 4 times, most recently from 937c7e4 to fb8a147 Compare March 30, 2024 15:17
Added and applied code standards for both Rust and Python.
pre-commit hooks are now available and will be enforced in pull
requests.
@JacobCallahan
Copy link
Owner Author

Also have to limit mac to installation only, again due to issues with docker.

@JacobCallahan JacobCallahan merged commit 3c77122 into master Mar 30, 2024
11 checks passed
@JacobCallahan JacobCallahan deleted the standards branch March 30, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant