Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Link to message #83

Merged
merged 1 commit into from
May 14, 2024

Conversation

Alc-Alc
Copy link
Collaborator

@Alc-Alc Alc-Alc commented May 13, 2024

Pull Request Checklist

  • New code has 100% test coverage
  • (If applicable) The prose documentation has been updated to reflect the changes introduced by this PR
  • (If applicable) The reference documentation has been updated to reflect the changes introduced by this PR
  • Pre-Commit Checks were ran and passed
  • Tests were ran and passed

Description

  • The message instance is already being passed to the modal, this PR uses that instance to assign a new instance level attribute jump_url to achieve the end result.

IOW, this PR does not use the approach suggested in the issue, because this is better, obviously

Close Issue(s)

@Alc-Alc Alc-Alc requested a review from JacobCoffee as a code owner May 13, 2024 14:48
Copy link

railway-app bot commented May 13, 2024

This PR was not deployed automatically as @Alc-Alc does not have access to the Railway project.

In order to get automatic PR deploys, please add @Alc-Alc to the project inside the project settings page.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.

@Alc-Alc Alc-Alc force-pushed the 82-enhancementissue-creation-link-to-message branch from c3b7223 to 8ce3fa6 Compare May 13, 2024 15:44
@Alc-Alc Alc-Alc force-pushed the 82-enhancementissue-creation-link-to-message branch from 8ce3fa6 to 49e6d79 Compare May 13, 2024 16:02
@JacobCoffee JacobCoffee merged commit 268c8e8 into main May 14, 2024
3 of 4 checks passed
@JacobCoffee JacobCoffee deleted the 82-enhancementissue-creation-link-to-message branch May 14, 2024 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement(Issue Creation): Link to message
2 participants