Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#120] Update CI to work with conan 2.0 #121

Merged
merged 6 commits into from
Apr 24, 2024

Conversation

JacobDomagala
Copy link
Owner

Fixes #120

@JacobDomagala JacobDomagala linked an issue Apr 24, 2024 that may be closed by this pull request
@JacobDomagala JacobDomagala self-assigned this Apr 24, 2024
Copy link

✅ WINDOWS COMPILE RESULT - SUCCESS! ✅

@JacobDomagala JacobDomagala force-pushed the 120-update-ci-to-use-conan-2 branch 4 times, most recently from 4e6b37e to cf7eb4b Compare April 24, 2024 14:56
Copy link

✅ UBUNTU COMPILE RESULT - SUCCESS! ✅

@JacobDomagala JacobDomagala force-pushed the 120-update-ci-to-use-conan-2 branch 2 times, most recently from 76ca9e8 to 3cc1894 Compare April 24, 2024 15:16
Copy link

github-actions bot commented Apr 24, 2024

⚡ Static analysis result ⚡

🔴 cppcheck found 8 issues! Click here to see details.

CopyDataWithStaging(void* data, size_t dataSize);
static void
CopyDataToImageWithStaging(VkImage image, void* data, size_t dataSize,
const std::vector< VkBufferImageCopy >& copyRegions);

!Line: 40 - style: inconclusive: Technically the member function 'shady::render::Buffer::CopyDataWithStaging' can be const. [functionConst]

!Line: 36 - note: Technically the member function 'shady::render::Buffer::CopyDataWithStaging' can be const.
!Line: 40 - note: Technically the member function 'shady::render::Buffer::CopyDataWithStaging' can be const.

Buffer::CopyDataWithStaging(void* data, size_t dataSize)
{
VkBuffer stagingBuffer{};
VkDeviceMemory stagingBufferMemory{};
Buffer::CreateBuffer(dataSize, VK_BUFFER_USAGE_TRANSFER_SRC_BIT,
VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT | VK_MEMORY_PROPERTY_HOST_COHERENT_BIT,

!Line: 36 - style: Parameter 'data' can be declared as pointer to const [constParameterPointer]

Buffer::CopyDataToImageWithStaging(VkImage image, void* data, size_t dataSize,
const std::vector< VkBufferImageCopy >& copyRegions)
{
VkBuffer stagingBuffer{};
VkDeviceMemory stagingBufferMemory{};
Buffer::CreateBuffer(dataSize, VK_BUFFER_USAGE_TRANSFER_SRC_BIT,

!Line: 53 - style: Parameter 'data' can be declared as pointer to const [constParameterPointer]

TransitionImageLayout(VkImageLayout oldLayout, VkImageLayout newLayout, uint32_t mipLevels);
void
CopyBufferToImage(uint8_t* data);
private:

!Line: 61 - style: inconclusive: Technically the member function 'shady::render::Texture::TransitionImageLayout' can be const. [functionConst]

!Line: 376 - note: Technically the member function 'shady::render::Texture::TransitionImageLayout' can be const.
!Line: 61 - note: Technically the member function 'shady::render::Texture::TransitionImageLayout' can be const.

CopyBufferToImage(uint8_t* data);
private:
TextureType m_type = {};
VkImage m_textureImage = {};
VkDeviceMemory m_textureImageMemory = {};

!Line: 64 - style: inconclusive: Technically the member function 'shady::render::Texture::CopyBufferToImage' can be const. [functionConst]

!Line: 320 - note: Technically the member function 'shady::render::Texture::CopyBufferToImage' can be const.
!Line: 64 - note: Technically the member function 'shady::render::Texture::CopyBufferToImage' can be const.

Shady/src/scene/mesh.hpp

Lines 21 to 26 in 77e1d99

Submit();
void
Draw(const std::string& modelName, const glm::mat4& modelMat, const glm::vec4& tintColor);
void

!Line: 21 - style: inconclusive: Technically the member function 'shady::scene::Mesh::Submit' can be const. [functionConst]

!Line: 24 - note: Technically the member function 'shady::scene::Mesh::Submit' can be const.
!Line: 21 - note: Technically the member function 'shady::scene::Mesh::Submit' can be const.

Shady/src/scene/mesh.hpp

Lines 24 to 29 in 77e1d99

Draw(const std::string& modelName, const glm::mat4& modelMat, const glm::vec4& tintColor);
void
Scale(const glm::vec3& scale);
void

!Line: 24 - style: inconclusive: Technically the member function 'shady::scene::Mesh::Draw' can be const. [functionConst]

!Line: 30 - note: Technically the member function 'shady::scene::Mesh::Draw' can be const.
!Line: 24 - note: Technically the member function 'shady::scene::Mesh::Draw' can be const.

UpdateBuffers(const scene::Camera* camera);
private:
void
CreatePipeline();

!Line: 45 - style: inconclusive: Technically the member function 'shady::scene::Skybox::UpdateBuffers' can be const. [functionConst]

!Line: 122 - note: Technically the member function 'shady::scene::Skybox::UpdateBuffers' can be const.
!Line: 45 - note: Technically the member function 'shady::scene::Skybox::UpdateBuffers' can be const.

🔴 clang-tidy found 168 issues! Click here to see details.

#include <fmt/format.h>
namespace shady::time {
TimeStep::TimeStep(milliseconds time) : time_(time)
{

!Line: 3 - error: included header format.h is not used directly [misc-include-cleaner,-warnings-as-errors]

Shady/src/time/timer.cpp

Lines 11 to 16 in 77e1d99

std::string
TimeStep::ToString() const
{
return fmt::format("{}ms", time_.count());
}

!Line: 11 - error: no header providing "std::string" is directly included [misc-include-cleaner,-warnings-as-errors]

Shady/src/time/timer.cpp

Lines 14 to 19 in 77e1d99

return fmt::format("{}ms", time_.count());
}
seconds
TimeStep::GetSeconds() const
{

!Line: 14 - error: no header providing "fmt::format" is directly included [misc-include-cleaner,-warnings-as-errors]

Shady/src/time/timer.cpp

Lines 20 to 25 in 77e1d99

return std::chrono::duration_cast< seconds >(time_);
}
milliseconds
TimeStep::GetMilliseconds() const
{

!Line: 20 - error: no header providing "std::chrono::duration_cast" is directly included [misc-include-cleaner,-warnings-as-errors]

Shady/src/time/timer.cpp

Lines 30 to 35 in 77e1d99

Timer::Timer() : lastTimeStamp_(std::chrono::steady_clock::now())
{
}
TimeStep
Timer::ToggleTimer()

!Line: 30 - error: no header providing "std::chrono::steady_clock" is directly included [misc-include-cleaner,-warnings-as-errors]

#include <fmt/format.h>
namespace shady::render {
void
Buffer::Map(VkDeviceSize size)

!Line: 6 - error: included header format.h is not used directly [misc-include-cleaner,-warnings-as-errors]

Buffer::Map(VkDeviceSize size)
{
vkMapMemory(Data::vk_device, bufferMemory_, 0, size, 0, &mappedMemory_);
mapped_ = true;
}

!Line: 11 - error: no header providing "VkDeviceSize" is directly included [misc-include-cleaner,-warnings-as-errors]

vkMapMemory(Data::vk_device, bufferMemory_, 0, size, 0, &mappedMemory_);
mapped_ = true;
}
void
Buffer::Unmap()

!Line: 13 - error: no header providing "vkMapMemory" is directly included [misc-include-cleaner,-warnings-as-errors]

vkUnmapMemory(Data::vk_device, bufferMemory_);
mapped_ = false;
mappedMemory_ = nullptr;
}
}

!Line: 22 - error: no header providing "vkUnmapMemory" is directly included [misc-include-cleaner,-warnings-as-errors]

memcpy(mappedMemory_, data, bufferSize_);
}
void
Buffer::CopyDataWithStaging(void* data, size_t dataSize)
{

!Line: 32 - error: no header providing "memcpy" is directly included [misc-include-cleaner,-warnings-as-errors]

Buffer::CopyDataWithStaging(void* data, size_t dataSize)
{
VkBuffer stagingBuffer{};
VkDeviceMemory stagingBufferMemory{};
Buffer::CreateBuffer(dataSize, VK_BUFFER_USAGE_TRANSFER_SRC_BIT,
VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT | VK_MEMORY_PROPERTY_HOST_COHERENT_BIT,

!Line: 36 - error: no header providing "size_t" is directly included [misc-include-cleaner,-warnings-as-errors]

VkBuffer stagingBuffer{};
VkDeviceMemory stagingBufferMemory{};
Buffer::CreateBuffer(dataSize, VK_BUFFER_USAGE_TRANSFER_SRC_BIT,
VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT | VK_MEMORY_PROPERTY_HOST_COHERENT_BIT,
stagingBuffer, stagingBufferMemory);

!Line: 38 - error: no header providing "VkBuffer" is directly included [misc-include-cleaner,-warnings-as-errors]

VkDeviceMemory stagingBufferMemory{};
Buffer::CreateBuffer(dataSize, VK_BUFFER_USAGE_TRANSFER_SRC_BIT,
VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT | VK_MEMORY_PROPERTY_HOST_COHERENT_BIT,
stagingBuffer, stagingBufferMemory);
void* mapped_data{};

!Line: 39 - error: no header providing "VkDeviceMemory" is directly included [misc-include-cleaner,-warnings-as-errors]

Buffer::CreateBuffer(dataSize, VK_BUFFER_USAGE_TRANSFER_SRC_BIT,
VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT | VK_MEMORY_PROPERTY_HOST_COHERENT_BIT,
stagingBuffer, stagingBufferMemory);
void* mapped_data{};
vkMapMemory(Data::vk_device, stagingBufferMemory, 0, dataSize, 0, &mapped_data);

!Line: 40 - error: no header providing "VK_BUFFER_USAGE_TRANSFER_SRC_BIT" is directly included [misc-include-cleaner,-warnings-as-errors]

VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT | VK_MEMORY_PROPERTY_HOST_COHERENT_BIT,
stagingBuffer, stagingBufferMemory);
void* mapped_data{};
vkMapMemory(Data::vk_device, stagingBufferMemory, 0, dataSize, 0, &mapped_data);
memcpy(mapped_data, data, dataSize);

!Line: 41 - error: no header providing "VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT" is directly included [misc-include-cleaner,-warnings-as-errors]

VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT | VK_MEMORY_PROPERTY_HOST_COHERENT_BIT,
stagingBuffer, stagingBufferMemory);
void* mapped_data{};
vkMapMemory(Data::vk_device, stagingBufferMemory, 0, dataSize, 0, &mapped_data);
memcpy(mapped_data, data, dataSize);

!Line: 41 - error: no header providing "VK_MEMORY_PROPERTY_HOST_COHERENT_BIT" is directly included [misc-include-cleaner,-warnings-as-errors]

Buffer::CopyDataToImageWithStaging(VkImage image, void* data, size_t dataSize,
const std::vector< VkBufferImageCopy >& copyRegions)
{
VkBuffer stagingBuffer{};
VkDeviceMemory stagingBufferMemory{};
Buffer::CreateBuffer(dataSize, VK_BUFFER_USAGE_TRANSFER_SRC_BIT,

!Line: 53 - error: no header providing "VkImage" is directly included [misc-include-cleaner,-warnings-as-errors]

const std::vector< VkBufferImageCopy >& copyRegions)
{
VkBuffer stagingBuffer{};
VkDeviceMemory stagingBufferMemory{};
Buffer::CreateBuffer(dataSize, VK_BUFFER_USAGE_TRANSFER_SRC_BIT,
VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT | VK_MEMORY_PROPERTY_HOST_COHERENT_BIT,

!Line: 54 - error: no header providing "std::vector" is directly included [misc-include-cleaner,-warnings-as-errors]

const std::vector< VkBufferImageCopy >& copyRegions)
{
VkBuffer stagingBuffer{};
VkDeviceMemory stagingBufferMemory{};
Buffer::CreateBuffer(dataSize, VK_BUFFER_USAGE_TRANSFER_SRC_BIT,
VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT | VK_MEMORY_PROPERTY_HOST_COHERENT_BIT,

!Line: 54 - error: no header providing "VkBufferImageCopy" is directly included [misc-include-cleaner,-warnings-as-errors]

VkCommandBuffer commandBuffer = Command::BeginSingleTimeCommands();
vkCmdCopyBufferToImage(commandBuffer, stagingBuffer, image, VK_IMAGE_LAYOUT_TRANSFER_DST_OPTIMAL,
static_cast< uint32_t >(copyRegions.size()), copyRegions.data());
Command::EndSingleTimeCommands(commandBuffer);

!Line: 67 - error: no header providing "VkCommandBuffer" is directly included [misc-include-cleaner,-warnings-as-errors]

vkCmdCopyBufferToImage(commandBuffer, stagingBuffer, image, VK_IMAGE_LAYOUT_TRANSFER_DST_OPTIMAL,
static_cast< uint32_t >(copyRegions.size()), copyRegions.data());
Command::EndSingleTimeCommands(commandBuffer);
vkDestroyBuffer(Data::vk_device, stagingBuffer, nullptr);

!Line: 69 - error: no header providing "vkCmdCopyBufferToImage" is directly included [misc-include-cleaner,-warnings-as-errors]

vkCmdCopyBufferToImage(commandBuffer, stagingBuffer, image, VK_IMAGE_LAYOUT_TRANSFER_DST_OPTIMAL,
static_cast< uint32_t >(copyRegions.size()), copyRegions.data());
Command::EndSingleTimeCommands(commandBuffer);
vkDestroyBuffer(Data::vk_device, stagingBuffer, nullptr);

!Line: 69 - error: no header providing "VK_IMAGE_LAYOUT_TRANSFER_DST_OPTIMAL" is directly included [misc-include-cleaner,-warnings-as-errors]

static_cast< uint32_t >(copyRegions.size()), copyRegions.data());
Command::EndSingleTimeCommands(commandBuffer);
vkDestroyBuffer(Data::vk_device, stagingBuffer, nullptr);
vkFreeMemory(Data::vk_device, stagingBufferMemory, nullptr);

!Line: 70 - error: no header providing "uint32_t" is directly included [misc-include-cleaner,-warnings-as-errors]

vkDestroyBuffer(Data::vk_device, stagingBuffer, nullptr);
vkFreeMemory(Data::vk_device, stagingBufferMemory, nullptr);
}
void
Buffer::SetupDescriptor(VkDeviceSize /*size*/, VkDeviceSize offset)

!Line: 74 - error: no header providing "vkDestroyBuffer" is directly included [misc-include-cleaner,-warnings-as-errors]

vkFreeMemory(Data::vk_device, stagingBufferMemory, nullptr);
}
void
Buffer::SetupDescriptor(VkDeviceSize /*size*/, VkDeviceSize offset)
{

!Line: 75 - error: no header providing "vkFreeMemory" is directly included [misc-include-cleaner,-warnings-as-errors]

AllocateMemory(VkMemoryRequirements memReq, VkDeviceMemory& bufferMemory,
VkMemoryPropertyFlags properties)
{
VkMemoryAllocateInfo allocInfo{};
allocInfo.sType = VK_STRUCTURE_TYPE_MEMORY_ALLOCATE_INFO;
allocInfo.allocationSize = memReq.size;

!Line: 87 - error: no header providing "VkMemoryRequirements" is directly included [misc-include-cleaner,-warnings-as-errors]

VkMemoryPropertyFlags properties)
{
VkMemoryAllocateInfo allocInfo{};
allocInfo.sType = VK_STRUCTURE_TYPE_MEMORY_ALLOCATE_INFO;
allocInfo.allocationSize = memReq.size;
allocInfo.memoryTypeIndex = FindMemoryType(memReq.memoryTypeBits, properties);

!Line: 88 - error: no header providing "VkMemoryPropertyFlags" is directly included [misc-include-cleaner,-warnings-as-errors]

VkMemoryAllocateInfo allocInfo{};
allocInfo.sType = VK_STRUCTURE_TYPE_MEMORY_ALLOCATE_INFO;
allocInfo.allocationSize = memReq.size;
allocInfo.memoryTypeIndex = FindMemoryType(memReq.memoryTypeBits, properties);
VK_CHECK(vkAllocateMemory(Data::vk_device, &allocInfo, nullptr, &bufferMemory),

!Line: 90 - error: no header providing "VkMemoryAllocateInfo" is directly included [misc-include-cleaner,-warnings-as-errors]

allocInfo.sType = VK_STRUCTURE_TYPE_MEMORY_ALLOCATE_INFO;
allocInfo.allocationSize = memReq.size;
allocInfo.memoryTypeIndex = FindMemoryType(memReq.memoryTypeBits, properties);
VK_CHECK(vkAllocateMemory(Data::vk_device, &allocInfo, nullptr, &bufferMemory),
"failed to allocate buffer memory!");

!Line: 91 - error: no header providing "VK_STRUCTURE_TYPE_MEMORY_ALLOCATE_INFO" is directly included [misc-include-cleaner,-warnings-as-errors]

VK_CHECK(vkAllocateMemory(Data::vk_device, &allocInfo, nullptr, &bufferMemory),
"failed to allocate buffer memory!");
}
void
Buffer::AllocateImageMemory(VkImage image, VkDeviceMemory& bufferMemory,

!Line: 95 - error: no header providing "vkAllocateMemory" is directly included [misc-include-cleaner,-warnings-as-errors]

Shady/src/render/buffer.cpp

Lines 104 to 109 in 77e1d99

vkGetImageMemoryRequirements(Data::vk_device, image, &memRequirements);
AllocateMemory(memRequirements, bufferMemory, properties);
}
void

!Line: 104 - error: no header providing "vkGetImageMemoryRequirements" is directly included [misc-include-cleaner,-warnings-as-errors]

Shady/src/render/buffer.cpp

Lines 114 to 119 in 77e1d99

vkGetBufferMemoryRequirements(Data::vk_device, buffer, &memRequirements);
AllocateMemory(memRequirements, bufferMemory, properties);
}
Buffer

!Line: 114 - error: no header providing "vkGetBufferMemoryRequirements" is directly included [misc-include-cleaner,-warnings-as-errors]

Shady/src/render/buffer.cpp

Lines 120 to 125 in 77e1d99

Buffer::CreateBuffer(VkDeviceSize size, VkBufferUsageFlags usage, VkMemoryPropertyFlags properties)
{
Buffer newBuffer;
newBuffer.bufferSize_ = size;
CreateBuffer(size, usage, properties, newBuffer.buffer_, newBuffer.bufferMemory_);
newBuffer.SetupDescriptor();

!Line: 120 - error: no header providing "VkBufferUsageFlags" is directly included [misc-include-cleaner,-warnings-as-errors]

Shady/src/render/buffer.cpp

Lines 134 to 139 in 77e1d99

VkBufferCreateInfo bufferInfo{};
bufferInfo.sType = VK_STRUCTURE_TYPE_BUFFER_CREATE_INFO;
bufferInfo.size = size;
bufferInfo.usage = usage;
bufferInfo.sharingMode = VK_SHARING_MODE_EXCLUSIVE;

!Line: 134 - error: no header providing "VkBufferCreateInfo" is directly included [misc-include-cleaner,-warnings-as-errors]

Shady/src/render/buffer.cpp

Lines 135 to 140 in 77e1d99

bufferInfo.sType = VK_STRUCTURE_TYPE_BUFFER_CREATE_INFO;
bufferInfo.size = size;
bufferInfo.usage = usage;
bufferInfo.sharingMode = VK_SHARING_MODE_EXCLUSIVE;
VK_CHECK(vkCreateBuffer(Data::vk_device, &bufferInfo, nullptr, &buffer),

!Line: 135 - error: no header providing "VK_STRUCTURE_TYPE_BUFFER_CREATE_INFO" is directly included [misc-include-cleaner,-warnings-as-errors]

Shady/src/render/buffer.cpp

Lines 138 to 143 in 77e1d99

bufferInfo.sharingMode = VK_SHARING_MODE_EXCLUSIVE;
VK_CHECK(vkCreateBuffer(Data::vk_device, &bufferInfo, nullptr, &buffer),
"failed to create buffer!");
AllocateBufferMemory(buffer, bufferMemory, properties);

!Line: 138 - error: no header providing "VK_SHARING_MODE_EXCLUSIVE" is directly included [misc-include-cleaner,-warnings-as-errors]

Shady/src/render/buffer.cpp

Lines 140 to 145 in 77e1d99

VK_CHECK(vkCreateBuffer(Data::vk_device, &bufferInfo, nullptr, &buffer),
"failed to create buffer!");
AllocateBufferMemory(buffer, bufferMemory, properties);
vkBindBufferMemory(Data::vk_device, buffer, bufferMemory, 0);

!Line: 140 - error: no header providing "vkCreateBuffer" is directly included [misc-include-cleaner,-warnings-as-errors]

Shady/src/render/buffer.cpp

Lines 145 to 150 in 77e1d99

vkBindBufferMemory(Data::vk_device, buffer, bufferMemory, 0);
}
void
Buffer::CopyBuffer(VkBuffer srcBuffer, VkBuffer dstBuffer, VkDeviceSize size)
{

!Line: 145 - error: no header providing "vkBindBufferMemory" is directly included [misc-include-cleaner,-warnings-as-errors]

Shady/src/render/buffer.cpp

Lines 153 to 158 in 77e1d99

VkBufferCopy copyRegion{};
copyRegion.size = size;
vkCmdCopyBuffer(commandBuffer, srcBuffer, dstBuffer, 1, &copyRegion);
Command::EndSingleTimeCommands(commandBuffer);
}

!Line: 153 - error: no header providing "VkBufferCopy" is directly included [misc-include-cleaner,-warnings-as-errors]

Shady/src/render/buffer.cpp

Lines 155 to 160 in 77e1d99

vkCmdCopyBuffer(commandBuffer, srcBuffer, dstBuffer, 1, &copyRegion);
Command::EndSingleTimeCommands(commandBuffer);
}
void

!Line: 155 - error: no header providing "vkCmdCopyBuffer" is directly included [misc-include-cleaner,-warnings-as-errors]

Shady/src/render/buffer.cpp

Lines 163 to 168 in 77e1d99

VkMappedMemoryRange mappedRange = {};
mappedRange.sType = VK_STRUCTURE_TYPE_MAPPED_MEMORY_RANGE;
mappedRange.memory = bufferMemory_;
mappedRange.offset = offset;
mappedRange.size = size;

!Line: 163 - error: no header providing "VkMappedMemoryRange" is directly included [misc-include-cleaner,-warnings-as-errors]

Shady/src/render/buffer.cpp

Lines 164 to 169 in 77e1d99

mappedRange.sType = VK_STRUCTURE_TYPE_MAPPED_MEMORY_RANGE;
mappedRange.memory = bufferMemory_;
mappedRange.offset = offset;
mappedRange.size = size;
VK_CHECK(vkFlushMappedMemoryRanges(Data::vk_device, 1, &mappedRange), "Buffer::Flush error!");

!Line: 164 - error: no header providing "VK_STRUCTURE_TYPE_MAPPED_MEMORY_RANGE" is directly included [misc-include-cleaner,-warnings-as-errors]

Shady/src/render/buffer.cpp

Lines 169 to 174 in 77e1d99

VK_CHECK(vkFlushMappedMemoryRanges(Data::vk_device, 1, &mappedRange), "Buffer::Flush error!");
}
void
Buffer::Destroy()
{

!Line: 169 - error: no header providing "vkFlushMappedMemoryRanges" is directly included [misc-include-cleaner,-warnings-as-errors]

#include "utils/file_manager.hpp"
#include <assimp/Importer.hpp>
#include <assimp/scene.h>
namespace shady::scene {

!Line: 5 - error: included header file_manager.hpp is not used directly [misc-include-cleaner,-warnings-as-errors]

static render::TextureType
GetShadyTexFromAssimpTex(aiTextureType assimpTex)
{
switch (assimpTex)
{
case aiTextureType_SPECULAR:

!Line: 12 - error: no header providing "shady::render::TextureType" is directly included [misc-include-cleaner,-warnings-as-errors]

GetShadyTexFromAssimpTex(aiTextureType assimpTex)
{
switch (assimpTex)
{
case aiTextureType_SPECULAR:
case aiTextureType_UNKNOWN:

!Line: 13 - error: function 'GetShadyTexFromAssimpTex' declared 'static', move to anonymous namespace instead [misc-use-anonymous-namespace,-warnings-as-errors]

GetShadyTexFromAssimpTex(aiTextureType assimpTex)
{
switch (assimpTex)
{
case aiTextureType_SPECULAR:
case aiTextureType_UNKNOWN:

!Line: 13 - error: no header providing "aiTextureType" is directly included [misc-include-cleaner,-warnings-as-errors]

case aiTextureType_SPECULAR:
case aiTextureType_UNKNOWN:
return render::TextureType::SPECULAR_MAP;
case aiTextureType_NORMALS:
return render::TextureType::NORMAL_MAP;
case aiTextureType_DIFFUSE:

!Line: 17 - error: no header providing "aiTextureType_SPECULAR" is directly included [misc-include-cleaner,-warnings-as-errors]

case aiTextureType_UNKNOWN:
return render::TextureType::SPECULAR_MAP;
case aiTextureType_NORMALS:
return render::TextureType::NORMAL_MAP;
case aiTextureType_DIFFUSE:
default: {

!Line: 18 - error: no header providing "aiTextureType_UNKNOWN" is directly included [misc-include-cleaner,-warnings-as-errors]

case aiTextureType_NORMALS:
return render::TextureType::NORMAL_MAP;
case aiTextureType_DIFFUSE:
default: {
return render::TextureType::DIFFUSE_MAP;
}

!Line: 20 - error: no header providing "aiTextureType_NORMALS" is directly included [misc-include-cleaner,-warnings-as-errors]

case aiTextureType_DIFFUSE:
default: {
return render::TextureType::DIFFUSE_MAP;
}
}
}

!Line: 22 - error: no header providing "aiTextureType_DIFFUSE" is directly included [misc-include-cleaner,-warnings-as-errors]

LoadMaterialTextures(aiMaterial* mat, aiTextureType type, render::TextureMaps& textures)
{
for (uint32_t i = 0; i < mat->GetTextureCount(type); i++)
{
aiString str;
mat->GetTexture(type, i, &str);

!Line: 30 - error: function 'LoadMaterialTextures' declared 'static', move to anonymous namespace instead [misc-use-anonymous-namespace,-warnings-as-errors]

LoadMaterialTextures(aiMaterial* mat, aiTextureType type, render::TextureMaps& textures)
{
for (uint32_t i = 0; i < mat->GetTextureCount(type); i++)
{
aiString str;
mat->GetTexture(type, i, &str);

!Line: 30 - error: no header providing "aiMaterial" is directly included [misc-include-cleaner,-warnings-as-errors]

LoadMaterialTextures(aiMaterial* mat, aiTextureType type, render::TextureMaps& textures)
{
for (uint32_t i = 0; i < mat->GetTextureCount(type); i++)
{
aiString str;
mat->GetTexture(type, i, &str);

!Line: 30 - error: no header providing "shady::render::TextureMaps" is directly included [misc-include-cleaner,-warnings-as-errors]

for (uint32_t i = 0; i < mat->GetTextureCount(type); i++)
{
aiString str;
mat->GetTexture(type, i, &str);
const auto texType = GetShadyTexFromAssimpTex(type);

!Line: 32 - error: no header providing "uint32_t" is directly included [misc-include-cleaner,-warnings-as-errors]

aiString str;
mat->GetTexture(type, i, &str);
const auto texType = GetShadyTexFromAssimpTex(type);
render::TextureLibrary::CreateTexture(texType, str.C_Str());
textures[static_cast< uint32_t >(texType)] = str.C_Str();

!Line: 34 - error: no header providing "aiString" is directly included [misc-include-cleaner,-warnings-as-errors]

path, aiProcess_FlipWindingOrder | aiProcess_GenSmoothNormals | aiProcess_Triangulate
| /*aiProcess_CalcTangentSpace |*/ aiProcess_JoinIdenticalVertices
| aiProcess_ValidateDataStructure | static_cast< uint32_t >(additionalAssimpFlags));
// Check for errors
if (!scene || scene->mFlags == AI_SCENE_FLAGS_INCOMPLETE || !scene->mRootNode)

!Line: 48 - error: no header providing "aiProcess_FlipWindingOrder" is directly included [misc-include-cleaner,-warnings-as-errors]

path, aiProcess_FlipWindingOrder | aiProcess_GenSmoothNormals | aiProcess_Triangulate
| /*aiProcess_CalcTangentSpace |*/ aiProcess_JoinIdenticalVertices
| aiProcess_ValidateDataStructure | static_cast< uint32_t >(additionalAssimpFlags));
// Check for errors
if (!scene || scene->mFlags == AI_SCENE_FLAGS_INCOMPLETE || !scene->mRootNode)

!Line: 48 - error: no header providing "aiProcess_GenSmoothNormals" is directly included [misc-include-cleaner,-warnings-as-errors]

path, aiProcess_FlipWindingOrder | aiProcess_GenSmoothNormals | aiProcess_Triangulate
| /*aiProcess_CalcTangentSpace |*/ aiProcess_JoinIdenticalVertices
| aiProcess_ValidateDataStructure | static_cast< uint32_t >(additionalAssimpFlags));
// Check for errors
if (!scene || scene->mFlags == AI_SCENE_FLAGS_INCOMPLETE || !scene->mRootNode)

!Line: 48 - error: no header providing "aiProcess_Triangulate" is directly included [misc-include-cleaner,-warnings-as-errors]

| /*aiProcess_CalcTangentSpace |*/ aiProcess_JoinIdenticalVertices
| aiProcess_ValidateDataStructure | static_cast< uint32_t >(additionalAssimpFlags));
// Check for errors
if (!scene || scene->mFlags == AI_SCENE_FLAGS_INCOMPLETE || !scene->mRootNode)
{

!Line: 49 - error: no header providing "aiProcess_JoinIdenticalVertices" is directly included [misc-include-cleaner,-warnings-as-errors]

| aiProcess_ValidateDataStructure | static_cast< uint32_t >(additionalAssimpFlags));
// Check for errors
if (!scene || scene->mFlags == AI_SCENE_FLAGS_INCOMPLETE || !scene->mRootNode)
{
trace::Logger::Fatal("Error loading model: {} \n Error message: {}", path,

!Line: 50 - error: no header providing "aiProcess_ValidateDataStructure" is directly included [misc-include-cleaner,-warnings-as-errors]

Model::ScaleModel(const glm::vec3& scale)
{
for (auto& mesh : meshes_)
{
mesh.Scale(scale);
}

!Line: 71 - error: no header providing "glm::vec3" is directly included [misc-include-cleaner,-warnings-as-errors]

Shady/src/scene/model.cpp

Lines 111 to 116 in 77e1d99

mesh.Draw(name_, glm::mat4(1.0f), {1.0f, 1.0f, 1.0f, 1.0f});
}
}
std::vector< Mesh >&
Model::GetMeshes()

!Line: 111 - error: no header providing "glm::mat4" is directly included [misc-include-cleaner,-warnings-as-errors]

Shady/src/scene/model.cpp

Lines 111 to 116 in 77e1d99

mesh.Draw(name_, glm::mat4(1.0f), {1.0f, 1.0f, 1.0f, 1.0f});
}
}
std::vector< Mesh >&
Model::GetMeshes()

!Line: 111 - error: floating point literal has suffix 'f', which is not uppercase [hicpp-uppercase-literal-suffix,-warnings-as-errors]

Shady/src/scene/model.cpp

Lines 115 to 120 in 77e1d99

std::vector< Mesh >&
Model::GetMeshes()
{
return meshes_;
}

!Line: 115 - error: no header providing "std::vector" is directly included [misc-include-cleaner,-warnings-as-errors]

Shady/src/scene/model.cpp

Lines 122 to 127 in 77e1d99

Model::ProcessNode(aiNode* node, const aiScene* scene)
{
for (uint32_t i = 0; i < node->mNumMeshes; i++)
{
// The node object only contains indices to index the actual objects in the scene.
// The scene contains all the data, node is just to keep stuff organized (like relations

!Line: 122 - error: function 'ProcessNode' is within a recursive call chain [misc-no-recursion,-warnings-as-errors]

!Line: 122 - note: example recursive call chain, starting from function 'ProcessNode'
!Line: 139 - note: Frame #1: function 'ProcessNode' calls function 'ProcessNode' here:
!Line: 139 - note: ... which was the starting point of the recursive call chain; there may be other cycles

Shady/src/scene/model.cpp

Lines 129 to 134 in 77e1d99

auto* mesh = scene->mMeshes[node->mMeshes[i]];
meshes_.push_back(ProcessMesh(mesh, scene));
}
trace::Logger::Debug("Processed node: {}", node->mName.C_Str());

!Line: 129 - error: do not use pointer arithmetic [cppcoreguidelines-pro-bounds-pointer-arithmetic,-warnings-as-errors]

Shady/src/scene/model.cpp

Lines 139 to 144 in 77e1d99

ProcessNode(node->mChildren[i], scene);
}
}
Mesh
Model::ProcessMesh(aiMesh* mesh, const aiScene* scene)

!Line: 139 - error: do not use pointer arithmetic [cppcoreguidelines-pro-bounds-pointer-arithmetic,-warnings-as-errors]

Shady/src/scene/model.cpp

Lines 155 to 160 in 77e1d99

vector.x = mesh->mVertices[i].x;
vector.y = mesh->mVertices[i].y;
vector.z = mesh->mVertices[i].z;
vertex.m_position = vector;
// Normals

!Line: 155 - error: do not use pointer arithmetic [cppcoreguidelines-pro-bounds-pointer-arithmetic,-warnings-as-errors]

Shady/src/scene/model.cpp

Lines 156 to 161 in 77e1d99

vector.y = mesh->mVertices[i].y;
vector.z = mesh->mVertices[i].z;
vertex.m_position = vector;
// Normals
if (mesh->HasNormals())

!Line: 156 - error: do not use pointer arithmetic [cppcoreguidelines-pro-bounds-pointer-arithmetic,-warnings-as-errors]

Shady/src/scene/model.cpp

Lines 157 to 162 in 77e1d99

vector.z = mesh->mVertices[i].z;
vertex.m_position = vector;
// Normals
if (mesh->HasNormals())
{

!Line: 157 - error: do not use pointer arithmetic [cppcoreguidelines-pro-bounds-pointer-arithmetic,-warnings-as-errors]

Shady/src/scene/model.cpp

Lines 163 to 168 in 77e1d99

vector.x = mesh->mNormals[i].x;
vector.y = mesh->mNormals[i].y;
vector.z = mesh->mNormals[i].z;
vertex.m_normal = vector;
}

!Line: 163 - error: do not use pointer arithmetic [cppcoreguidelines-pro-bounds-pointer-arithmetic,-warnings-as-errors]

Shady/src/scene/model.cpp

Lines 164 to 169 in 77e1d99

vector.y = mesh->mNormals[i].y;
vector.z = mesh->mNormals[i].z;
vertex.m_normal = vector;
}
// Texture Coordinates

!Line: 164 - error: do not use pointer arithmetic [cppcoreguidelines-pro-bounds-pointer-arithmetic,-warnings-as-errors]

Shady/src/scene/model.cpp

Lines 165 to 170 in 77e1d99

vector.z = mesh->mNormals[i].z;
vertex.m_normal = vector;
}
// Texture Coordinates
if (mesh->HasTextureCoords(0))

!Line: 165 - error: do not use pointer arithmetic [cppcoreguidelines-pro-bounds-pointer-arithmetic,-warnings-as-errors]

Shady/src/scene/model.cpp

Lines 172 to 177 in 77e1d99

glm::vec2 vec{};
// A vertex can contain up to 8 different texture coordinates. We thus make the assumption
// that we won't use models where a vertex can have multiple texture coordinates so we
// always take the first set (0).
vec.x = mesh->mTextureCoords[0][i].x;
vec.y = mesh->mTextureCoords[0][i].y;

!Line: 172 - error: no header providing "glm::vec2" is directly included [misc-include-cleaner,-warnings-as-errors]

Shady/src/scene/model.cpp

Lines 176 to 181 in 77e1d99

vec.x = mesh->mTextureCoords[0][i].x;
vec.y = mesh->mTextureCoords[0][i].y;
vertex.m_texCoords = vec;
}
else
{

!Line: 176 - error: do not use pointer arithmetic [cppcoreguidelines-pro-bounds-pointer-arithmetic,-warnings-as-errors]

Shady/src/scene/model.cpp

Lines 177 to 182 in 77e1d99

vec.y = mesh->mTextureCoords[0][i].y;
vertex.m_texCoords = vec;
}
else
{
vertex.m_texCoords = glm::vec2(0.0f, 0.0f);

!Line: 177 - error: do not use pointer arithmetic [cppcoreguidelines-pro-bounds-pointer-arithmetic,-warnings-as-errors]

Shady/src/scene/model.cpp

Lines 182 to 187 in 77e1d99

vertex.m_texCoords = glm::vec2(0.0f, 0.0f);
}
if (mesh->HasTangentsAndBitangents())
{
// Tangents

!Line: 182 - error: floating point literal has suffix 'f', which is not uppercase [hicpp-uppercase-literal-suffix,-warnings-as-errors]

Shady/src/scene/model.cpp

Lines 188 to 193 in 77e1d99

vector.x = mesh->mTangents[i].x;
vector.y = mesh->mTangents[i].y;
vector.z = mesh->mTangents[i].z;
vertex.m_tangent = vector;
}

!Line: 188 - error: do not use pointer arithmetic [cppcoreguidelines-pro-bounds-pointer-arithmetic,-warnings-as-errors]

Shady/src/scene/model.cpp

Lines 189 to 194 in 77e1d99

vector.y = mesh->mTangents[i].y;
vector.z = mesh->mTangents[i].z;
vertex.m_tangent = vector;
}
vertices.push_back(vertex);

!Line: 189 - error: do not use pointer arithmetic [cppcoreguidelines-pro-bounds-pointer-arithmetic,-warnings-as-errors]

Shady/src/scene/model.cpp

Lines 190 to 195 in 77e1d99

vector.z = mesh->mTangents[i].z;
vertex.m_tangent = vector;
}
vertices.push_back(vertex);
}

!Line: 190 - error: do not use pointer arithmetic [cppcoreguidelines-pro-bounds-pointer-arithmetic,-warnings-as-errors]

Shady/src/scene/model.cpp

Lines 202 to 207 in 77e1d99

const auto face = mesh->mFaces[i];
// Retrieve all indices of the face and store them in the indices vector
for (uint32_t j = 0; j < face.mNumIndices; j++)
{
indices.push_back(face.mIndices[j]);
}

!Line: 202 - error: do not use pointer arithmetic [cppcoreguidelines-pro-bounds-pointer-arithmetic,-warnings-as-errors]

Shady/src/scene/model.cpp

Lines 206 to 211 in 77e1d99

indices.push_back(face.mIndices[j]);
}
}
// render::TexturePtrVec textures;
render::TextureMaps textures = {};

!Line: 206 - error: do not use pointer arithmetic [cppcoreguidelines-pro-bounds-pointer-arithmetic,-warnings-as-errors]

Shady/src/scene/model.cpp

Lines 214 to 219 in 77e1d99

aiMaterial* material = scene->mMaterials[mesh->mMaterialIndex];
LoadMaterialTextures(material, aiTextureType_DIFFUSE, textures);
// LoadMaterialTextures(material, aiTextureType_SPECULAR, textures);
LoadMaterialTextures(material, aiTextureType_UNKNOWN, textures);
LoadMaterialTextures(material, aiTextureType_NORMALS, textures);

!Line: 214 - error: do not use pointer arithmetic [cppcoreguidelines-pro-bounds-pointer-arithmetic,-warnings-as-errors]

Shady/src/scene/model.cpp

Lines 229 to 234 in 77e1d99

std::unique_ptr< Model >
Model::CreatePlane()
{
auto model = std::make_unique< Model >();
model->GetMeshes().push_back({"Plane",
{{

!Line: 229 - error: no header providing "std::unique_ptr" is directly included [misc-include-cleaner,-warnings-as-errors]

Shady/src/scene/model.cpp

Lines 232 to 237 in 77e1d99

auto model = std::make_unique< Model >();
model->GetMeshes().push_back({"Plane",
{{
{25.0f, -0.5f, 25.0f}, // Position
{0.0f, 1.0f, 0.0f}, // Normal
{25.0f, 0.0f}, // Texcoord

!Line: 232 - error: no header providing "std::make_unique" is directly included [misc-include-cleaner,-warnings-as-errors]

Shady/src/scene/model.cpp

Lines 235 to 240 in 77e1d99

{25.0f, -0.5f, 25.0f}, // Position
{0.0f, 1.0f, 0.0f}, // Normal
{25.0f, 0.0f}, // Texcoord
{50.0f, 0.0f, 0.0f} // Tangent
},
{

!Line: 235 - error: 25.0f is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,-warnings-as-errors]

Shady/src/scene/model.cpp

Lines 235 to 240 in 77e1d99

{25.0f, -0.5f, 25.0f}, // Position
{0.0f, 1.0f, 0.0f}, // Normal
{25.0f, 0.0f}, // Texcoord
{50.0f, 0.0f, 0.0f} // Tangent
},
{

!Line: 235 - error: floating point literal has suffix 'f', which is not uppercase [hicpp-uppercase-literal-suffix,-warnings-as-errors]

Shady/src/scene/model.cpp

Lines 235 to 240 in 77e1d99

{25.0f, -0.5f, 25.0f}, // Position
{0.0f, 1.0f, 0.0f}, // Normal
{25.0f, 0.0f}, // Texcoord
{50.0f, 0.0f, 0.0f} // Tangent
},
{

!Line: 235 - error: 0.5f is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,-warnings-as-errors]

Shady/src/scene/model.cpp

Lines 236 to 241 in 77e1d99

{0.0f, 1.0f, 0.0f}, // Normal
{25.0f, 0.0f}, // Texcoord
{50.0f, 0.0f, 0.0f} // Tangent
},
{
{-25.0f, -0.5f, 25.0f}, // Position

!Line: 236 - error: floating point literal has suffix 'f', which is not uppercase [hicpp-uppercase-literal-suffix,-warnings-as-errors]

Shady/src/scene/model.cpp

Lines 237 to 242 in 77e1d99

{25.0f, 0.0f}, // Texcoord
{50.0f, 0.0f, 0.0f} // Tangent
},
{
{-25.0f, -0.5f, 25.0f}, // Position
{0.0f, 1.0f, 0.0f}, // Normal

!Line: 237 - error: 25.0f is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,-warnings-as-errors]

Shady/src/scene/model.cpp

Lines 237 to 242 in 77e1d99

{25.0f, 0.0f}, // Texcoord
{50.0f, 0.0f, 0.0f} // Tangent
},
{
{-25.0f, -0.5f, 25.0f}, // Position
{0.0f, 1.0f, 0.0f}, // Normal

!Line: 237 - error: floating point literal has suffix 'f', which is not uppercase [hicpp-uppercase-literal-suffix,-warnings-as-errors]

Shady/src/scene/model.cpp

Lines 238 to 243 in 77e1d99

{50.0f, 0.0f, 0.0f} // Tangent
},
{
{-25.0f, -0.5f, 25.0f}, // Position
{0.0f, 1.0f, 0.0f}, // Normal
{0.0f, 0.0f}, // Texcoord

!Line: 238 - error: 50.0f is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,-warnings-as-errors]

Shady/src/scene/model.cpp

Lines 238 to 243 in 77e1d99

{50.0f, 0.0f, 0.0f} // Tangent
},
{
{-25.0f, -0.5f, 25.0f}, // Position
{0.0f, 1.0f, 0.0f}, // Normal
{0.0f, 0.0f}, // Texcoord

!Line: 238 - error: floating point literal has suffix 'f', which is not uppercase [hicpp-uppercase-literal-suffix,-warnings-as-errors]

Shady/src/scene/model.cpp

Lines 241 to 246 in 77e1d99

{-25.0f, -0.5f, 25.0f}, // Position
{0.0f, 1.0f, 0.0f}, // Normal
{0.0f, 0.0f}, // Texcoord
{50.0f, 0.0f, 0.0f} // Tangent
},
{

!Line: 241 - error: 25.0f is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,-warnings-as-errors]

Shady/src/scene/model.cpp

Lines 241 to 246 in 77e1d99

{-25.0f, -0.5f, 25.0f}, // Position
{0.0f, 1.0f, 0.0f}, // Normal
{0.0f, 0.0f}, // Texcoord
{50.0f, 0.0f, 0.0f} // Tangent
},
{

!Line: 241 - error: floating point literal has suffix 'f', which is not uppercase [hicpp-uppercase-literal-suffix,-warnings-as-errors]

Shady/src/scene/model.cpp

Lines 241 to 246 in 77e1d99

{-25.0f, -0.5f, 25.0f}, // Position
{0.0f, 1.0f, 0.0f}, // Normal
{0.0f, 0.0f}, // Texcoord
{50.0f, 0.0f, 0.0f} // Tangent
},
{

!Line: 241 - error: 0.5f is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,-warnings-as-errors]

Shady/src/scene/model.cpp

Lines 242 to 247 in 77e1d99

{0.0f, 1.0f, 0.0f}, // Normal
{0.0f, 0.0f}, // Texcoord
{50.0f, 0.0f, 0.0f} // Tangent
},
{
{-25.0f, -0.5f, -25.0f}, // Position

!Line: 242 - error: floating point literal has suffix 'f', which is not uppercase [hicpp-uppercase-literal-suffix,-warnings-as-errors]

Shady/src/scene/model.cpp

Lines 243 to 248 in 77e1d99

{0.0f, 0.0f}, // Texcoord
{50.0f, 0.0f, 0.0f} // Tangent
},
{
{-25.0f, -0.5f, -25.0f}, // Position
{0.0f, 1.0f, 0.0f}, // Normal

!Line: 243 - error: floating point literal has suffix 'f', which is not uppercase [hicpp-uppercase-literal-suffix,-warnings-as-errors]

Shady/src/scene/model.cpp

Lines 244 to 249 in 77e1d99

{50.0f, 0.0f, 0.0f} // Tangent
},
{
{-25.0f, -0.5f, -25.0f}, // Position
{0.0f, 1.0f, 0.0f}, // Normal
{0.0f, 25.0f}, // Texcoord

!Line: 244 - error: 50.0f is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,-warnings-as-errors]

Shady/src/scene/model.cpp

Lines 244 to 249 in 77e1d99

{50.0f, 0.0f, 0.0f} // Tangent
},
{
{-25.0f, -0.5f, -25.0f}, // Position
{0.0f, 1.0f, 0.0f}, // Normal
{0.0f, 25.0f}, // Texcoord

!Line: 244 - error: floating point literal has suffix 'f', which is not uppercase [hicpp-uppercase-literal-suffix,-warnings-as-errors]

Shady/src/scene/model.cpp

Lines 247 to 252 in 77e1d99

{-25.0f, -0.5f, -25.0f}, // Position
{0.0f, 1.0f, 0.0f}, // Normal
{0.0f, 25.0f}, // Texcoord
{50.0f, 0.0f, 0.0f} // Tangent
},
{

!Line: 247 - error: 25.0f is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,-warnings-as-errors]

Shady/src/scene/model.cpp

Lines 247 to 252 in 77e1d99

{-25.0f, -0.5f, -25.0f}, // Position
{0.0f, 1.0f, 0.0f}, // Normal
{0.0f, 25.0f}, // Texcoord
{50.0f, 0.0f, 0.0f} // Tangent
},
{

!Line: 247 - error: floating point literal has suffix 'f', which is not uppercase [hicpp-uppercase-literal-suffix,-warnings-as-errors]

Shady/src/scene/model.cpp

Lines 247 to 252 in 77e1d99

{-25.0f, -0.5f, -25.0f}, // Position
{0.0f, 1.0f, 0.0f}, // Normal
{0.0f, 25.0f}, // Texcoord
{50.0f, 0.0f, 0.0f} // Tangent
},
{

!Line: 247 - error: 0.5f is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,-warnings-as-errors]

Shady/src/scene/model.cpp

Lines 248 to 253 in 77e1d99

{0.0f, 1.0f, 0.0f}, // Normal
{0.0f, 25.0f}, // Texcoord
{50.0f, 0.0f, 0.0f} // Tangent
},
{
{25.0f, -0.5f, -25.0f}, // Position

!Line: 248 - error: floating point literal has suffix 'f', which is not uppercase [hicpp-uppercase-literal-suffix,-warnings-as-errors]

Shady/src/scene/model.cpp

Lines 249 to 254 in 77e1d99

{0.0f, 25.0f}, // Texcoord
{50.0f, 0.0f, 0.0f} // Tangent
},
{
{25.0f, -0.5f, -25.0f}, // Position
{0.0f, 1.0f, 0.0f}, // Normal

!Line: 249 - error: floating point literal has suffix 'f', which is not uppercase [hicpp-uppercase-literal-suffix,-warnings-as-errors]

Shady/src/scene/model.cpp

Lines 249 to 254 in 77e1d99

{0.0f, 25.0f}, // Texcoord
{50.0f, 0.0f, 0.0f} // Tangent
},
{
{25.0f, -0.5f, -25.0f}, // Position
{0.0f, 1.0f, 0.0f}, // Normal

!Line: 249 - error: 25.0f is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,-warnings-as-errors]

Shady/src/scene/model.cpp

Lines 250 to 255 in 77e1d99

{50.0f, 0.0f, 0.0f} // Tangent
},
{
{25.0f, -0.5f, -25.0f}, // Position
{0.0f, 1.0f, 0.0f}, // Normal
{25.0f, 25.0f}, // Texcoord

!Line: 250 - error: 50.0f is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,-warnings-as-errors]

Shady/src/scene/model.cpp

Lines 250 to 255 in 77e1d99

{50.0f, 0.0f, 0.0f} // Tangent
},
{
{25.0f, -0.5f, -25.0f}, // Position
{0.0f, 1.0f, 0.0f}, // Normal
{25.0f, 25.0f}, // Texcoord

!Line: 250 - error: floating point literal has suffix 'f', which is not uppercase [hicpp-uppercase-literal-suffix,-warnings-as-errors]

Shady/src/scene/model.cpp

Lines 253 to 258 in 77e1d99

{25.0f, -0.5f, -25.0f}, // Position
{0.0f, 1.0f, 0.0f}, // Normal
{25.0f, 25.0f}, // Texcoord
{50.0f, 0.0f, 0.0f} // Tangent
}},
{2, 1, 0, 3, 2, 0}, // Indices

!Line: 253 - error: 25.0f is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,-warnings-as-errors]

Shady/src/scene/model.cpp

Lines 253 to 258 in 77e1d99

{25.0f, -0.5f, -25.0f}, // Position
{0.0f, 1.0f, 0.0f}, // Normal
{25.0f, 25.0f}, // Texcoord
{50.0f, 0.0f, 0.0f} // Tangent
}},
{2, 1, 0, 3, 2, 0}, // Indices

!Line: 253 - error: floating point literal has suffix 'f', which is not uppercase [hicpp-uppercase-literal-suffix,-warnings-as-errors]

Shady/src/scene/model.cpp

Lines 253 to 258 in 77e1d99

{25.0f, -0.5f, -25.0f}, // Position
{0.0f, 1.0f, 0.0f}, // Normal
{25.0f, 25.0f}, // Texcoord
{50.0f, 0.0f, 0.0f} // Tangent
}},
{2, 1, 0, 3, 2, 0}, // Indices

!Line: 253 - error: 0.5f is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,-warnings-as-errors]

Shady/src/scene/model.cpp

Lines 254 to 259 in 77e1d99

{0.0f, 1.0f, 0.0f}, // Normal
{25.0f, 25.0f}, // Texcoord
{50.0f, 0.0f, 0.0f} // Tangent
}},
{2, 1, 0, 3, 2, 0}, // Indices
{}});

!Line: 254 - error: floating point literal has suffix 'f', which is not uppercase [hicpp-uppercase-literal-suffix,-warnings-as-errors]

Shady/src/scene/model.cpp

Lines 255 to 260 in 77e1d99

{25.0f, 25.0f}, // Texcoord
{50.0f, 0.0f, 0.0f} // Tangent
}},
{2, 1, 0, 3, 2, 0}, // Indices
{}});

!Line: 255 - error: 25.0f is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,-warnings-as-errors]

Shady/src/scene/model.cpp

Lines 255 to 260 in 77e1d99

{25.0f, 25.0f}, // Texcoord
{50.0f, 0.0f, 0.0f} // Tangent
}},
{2, 1, 0, 3, 2, 0}, // Indices
{}});

!Line: 255 - error: floating point literal has suffix 'f', which is not uppercase [hicpp-uppercase-literal-suffix,-warnings-as-errors]

Shady/src/scene/model.cpp

Lines 256 to 261 in 77e1d99

{50.0f, 0.0f, 0.0f} // Tangent
}},
{2, 1, 0, 3, 2, 0}, // Indices
{}});
return model;

!Line: 256 - error: 50.0f is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,-warnings-as-errors]

Shady/src/scene/model.cpp

Lines 256 to 261 in 77e1d99

{50.0f, 0.0f, 0.0f} // Tangent
}},
{2, 1, 0, 3, 2, 0}, // Indices
{}});
return model;

!Line: 256 - error: floating point literal has suffix 'f', which is not uppercase [hicpp-uppercase-literal-suffix,-warnings-as-errors]

#include "logger.hpp"
namespace shady::trace {
template < typename... Args >

!Line: 3 - error: circular header file dependency detected while including 'logger.hpp', please check the include path [misc-header-include-cycle,-warnings-as-errors]

!Line: 91 - note: 'logger.impl.hpp' included from here
!Line: 4 - note: 'logger.hpp' included from here

#include <glm/gtx/transform.hpp>
namespace shady::scene {
PerspectiveCamera::PerspectiveCamera(const glm::mat4& projection, const glm::vec3& position)
: Camera(projection, position)

!Line: 4 - error: included header transform.hpp is not used directly [misc-include-cleaner,-warnings-as-errors]

PerspectiveCamera::PerspectiveCamera(const glm::mat4& projection, const glm::vec3& position)
: Camera(projection, position)
{
}
PerspectiveCamera::PerspectiveCamera(float fieldOfView, float aspectRatio, float nearClip,

!Line: 8 - error: no header providing "glm::mat4" is directly included [misc-include-cleaner,-warnings-as-errors]

PerspectiveCamera::PerspectiveCamera(const glm::mat4& projection, const glm::vec3& position)
: Camera(projection, position)
{
}
PerspectiveCamera::PerspectiveCamera(float fieldOfView, float aspectRatio, float nearClip,

!Line: 8 - error: no header providing "glm::vec3" is directly included [misc-include-cleaner,-warnings-as-errors]

: Camera(projection, position)
{
}
PerspectiveCamera::PerspectiveCamera(float fieldOfView, float aspectRatio, float nearClip,
float farClip, const glm::vec3& position)

!Line: 9 - error: no header providing "shady::scene::Camera" is directly included [misc-include-cleaner,-warnings-as-errors]

: Camera(glm::perspective(fieldOfView, aspectRatio, nearClip, farClip), position)
{
}
void
PerspectiveCamera::MouseMovement(const glm::vec2& mouseMovement)

!Line: 15 - error: no header providing "glm::perspective" is directly included [misc-include-cleaner,-warnings-as-errors]

PerspectiveCamera::MouseMovement(const glm::vec2& mouseMovement)
{
yaw_ += mouseMovement.x;
pitch_ += mouseMovement.y;
if (constrainPitch_)

!Line: 20 - error: no header providing "glm::vec2" is directly included [misc-include-cleaner,-warnings-as-errors]

pitch_ = glm::clamp(pitch_, -89.0f, 89.0f);
}
lookAtDirection_.x = -glm::cos(glm::radians(yaw_)) * glm::cos(glm::radians(pitch_));
lookAtDirection_.y = glm::sin(glm::radians(pitch_));
lookAtDirection_.z = -glm::sin(glm::radians(yaw_)) * glm::cos(glm::radians(pitch_));

!Line: 27 - error: no header providing "glm::clamp" is directly included [misc-include-cleaner,-warnings-as-errors]

pitch_ = glm::clamp(pitch_, -89.0f, 89.0f);
}
lookAtDirection_.x = -glm::cos(glm::radians(yaw_)) * glm::cos(glm::radians(pitch_));
lookAtDirection_.y = glm::sin(glm::radians(pitch_));
lookAtDirection_.z = -glm::sin(glm::radians(yaw_)) * glm::cos(glm::radians(pitch_));

!Line: 27 - error: 89.0f is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,-warnings-as-errors]

pitch_ = glm::clamp(pitch_, -89.0f, 89.0f);
}
lookAtDirection_.x = -glm::cos(glm::radians(yaw_)) * glm::cos(glm::radians(pitch_));
lookAtDirection_.y = glm::sin(glm::radians(pitch_));
lookAtDirection_.z = -glm::sin(glm::radians(yaw_)) * glm::cos(glm::radians(pitch_));

!Line: 27 - error: floating point literal has suffix 'f', which is not uppercase [hicpp-uppercase-literal-suffix,-warnings-as-errors]

lookAtDirection_.x = -glm::cos(glm::radians(yaw_)) * glm::cos(glm::radians(pitch_));
lookAtDirection_.y = glm::sin(glm::radians(pitch_));
lookAtDirection_.z = -glm::sin(glm::radians(yaw_)) * glm::cos(glm::radians(pitch_));
lookAtDirection_ = glm::normalize(lookAtDirection_);
rightVector_ = glm::normalize(glm::cross(lookAtDirection_, worldUp_));

!Line: 30 - error: no header providing "glm::cos" is directly included [misc-include-cleaner,-warnings-as-errors]

lookAtDirection_.x = -glm::cos(glm::radians(yaw_)) * glm::cos(glm::radians(pitch_));
lookAtDirection_.y = glm::sin(glm::radians(pitch_));
lookAtDirection_.z = -glm::sin(glm::radians(yaw_)) * glm::cos(glm::radians(pitch_));
lookAtDirection_ = glm::normalize(lookAtDirection_);
rightVector_ = glm::normalize(glm::cross(lookAtDirection_, worldUp_));

!Line: 30 - error: no header providing "glm::radians" is directly included [misc-include-cleaner,-warnings-as-errors]

lookAtDirection_.y = glm::sin(glm::radians(pitch_));
lookAtDirection_.z = -glm::sin(glm::radians(yaw_)) * glm::cos(glm::radians(pitch_));
lookAtDirection_ = glm::normalize(lookAtDirection_);
rightVector_ = glm::normalize(glm::cross(lookAtDirection_, worldUp_));
upVector_ = glm::normalize(glm::cross(rightVector_, lookAtDirection_));

!Line: 31 - error: no header providing "glm::sin" is directly included [misc-include-cleaner,-warnings-as-errors]

lookAtDirection_ = glm::normalize(lookAtDirection_);
rightVector_ = glm::normalize(glm::cross(lookAtDirection_, worldUp_));
upVector_ = glm::normalize(glm::cross(rightVector_, lookAtDirection_));
UpdateViewMatrix();

!Line: 33 - error: no header providing "glm::normalize" is directly included [misc-include-cleaner,-warnings-as-errors]

rightVector_ = glm::normalize(glm::cross(lookAtDirection_, worldUp_));
upVector_ = glm::normalize(glm::cross(rightVector_, lookAtDirection_));
UpdateViewMatrix();
}

!Line: 35 - error: no header providing "glm::cross" is directly included [misc-include-cleaner,-warnings-as-errors]

constexpr auto cameraSpeed = 0.5f;
trace::Logger::Trace("Camera Pos:{} LookAtDir:{} RightVec:{}", position_, lookAtDirection_,
rightVector_);
position_ += cameraSpeed * (leftRightVec.y * lookAtDirection_);
position_ += cameraSpeed * (leftRightVec.x * rightVector_);

!Line: 44 - error: floating point literal has suffix 'f', which is not uppercase [hicpp-uppercase-literal-suffix,-warnings-as-errors]

#include "logger.hpp"
namespace shady::trace {
template < typename... Args >

!Line: 3 - error: circular header file dependency detected while including 'logger.hpp', please check the include path [misc-header-include-cycle,-warnings-as-errors]

!Line: 91 - note: 'logger.impl.hpp' included from here
!Line: 2 - note: 'logger.hpp' included from here

Shady/src/app/shady.cpp

Lines 5 to 10 in 77e1d99

#include "scene/perspective_camera.hpp"
#include "trace/logger.hpp"
#include "render/renderer.hpp"
#include <GLFW/glfw3.h>

!Line: 5 - error: included header perspective_camera.hpp is not used directly [misc-include-cleaner,-warnings-as-errors]

Shady/src/app/shady.cpp

Lines 6 to 11 in 77e1d99

#include "trace/logger.hpp"
#include "render/renderer.hpp"
#include <GLFW/glfw3.h>
namespace shady::app {

!Line: 6 - error: included header logger.hpp is not used directly [misc-include-cleaner,-warnings-as-errors]

Shady/src/app/shady.cpp

Lines 60 to 65 in 77e1d99

constexpr auto cameraMoveBy = 0.05f;
constexpr auto lightMoveBy = 0.02f;
/*
* Camera movement
*/

!Line: 60 - error: floating point literal has suffix 'f', which is not uppercase [hicpp-uppercase-literal-suffix,-warnings-as-errors]

Shady/src/app/shady.cpp

Lines 61 to 66 in 77e1d99

constexpr auto lightMoveBy = 0.02f;
/*
* Camera movement
*/
if (input::InputManager::CheckKeyPressed(GLFW_KEY_W))

!Line: 61 - error: floating point literal has suffix 'f', which is not uppercase [hicpp-uppercase-literal-suffix,-warnings-as-errors]

Shady/src/app/shady.cpp

Lines 68 to 73 in 77e1d99

camera.MoveCamera({0.0f, cameraMoveBy});
}
if (input::InputManager::CheckKeyPressed(GLFW_KEY_S))
{
camera.MoveCamera({0.0f, -cameraMoveBy});
}

!Line: 68 - error: floating point literal has suffix 'f', which is not uppercase [hicpp-uppercase-literal-suffix,-warnings-as-errors]

Shady/src/app/shady.cpp

Lines 72 to 77 in 77e1d99

camera.MoveCamera({0.0f, -cameraMoveBy});
}
if (input::InputManager::CheckKeyPressed(GLFW_KEY_A))
{
camera.MoveCamera({-cameraMoveBy, 0.0f});
}

!Line: 72 - error: floating point literal has suffix 'f', which is not uppercase [hicpp-uppercase-literal-suffix,-warnings-as-errors]

Shady/src/app/shady.cpp

Lines 76 to 81 in 77e1d99

camera.MoveCamera({-cameraMoveBy, 0.0f});
}
if (input::InputManager::CheckKeyPressed(GLFW_KEY_D))
{
camera.MoveCamera({cameraMoveBy, 0.0f});
}

!Line: 76 - error: floating point literal has suffix 'f', which is not uppercase [hicpp-uppercase-literal-suffix,-warnings-as-errors]

Shady/src/app/shady.cpp

Lines 80 to 85 in 77e1d99

camera.MoveCamera({cameraMoveBy, 0.0f});
}
/*
* Light movement
*/

!Line: 80 - error: floating point literal has suffix 'f', which is not uppercase [hicpp-uppercase-literal-suffix,-warnings-as-errors]

Shady/src/app/shady.cpp

Lines 88 to 93 in 77e1d99

light.MoveBy({lightMoveBy, 0.0f, 0.0f});
}
if (input::InputManager::CheckKeyPressed(GLFW_KEY_UP))
{
light.MoveBy({0.0f, -lightMoveBy, 0.0f});
}

!Line: 88 - error: floating point literal has suffix 'f', which is not uppercase [hicpp-uppercase-literal-suffix,-warnings-as-errors]

Shady/src/app/shady.cpp

Lines 92 to 97 in 77e1d99

light.MoveBy({0.0f, -lightMoveBy, 0.0f});
}
if (input::InputManager::CheckKeyPressed(GLFW_KEY_DOWN))
{
light.MoveBy({0.0f, lightMoveBy, 0.0f});
}

!Line: 92 - error: floating point literal has suffix 'f', which is not uppercase [hicpp-uppercase-literal-suffix,-warnings-as-errors]

Shady/src/app/shady.cpp

Lines 96 to 101 in 77e1d99

light.MoveBy({0.0f, lightMoveBy, 0.0f});
}
if (input::InputManager::CheckKeyPressed(GLFW_KEY_RIGHT))
{
light.MoveBy({-lightMoveBy, 0.0f, 0.0f});
}

!Line: 96 - error: floating point literal has suffix 'f', which is not uppercase [hicpp-uppercase-literal-suffix,-warnings-as-errors]

Shady/src/app/shady.cpp

Lines 100 to 105 in 77e1d99

light.MoveBy({-lightMoveBy, 0.0f, 0.0f});
}
if (input::InputManager::CheckKeyPressed(GLFW_KEY_R))
{
camera.SetView(light.GetViewMat());

!Line: 100 - error: floating point literal has suffix 'f', which is not uppercase [hicpp-uppercase-literal-suffix,-warnings-as-errors]

Shady/src/app/shady.cpp

Lines 114 to 119 in 77e1d99

Shady::KeyCallback(const input::KeyEvent& event)
{
switch (event.GetKey())
{
case GLFW_KEY_ESCAPE: {
m_active = false;

!Line: 114 - error: no header providing "shady::app::input::KeyEvent" is directly included [misc-include-cleaner,-warnings-as-errors]

Shady/src/app/shady.cpp

Lines 116 to 121 in 77e1d99

switch (event.GetKey())
{
case GLFW_KEY_ESCAPE: {
m_active = false;
}
break;

!Line: 116 - error: switching on non-enum value without default case may not cover all cases [bugprone-switch-missing-default-case,-warnings-as-errors]

Shady/src/app/shady.cpp

Lines 126 to 131 in 77e1d99

Shady::MouseButtonCallback(const input::MouseButtonEvent& /*event*/)
{
}
void
Shady::CursorPositionCallback(const input::CursorPositionEvent& event)

!Line: 126 - error: no header providing "shady::app::input::MouseButtonEvent" is directly included [misc-include-cleaner,-warnings-as-errors]

Shady/src/app/shady.cpp

Lines 131 to 136 in 77e1d99

Shady::CursorPositionCallback(const input::CursorPositionEvent& event)
{
if (input::InputManager::CheckButtonPressed(GLFW_MOUSE_BUTTON_LEFT)
and !app::gui::Gui::UpdateUI({m_windowWidth, m_windowHeight}, m_currentScene))
{
m_currentScene.GetCamera().MouseMovement({event.GetXDelta(), event.GetYDelta()});

!Line: 131 - error: no header providing "shady::app::input::CursorPositionEvent" is directly included [misc-include-cleaner,-warnings-as-errors]

Shady/src/app/shady.cpp

Lines 141 to 145 in 77e1d99

Shady::MouseScrollCallback(const input::MouseScrollEvent& /*event*/)
{
}
} // namespace shady::app

!Line: 141 - error: no header providing "shady::app::input::MouseScrollEvent" is directly included [misc-include-cleaner,-warnings-as-errors]

#include "logger.hpp"
namespace shady::trace {
template < typename... Args >

!Line: 3 - error: circular header file dependency detected while including 'logger.hpp', please check the include path [misc-header-include-cycle,-warnings-as-errors]

!Line: 91 - note: 'logger.impl.hpp' included from here
!Line: 6 - note: 'logger.hpp' included from here

#include "trace/logger.hpp"
#include <glm/gtc/matrix_transform.hpp>
namespace shady::scene {

!Line: 2 - error: included header logger.hpp is not used directly [misc-include-cleaner,-warnings-as-errors]

#include <glm/gtc/matrix_transform.hpp>
namespace shady::scene {
Light::Light(const glm::vec3& position, const glm::vec3& color, LightType type)
: position_(position), color_(color)

!Line: 4 - error: included header matrix_transform.hpp is not used directly [misc-include-cleaner,-warnings-as-errors]

Light::Light(const glm::vec3& position, const glm::vec3& color, LightType type)
: position_(position), color_(color)
{
// auto buffer_type = render::FrameBufferType::SINGLE;
switch (type)
{

!Line: 8 - error: no header providing "glm::vec3" is directly included [misc-include-cleaner,-warnings-as-errors]

projectionMatrix_ = glm::ortho(-200.0f, 200.0f, -200.0f, 200.0f, 1.0f, 500.0f);
// projectionMatrix_ = glm::perspective(70.0f, 16.0f / 9.0f, 0.1f, 500.0f);
}
break;
case LightType::POINT_LIGHT:

!Line: 15 - error: no header providing "glm::ortho" is directly included [misc-include-cleaner,-warnings-as-errors]

projectionMatrix_ = glm::ortho(-200.0f, 200.0f, -200.0f, 200.0f, 1.0f, 500.0f);
// projectionMatrix_ = glm::perspective(70.0f, 16.0f / 9.0f, 0.1f, 500.0f);
}
break;
case LightType::POINT_LIGHT:

!Line: 15 - error: 200.0f is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,-warnings-as-errors]

projectionMatrix_ = glm::ortho(-200.0f, 200.0f, -200.0f, 200.0f, 1.0f, 500.0f);
// projectionMatrix_ = glm::perspective(70.0f, 16.0f / 9.0f, 0.1f, 500.0f);
}
break;
case LightType::POINT_LIGHT:

!Line: 15 - error: floating point literal has suffix 'f', which is not uppercase [hicpp-uppercase-literal-suffix,-warnings-as-errors]

projectionMatrix_ = glm::ortho(-200.0f, 200.0f, -200.0f, 200.0f, 1.0f, 500.0f);
// projectionMatrix_ = glm::perspective(70.0f, 16.0f / 9.0f, 0.1f, 500.0f);
}
break;
case LightType::POINT_LIGHT:

!Line: 15 - error: 500.0f is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,-warnings-as-errors]

projectionMatrix_ = glm::perspective(60.0f, 1.0f, 0.1f, 100.0f);
// buffer_type = render::FrameBufferType::CUBE;
}
break;
}

!Line: 22 - error: no header providing "glm::perspective" is directly included [misc-include-cleaner,-warnings-as-errors]

projectionMatrix_ = glm::perspective(60.0f, 1.0f, 0.1f, 100.0f);
// buffer_type = render::FrameBufferType::CUBE;
}
break;
}

!Line: 22 - error: 60.0f is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,-warnings-as-errors]

projectionMatrix_ = glm::perspective(60.0f, 1.0f, 0.1f, 100.0f);
// buffer_type = render::FrameBufferType::CUBE;
}
break;
}

!Line: 22 - error: floating point literal has suffix 'f', which is not uppercase [hicpp-uppercase-literal-suffix,-warnings-as-errors]

projectionMatrix_ = glm::perspective(60.0f, 1.0f, 0.1f, 100.0f);
// buffer_type = render::FrameBufferType::CUBE;
}
break;
}

!Line: 22 - error: 0.1f is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,-warnings-as-errors]

biasMatrix_ = glm::translate(glm::mat4(1.0f), glm::vec3(0.5f))
* glm::scale(glm::mat4(1.0f), glm::vec3(0.5f));
lookAt_ = glm::vec3(0.0f, -1.0f, 0.0f);
upVec_ = glm::vec3(0.0f, 0.0f, 0.5f);
// m_shadowBuffer->MakeTextureResident();

!Line: 30 - error: no header providing "glm::translate" is directly included [misc-include-cleaner,-warnings-as-errors]

biasMatrix_ = glm::translate(glm::mat4(1.0f), glm::vec3(0.5f))
* glm::scale(glm::mat4(1.0f), glm::vec3(0.5f));
lookAt_ = glm::vec3(0.0f, -1.0f, 0.0f);
upVec_ = glm::vec3(0.0f, 0.0f, 0.5f);
// m_shadowBuffer->MakeTextureResident();

!Line: 30 - error: floating point literal has suffix 'f', which is not uppercase [hicpp-uppercase-literal-suffix,-warnings-as-errors]

biasMatrix_ = glm::translate(glm::mat4(1.0f), glm::vec3(0.5f))
* glm::scale(glm::mat4(1.0f), glm::vec3(0.5f));
lookAt_ = glm::vec3(0.0f, -1.0f, 0.0f);
upVec_ = glm::vec3(0.0f, 0.0f, 0.5f);
// m_shadowBuffer->MakeTextureResident();

!Line: 30 - error: 0.5f is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,-warnings-as-errors]

* glm::scale(glm::mat4(1.0f), glm::vec3(0.5f));
lookAt_ = glm::vec3(0.0f, -1.0f, 0.0f);
upVec_ = glm::vec3(0.0f, 0.0f, 0.5f);
// m_shadowBuffer->MakeTextureResident();
UpdateViewProjection();

!Line: 31 - error: no header providing "glm::scale" is directly included [misc-include-cleaner,-warnings-as-errors]

* glm::scale(glm::mat4(1.0f), glm::vec3(0.5f));
lookAt_ = glm::vec3(0.0f, -1.0f, 0.0f);
upVec_ = glm::vec3(0.0f, 0.0f, 0.5f);
// m_shadowBuffer->MakeTextureResident();
UpdateViewProjection();

!Line: 31 - error: floating point literal has suffix 'f', which is not uppercase [hicpp-uppercase-literal-suffix,-warnings-as-errors]


!Maximum character count per GitHub comment has been reached! Not all warnings/errors has been parsed!

@JacobDomagala JacobDomagala merged commit f93f0a1 into master Apr 24, 2024
2 of 3 checks passed
@JacobDomagala JacobDomagala deleted the 120-update-ci-to-use-conan-2 branch April 24, 2024 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update CI to use conan 2
1 participant