Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#117]: Update README #123

Merged
merged 1 commit into from
Apr 25, 2024
Merged

[#117]: Update README #123

merged 1 commit into from
Apr 25, 2024

Conversation

JacobDomagala
Copy link
Owner

Fixes #117

@JacobDomagala JacobDomagala self-assigned this Apr 25, 2024
@JacobDomagala JacobDomagala linked an issue Apr 25, 2024 that may be closed by this pull request
Copy link

✅ WINDOWS COMPILE RESULT - SUCCESS! ✅

Copy link

✅ UBUNTU COMPILE RESULT - SUCCESS! ✅

Copy link

⚡ Static analysis result ⚡

🔴 cppcheck found 8 issues! Click here to see details.

CopyDataWithStaging(void* data, size_t dataSize);
static void
CopyDataToImageWithStaging(VkImage image, void* data, size_t dataSize,
const std::vector< VkBufferImageCopy >& copyRegions);

!Line: 40 - style: inconclusive: Technically the member function 'shady::render::Buffer::CopyDataWithStaging' can be const. [functionConst]

!Line: 36 - note: Technically the member function 'shady::render::Buffer::CopyDataWithStaging' can be const.
!Line: 40 - note: Technically the member function 'shady::render::Buffer::CopyDataWithStaging' can be const.

Buffer::CopyDataWithStaging(void* data, size_t dataSize)
{
VkBuffer stagingBuffer{};
VkDeviceMemory stagingBufferMemory{};
Buffer::CreateBuffer(dataSize, VK_BUFFER_USAGE_TRANSFER_SRC_BIT,
VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT | VK_MEMORY_PROPERTY_HOST_COHERENT_BIT,

!Line: 36 - style: Parameter 'data' can be declared as pointer to const [constParameterPointer]

Buffer::CopyDataToImageWithStaging(VkImage image, void* data, size_t dataSize,
const std::vector< VkBufferImageCopy >& copyRegions)
{
VkBuffer stagingBuffer{};
VkDeviceMemory stagingBufferMemory{};
Buffer::CreateBuffer(dataSize, VK_BUFFER_USAGE_TRANSFER_SRC_BIT,

!Line: 53 - style: Parameter 'data' can be declared as pointer to const [constParameterPointer]

TransitionImageLayout(VkImageLayout oldLayout, VkImageLayout newLayout, uint32_t mipLevels);
void
CopyBufferToImage(uint8_t* data);
private:

!Line: 61 - style: inconclusive: Technically the member function 'shady::render::Texture::TransitionImageLayout' can be const. [functionConst]

!Line: 376 - note: Technically the member function 'shady::render::Texture::TransitionImageLayout' can be const.
!Line: 61 - note: Technically the member function 'shady::render::Texture::TransitionImageLayout' can be const.

CopyBufferToImage(uint8_t* data);
private:
TextureType m_type = {};
VkImage m_textureImage = {};
VkDeviceMemory m_textureImageMemory = {};

!Line: 64 - style: inconclusive: Technically the member function 'shady::render::Texture::CopyBufferToImage' can be const. [functionConst]

!Line: 320 - note: Technically the member function 'shady::render::Texture::CopyBufferToImage' can be const.
!Line: 64 - note: Technically the member function 'shady::render::Texture::CopyBufferToImage' can be const.

Shady/src/scene/mesh.hpp

Lines 21 to 26 in 475cc00

Submit();
void
Draw(const std::string& modelName, const glm::mat4& modelMat, const glm::vec4& tintColor);
void

!Line: 21 - style: inconclusive: Technically the member function 'shady::scene::Mesh::Submit' can be const. [functionConst]

!Line: 24 - note: Technically the member function 'shady::scene::Mesh::Submit' can be const.
!Line: 21 - note: Technically the member function 'shady::scene::Mesh::Submit' can be const.

Shady/src/scene/mesh.hpp

Lines 24 to 29 in 475cc00

Draw(const std::string& modelName, const glm::mat4& modelMat, const glm::vec4& tintColor);
void
Scale(const glm::vec3& scale);
void

!Line: 24 - style: inconclusive: Technically the member function 'shady::scene::Mesh::Draw' can be const. [functionConst]

!Line: 30 - note: Technically the member function 'shady::scene::Mesh::Draw' can be const.
!Line: 24 - note: Technically the member function 'shady::scene::Mesh::Draw' can be const.

UpdateBuffers(const scene::Camera* camera);
private:
void
CreatePipeline();

!Line: 45 - style: inconclusive: Technically the member function 'shady::scene::Skybox::UpdateBuffers' can be const. [functionConst]

!Line: 122 - note: Technically the member function 'shady::scene::Skybox::UpdateBuffers' can be const.
!Line: 45 - note: Technically the member function 'shady::scene::Skybox::UpdateBuffers' can be const.

🔴 clang-tidy found 167 issues! Click here to see details.

#include "trace/logger.hpp"
#include <glm/gtx/transform.hpp>
namespace shady::scene {

!Line: 2 - error: included header logger.hpp is not used directly [misc-include-cleaner,-warnings-as-errors]

#include <glm/gtx/transform.hpp>
namespace shady::scene {
Camera::Camera(const glm::mat4& projection, const glm::vec3& position)
: projectionMat_(projection), position_(position)

!Line: 4 - error: included header transform.hpp is not used directly [misc-include-cleaner,-warnings-as-errors]

Camera::Camera(const glm::mat4& projection, const glm::vec3& position)
: projectionMat_(projection), position_(position)
{
UpdateViewMatrix();
}

!Line: 8 - error: no header providing "glm::mat4" is directly included [misc-include-cleaner,-warnings-as-errors]

Camera::Camera(const glm::mat4& projection, const glm::vec3& position)
: projectionMat_(projection), position_(position)
{
UpdateViewMatrix();
}

!Line: 8 - error: no header providing "glm::vec3" is directly included [misc-include-cleaner,-warnings-as-errors]

const auto inversed = glm::inverse(view);
rightVector_ = glm::normalize(inversed[0]);
position_ = inversed[3];
lookAtDirection_ = glm::vec3(inversed[1]) - position_;
upVector_ = glm::normalize(glm::cross(rightVector_, glm::normalize(lookAtDirection_)));

!Line: 29 - error: no header providing "glm::inverse" is directly included [misc-include-cleaner,-warnings-as-errors]

rightVector_ = glm::normalize(inversed[0]);
position_ = inversed[3];
lookAtDirection_ = glm::vec3(inversed[1]) - position_;
upVector_ = glm::normalize(glm::cross(rightVector_, glm::normalize(lookAtDirection_)));
viewMat_ = view;

!Line: 31 - error: no header providing "glm::normalize" is directly included [misc-include-cleaner,-warnings-as-errors]

upVector_ = glm::normalize(glm::cross(rightVector_, glm::normalize(lookAtDirection_)));
viewMat_ = view;
UpdateViewProjection();
}

!Line: 34 - error: no header providing "glm::cross" is directly included [misc-include-cleaner,-warnings-as-errors]

viewMat_ = glm::lookAt(position_, position_ + lookAtDirection_, upVector_);
UpdateViewProjection();
}
void
Camera::UpdateViewProjection()

!Line: 93 - error: no header providing "glm::lookAt" is directly included [misc-include-cleaner,-warnings-as-errors]

#include "logger.hpp"
namespace shady::trace {
template < typename... Args >

!Line: 3 - error: circular header file dependency detected while including 'logger.hpp', please check the include path [misc-header-include-cycle,-warnings-as-errors]

!Line: 91 - note: 'logger.impl.hpp' included from here
!Line: 2 - note: 'logger.hpp' included from here

VkCommandBuffer
Command::BeginSingleTimeCommands()
{
VkCommandBufferAllocateInfo allocInfo{};
allocInfo.sType = VK_STRUCTURE_TYPE_COMMAND_BUFFER_ALLOCATE_INFO;
allocInfo.level = VK_COMMAND_BUFFER_LEVEL_PRIMARY;

!Line: 6 - error: no header providing "VkCommandBuffer" is directly included [misc-include-cleaner,-warnings-as-errors]

VkCommandBufferAllocateInfo allocInfo{};
allocInfo.sType = VK_STRUCTURE_TYPE_COMMAND_BUFFER_ALLOCATE_INFO;
allocInfo.level = VK_COMMAND_BUFFER_LEVEL_PRIMARY;
allocInfo.commandPool = Data::vk_commandPool;
allocInfo.commandBufferCount = 1;

!Line: 9 - error: no header providing "VkCommandBufferAllocateInfo" is directly included [misc-include-cleaner,-warnings-as-errors]

allocInfo.sType = VK_STRUCTURE_TYPE_COMMAND_BUFFER_ALLOCATE_INFO;
allocInfo.level = VK_COMMAND_BUFFER_LEVEL_PRIMARY;
allocInfo.commandPool = Data::vk_commandPool;
allocInfo.commandBufferCount = 1;
VkCommandBuffer commandBuffer{};

!Line: 10 - error: no header providing "VK_STRUCTURE_TYPE_COMMAND_BUFFER_ALLOCATE_INFO" is directly included [misc-include-cleaner,-warnings-as-errors]

allocInfo.level = VK_COMMAND_BUFFER_LEVEL_PRIMARY;
allocInfo.commandPool = Data::vk_commandPool;
allocInfo.commandBufferCount = 1;
VkCommandBuffer commandBuffer{};
vkAllocateCommandBuffers(Data::vk_device, &allocInfo, &commandBuffer);

!Line: 11 - error: no header providing "VK_COMMAND_BUFFER_LEVEL_PRIMARY" is directly included [misc-include-cleaner,-warnings-as-errors]

vkAllocateCommandBuffers(Data::vk_device, &allocInfo, &commandBuffer);
VkCommandBufferBeginInfo beginInfo{};
beginInfo.sType = VK_STRUCTURE_TYPE_COMMAND_BUFFER_BEGIN_INFO;
beginInfo.flags = VK_COMMAND_BUFFER_USAGE_ONE_TIME_SUBMIT_BIT;

!Line: 16 - error: no header providing "vkAllocateCommandBuffers" is directly included [misc-include-cleaner,-warnings-as-errors]

VkCommandBufferBeginInfo beginInfo{};
beginInfo.sType = VK_STRUCTURE_TYPE_COMMAND_BUFFER_BEGIN_INFO;
beginInfo.flags = VK_COMMAND_BUFFER_USAGE_ONE_TIME_SUBMIT_BIT;
vkBeginCommandBuffer(commandBuffer, &beginInfo);

!Line: 18 - error: no header providing "VkCommandBufferBeginInfo" is directly included [misc-include-cleaner,-warnings-as-errors]

beginInfo.sType = VK_STRUCTURE_TYPE_COMMAND_BUFFER_BEGIN_INFO;
beginInfo.flags = VK_COMMAND_BUFFER_USAGE_ONE_TIME_SUBMIT_BIT;
vkBeginCommandBuffer(commandBuffer, &beginInfo);
return commandBuffer;

!Line: 19 - error: no header providing "VK_STRUCTURE_TYPE_COMMAND_BUFFER_BEGIN_INFO" is directly included [misc-include-cleaner,-warnings-as-errors]

beginInfo.flags = VK_COMMAND_BUFFER_USAGE_ONE_TIME_SUBMIT_BIT;
vkBeginCommandBuffer(commandBuffer, &beginInfo);
return commandBuffer;
}

!Line: 20 - error: no header providing "VK_COMMAND_BUFFER_USAGE_ONE_TIME_SUBMIT_BIT" is directly included [misc-include-cleaner,-warnings-as-errors]

vkBeginCommandBuffer(commandBuffer, &beginInfo);
return commandBuffer;
}
void

!Line: 22 - error: no header providing "vkBeginCommandBuffer" is directly included [misc-include-cleaner,-warnings-as-errors]

vkEndCommandBuffer(commandBuffer);
VkSubmitInfo submitInfo{};
submitInfo.sType = VK_STRUCTURE_TYPE_SUBMIT_INFO;
submitInfo.commandBufferCount = 1;
submitInfo.pCommandBuffers = &commandBuffer;

!Line: 30 - error: no header providing "vkEndCommandBuffer" is directly included [misc-include-cleaner,-warnings-as-errors]

VkSubmitInfo submitInfo{};
submitInfo.sType = VK_STRUCTURE_TYPE_SUBMIT_INFO;
submitInfo.commandBufferCount = 1;
submitInfo.pCommandBuffers = &commandBuffer;
vkQueueSubmit(Data::vk_graphicsQueue, 1, &submitInfo, VK_NULL_HANDLE);

!Line: 32 - error: no header providing "VkSubmitInfo" is directly included [misc-include-cleaner,-warnings-as-errors]

submitInfo.sType = VK_STRUCTURE_TYPE_SUBMIT_INFO;
submitInfo.commandBufferCount = 1;
submitInfo.pCommandBuffers = &commandBuffer;
vkQueueSubmit(Data::vk_graphicsQueue, 1, &submitInfo, VK_NULL_HANDLE);
vkQueueWaitIdle(Data::vk_graphicsQueue);

!Line: 33 - error: no header providing "VK_STRUCTURE_TYPE_SUBMIT_INFO" is directly included [misc-include-cleaner,-warnings-as-errors]

vkQueueSubmit(Data::vk_graphicsQueue, 1, &submitInfo, VK_NULL_HANDLE);
vkQueueWaitIdle(Data::vk_graphicsQueue);
vkFreeCommandBuffers(Data::vk_device, Data::vk_commandPool, 1, &commandBuffer);
}

!Line: 37 - error: no header providing "vkQueueSubmit" is directly included [misc-include-cleaner,-warnings-as-errors]

vkQueueSubmit(Data::vk_graphicsQueue, 1, &submitInfo, VK_NULL_HANDLE);
vkQueueWaitIdle(Data::vk_graphicsQueue);
vkFreeCommandBuffers(Data::vk_device, Data::vk_commandPool, 1, &commandBuffer);
}

!Line: 37 - error: no header providing "VK_NULL_HANDLE" is directly included [misc-include-cleaner,-warnings-as-errors]

vkQueueWaitIdle(Data::vk_graphicsQueue);
vkFreeCommandBuffers(Data::vk_device, Data::vk_commandPool, 1, &commandBuffer);
}
} // namespace shady::render

!Line: 38 - error: no header providing "vkQueueWaitIdle" is directly included [misc-include-cleaner,-warnings-as-errors]

vkFreeCommandBuffers(Data::vk_device, Data::vk_commandPool, 1, &commandBuffer);
}
} // namespace shady::render

!Line: 40 - error: no header providing "vkFreeCommandBuffers" is directly included [misc-include-cleaner,-warnings-as-errors]

#include "trace/logger.hpp"
#include "utils/assert.hpp"
#include "utils/file_manager.hpp"
namespace shady::render {

!Line: 3 - error: included header logger.hpp is not used directly [misc-include-cleaner,-warnings-as-errors]

#include "utils/assert.hpp"
#include "utils/file_manager.hpp"
namespace shady::render {
static VkShaderModule

!Line: 4 - error: included header assert.hpp is not used directly [misc-include-cleaner,-warnings-as-errors]

static VkShaderModule
CreateShaderModule(VkDevice device, std::vector< char >&& shaderByteCode)
{
VkShaderModuleCreateInfo createInfo{};
createInfo.sType = VK_STRUCTURE_TYPE_SHADER_MODULE_CREATE_INFO;
createInfo.codeSize = shaderByteCode.size();

!Line: 9 - error: no header providing "VkShaderModule" is directly included [misc-include-cleaner,-warnings-as-errors]

CreateShaderModule(VkDevice device, std::vector< char >&& shaderByteCode)
{
VkShaderModuleCreateInfo createInfo{};
createInfo.sType = VK_STRUCTURE_TYPE_SHADER_MODULE_CREATE_INFO;
createInfo.codeSize = shaderByteCode.size();
createInfo.pCode = reinterpret_cast< const uint32_t* >(shaderByteCode.data());

!Line: 10 - error: function 'CreateShaderModule' declared 'static', move to anonymous namespace instead [misc-use-anonymous-namespace,-warnings-as-errors]

CreateShaderModule(VkDevice device, std::vector< char >&& shaderByteCode)
{
VkShaderModuleCreateInfo createInfo{};
createInfo.sType = VK_STRUCTURE_TYPE_SHADER_MODULE_CREATE_INFO;
createInfo.codeSize = shaderByteCode.size();
createInfo.pCode = reinterpret_cast< const uint32_t* >(shaderByteCode.data());

!Line: 10 - error: no header providing "VkDevice" is directly included [misc-include-cleaner,-warnings-as-errors]

CreateShaderModule(VkDevice device, std::vector< char >&& shaderByteCode)
{
VkShaderModuleCreateInfo createInfo{};
createInfo.sType = VK_STRUCTURE_TYPE_SHADER_MODULE_CREATE_INFO;
createInfo.codeSize = shaderByteCode.size();
createInfo.pCode = reinterpret_cast< const uint32_t* >(shaderByteCode.data());

!Line: 10 - error: no header providing "std::vector" is directly included [misc-include-cleaner,-warnings-as-errors]

CreateShaderModule(VkDevice device, std::vector< char >&& shaderByteCode)
{
VkShaderModuleCreateInfo createInfo{};
createInfo.sType = VK_STRUCTURE_TYPE_SHADER_MODULE_CREATE_INFO;
createInfo.codeSize = shaderByteCode.size();
createInfo.pCode = reinterpret_cast< const uint32_t* >(shaderByteCode.data());

!Line: 10 - error: rvalue reference parameter 'shaderByteCode' is never moved from inside the function body [cppcoreguidelines-rvalue-reference-param-not-moved,-warnings-as-errors]

VkShaderModuleCreateInfo createInfo{};
createInfo.sType = VK_STRUCTURE_TYPE_SHADER_MODULE_CREATE_INFO;
createInfo.codeSize = shaderByteCode.size();
createInfo.pCode = reinterpret_cast< const uint32_t* >(shaderByteCode.data());
VkShaderModule shaderModule = {};

!Line: 12 - error: no header providing "VkShaderModuleCreateInfo" is directly included [misc-include-cleaner,-warnings-as-errors]

createInfo.sType = VK_STRUCTURE_TYPE_SHADER_MODULE_CREATE_INFO;
createInfo.codeSize = shaderByteCode.size();
createInfo.pCode = reinterpret_cast< const uint32_t* >(shaderByteCode.data());
VkShaderModule shaderModule = {};
VK_CHECK(vkCreateShaderModule(device, &createInfo, nullptr, &shaderModule),

!Line: 13 - error: no header providing "VK_STRUCTURE_TYPE_SHADER_MODULE_CREATE_INFO" is directly included [misc-include-cleaner,-warnings-as-errors]

createInfo.pCode = reinterpret_cast< const uint32_t* >(shaderByteCode.data());
VkShaderModule shaderModule = {};
VK_CHECK(vkCreateShaderModule(device, &createInfo, nullptr, &shaderModule),
"Failed to create shader module!");

!Line: 15 - error: no header providing "uint32_t" is directly included [misc-include-cleaner,-warnings-as-errors]

VK_CHECK(vkCreateShaderModule(device, &createInfo, nullptr, &shaderModule),
"Failed to create shader module!");
return shaderModule;
}

!Line: 18 - error: no header providing "vkCreateShaderModule" is directly included [misc-include-cleaner,-warnings-as-errors]

Shader::LoadShader(std::string_view shader, VkShaderStageFlagBits stage)
{
VkShaderModule shaderModule = CreateShaderModule(
Data::vk_device,
utils::FileManager::ReadBinaryFile(utils::FileManager::SHADERS_DIR / shader));

!Line: 26 - error: no header providing "VkShaderStageFlagBits" is directly included [misc-include-cleaner,-warnings-as-errors]

VkPipelineShaderStageCreateInfo shaderStageInfo{};
shaderStageInfo.sType = VK_STRUCTURE_TYPE_PIPELINE_SHADER_STAGE_CREATE_INFO;
shaderStageInfo.stage = stage;
shaderStageInfo.module = shaderModule;
shaderStageInfo.pName = "main";

!Line: 32 - error: no header providing "VkPipelineShaderStageCreateInfo" is directly included [misc-include-cleaner,-warnings-as-errors]

shaderStageInfo.sType = VK_STRUCTURE_TYPE_PIPELINE_SHADER_STAGE_CREATE_INFO;
shaderStageInfo.stage = stage;
shaderStageInfo.module = shaderModule;
shaderStageInfo.pName = "main";
return {Data::vk_device, shaderStageInfo};

!Line: 33 - error: no header providing "VK_STRUCTURE_TYPE_PIPELINE_SHADER_STAGE_CREATE_INFO" is directly included [misc-include-cleaner,-warnings-as-errors]

std::pair< VertexShaderInfo, FragmentShaderInfo >
Shader::CreateShader(VkDevice device, std::string_view vertex, std::string_view fragment)
{
VkShaderModule vertShaderModule = CreateShaderModule(
device, utils::FileManager::ReadBinaryFile(utils::FileManager::SHADERS_DIR / vertex));
VkShaderModule fragShaderModule = CreateShaderModule(

!Line: 41 - error: no header providing "std::pair" is directly included [misc-include-cleaner,-warnings-as-errors]

vertShaderStageInfo.stage = VK_SHADER_STAGE_VERTEX_BIT;
vertShaderStageInfo.module = vertShaderModule;
vertShaderStageInfo.pName = "main";
VkPipelineShaderStageCreateInfo fragShaderStageInfo{};
fragShaderStageInfo.sType = VK_STRUCTURE_TYPE_PIPELINE_SHADER_STAGE_CREATE_INFO;

!Line: 51 - error: no header providing "VK_SHADER_STAGE_VERTEX_BIT" is directly included [misc-include-cleaner,-warnings-as-errors]

fragShaderStageInfo.stage = VK_SHADER_STAGE_FRAGMENT_BIT;
fragShaderStageInfo.module = fragShaderModule;
fragShaderStageInfo.pName = "main";
return {{device, vertShaderStageInfo}, {device, fragShaderStageInfo}};
}

!Line: 57 - error: no header providing "VK_SHADER_STAGE_FRAGMENT_BIT" is directly included [misc-include-cleaner,-warnings-as-errors]

#include "logger.hpp"
namespace shady::trace {
template < typename... Args >

!Line: 3 - error: circular header file dependency detected while including 'logger.hpp', please check the include path [misc-header-include-cycle,-warnings-as-errors]

!Line: 91 - note: 'logger.impl.hpp' included from here
!Line: 3 - note: 'logger.hpp' included from here

#include <functional>
#include <glm/gtc/matrix_transform.hpp>
namespace shady::app {

!Line: 6 - error: included header functional is not used directly [misc-include-cleaner,-warnings-as-errors]

#include <glm/gtc/matrix_transform.hpp>
namespace shady::app {

!Line: 7 - error: included header matrix_transform.hpp is not used directly [misc-include-cleaner,-warnings-as-errors]

Shady/src/app/window.cpp

Lines 13 to 18 in 475cc00

Window::Window(int32_t width, int32_t height, const std::string& title)
{
Create(width, height, title);
}
Window::~Window()

!Line: 13 - error: no header providing "int32_t" is directly included [misc-include-cleaner,-warnings-as-errors]

Shady/src/app/window.cpp

Lines 13 to 18 in 475cc00

Window::Window(int32_t width, int32_t height, const std::string& title)
{
Create(width, height, title);
}
Window::~Window()

!Line: 13 - error: no header providing "std::string" is directly included [misc-include-cleaner,-warnings-as-errors]

Shady/src/app/window.cpp

Lines 37 to 42 in 475cc00

glfwWindowHint(GLFW_VISIBLE, GL_TRUE);
glfwWindowHint(GLFW_RESIZABLE, GL_FALSE);
m_pWindow = glfwCreateWindow(m_width, m_height, title.c_str(), nullptr, nullptr);
utils::Assert(m_pWindow, "Failed to create GLFW window!");

!Line: 37 - error: no header providing "GL_TRUE" is directly included [misc-include-cleaner,-warnings-as-errors]

Shady/src/app/window.cpp

Lines 38 to 43 in 475cc00

glfwWindowHint(GLFW_RESIZABLE, GL_FALSE);
m_pWindow = glfwCreateWindow(m_width, m_height, title.c_str(), nullptr, nullptr);
utils::Assert(m_pWindow, "Failed to create GLFW window!");

!Line: 38 - error: no header providing "GL_FALSE" is directly included [misc-include-cleaner,-warnings-as-errors]

Shady/src/app/window.cpp

Lines 60 to 65 in 475cc00

image.width = 16;
image.height = 16;
// image.pixels = TextureLibrary::GetTexture(file)->GetData();
auto* cursor = glfwCreateCursor(&image, 0, 0);
glfwSetCursor(m_pWindow, cursor);

!Line: 60 - error: 16 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,-warnings-as-errors]

Shady/src/app/window.cpp

Lines 61 to 66 in 475cc00

image.height = 16;
// image.pixels = TextureLibrary::GetTexture(file)->GetData();
auto* cursor = glfwCreateCursor(&image, 0, 0);
glfwSetCursor(m_pWindow, cursor);
}

!Line: 61 - error: 16 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,-warnings-as-errors]

Shady/src/app/window.cpp

Lines 98 to 103 in 475cc00

glm::vec2
Window::GetCursorScreenPosition(const glm::mat4& /*projectionMatrix*/)
{
auto cursorPos = GetCursor();
cursorPos -=

!Line: 98 - error: no header providing "glm::vec2" is directly included [misc-include-cleaner,-warnings-as-errors]

Shady/src/app/window.cpp

Lines 99 to 104 in 475cc00

Window::GetCursorScreenPosition(const glm::mat4& /*projectionMatrix*/)
{
auto cursorPos = GetCursor();
cursorPos -=
glm::vec2((static_cast< float >(m_width) / 2.0f), (static_cast< float >(m_height) / 2.0f));

!Line: 99 - error: no header providing "glm::mat4" is directly included [misc-include-cleaner,-warnings-as-errors]

Shady/src/app/window.cpp

Lines 104 to 109 in 475cc00

glm::vec2((static_cast< float >(m_width) / 2.0f), (static_cast< float >(m_height) / 2.0f));
// glm::vec2 tmpCursor = projectionMatrix * glm::vec4(cursorPos, 0.0f, 1.0f);
return cursorPos;
}

!Line: 104 - error: 2.0f is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,-warnings-as-errors]

Shady/src/app/window.cpp

Lines 104 to 109 in 475cc00

glm::vec2((static_cast< float >(m_width) / 2.0f), (static_cast< float >(m_height) / 2.0f));
// glm::vec2 tmpCursor = projectionMatrix * glm::vec4(cursorPos, 0.0f, 1.0f);
return cursorPos;
}

!Line: 104 - error: floating point literal has suffix 'f', which is not uppercase [hicpp-uppercase-literal-suffix,-warnings-as-errors]

Shady/src/app/window.cpp

Lines 115 to 120 in 475cc00

const glm::vec2 centerOfScreen(static_cast< float >(m_width) / 2.0f,
static_cast< float >(m_height) / 2.0f);
cursorPos -= centerOfScreen;
cursorPos /= centerOfScreen;

!Line: 115 - error: floating point literal has suffix 'f', which is not uppercase [hicpp-uppercase-literal-suffix,-warnings-as-errors]

Shady/src/app/window.cpp

Lines 116 to 121 in 475cc00

static_cast< float >(m_height) / 2.0f);
cursorPos -= centerOfScreen;
cursorPos /= centerOfScreen;
return cursorPos;

!Line: 116 - error: floating point literal has suffix 'f', which is not uppercase [hicpp-uppercase-literal-suffix,-warnings-as-errors]

Shady/src/app/window.cpp

Lines 127 to 132 in 475cc00

glm::dvec2 cursorPos;
glfwGetCursorPos(m_pWindow, &cursorPos.x, &cursorPos.y);
return cursorPos;
}

!Line: 127 - error: no header providing "glm::dvec2" is directly included [misc-include-cleaner,-warnings-as-errors]

Shady/src/app/window.cpp

Lines 133 to 138 in 475cc00

glm::ivec2
Window::GetSize() const
{
return {m_width, m_height};
}

!Line: 133 - error: no header providing "glm::ivec2" is directly included [misc-include-cleaner,-warnings-as-errors]

Assert(bool assertion, std::string_view logMsg)
{
if (!assertion)
{
trace::Logger::Fatal("{}", logMsg);
std::terminate();

!Line: 7 - error: no header providing "std::string_view" is directly included [misc-include-cleaner,-warnings-as-errors]

std::terminate();
}
}
} // namespace shady::utils

!Line: 12 - error: no header providing "std::terminate" is directly included [misc-include-cleaner,-warnings-as-errors]

#include "trace/logger.hpp"
#include <glm/gtc/matrix_transform.hpp>
namespace shady::scene {

!Line: 2 - error: included header logger.hpp is not used directly [misc-include-cleaner,-warnings-as-errors]

#include <glm/gtc/matrix_transform.hpp>
namespace shady::scene {
Light::Light(const glm::vec3& position, const glm::vec3& color, LightType type)
: position_(position), color_(color)

!Line: 4 - error: included header matrix_transform.hpp is not used directly [misc-include-cleaner,-warnings-as-errors]

Light::Light(const glm::vec3& position, const glm::vec3& color, LightType type)
: position_(position), color_(color)
{
// auto buffer_type = render::FrameBufferType::SINGLE;
switch (type)
{

!Line: 8 - error: no header providing "glm::vec3" is directly included [misc-include-cleaner,-warnings-as-errors]

projectionMatrix_ = glm::ortho(-200.0f, 200.0f, -200.0f, 200.0f, 1.0f, 500.0f);
// projectionMatrix_ = glm::perspective(70.0f, 16.0f / 9.0f, 0.1f, 500.0f);
}
break;
case LightType::POINT_LIGHT:

!Line: 15 - error: no header providing "glm::ortho" is directly included [misc-include-cleaner,-warnings-as-errors]

projectionMatrix_ = glm::ortho(-200.0f, 200.0f, -200.0f, 200.0f, 1.0f, 500.0f);
// projectionMatrix_ = glm::perspective(70.0f, 16.0f / 9.0f, 0.1f, 500.0f);
}
break;
case LightType::POINT_LIGHT:

!Line: 15 - error: 200.0f is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,-warnings-as-errors]

projectionMatrix_ = glm::ortho(-200.0f, 200.0f, -200.0f, 200.0f, 1.0f, 500.0f);
// projectionMatrix_ = glm::perspective(70.0f, 16.0f / 9.0f, 0.1f, 500.0f);
}
break;
case LightType::POINT_LIGHT:

!Line: 15 - error: floating point literal has suffix 'f', which is not uppercase [hicpp-uppercase-literal-suffix,-warnings-as-errors]

projectionMatrix_ = glm::ortho(-200.0f, 200.0f, -200.0f, 200.0f, 1.0f, 500.0f);
// projectionMatrix_ = glm::perspective(70.0f, 16.0f / 9.0f, 0.1f, 500.0f);
}
break;
case LightType::POINT_LIGHT:

!Line: 15 - error: 500.0f is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,-warnings-as-errors]

projectionMatrix_ = glm::perspective(60.0f, 1.0f, 0.1f, 100.0f);
// buffer_type = render::FrameBufferType::CUBE;
}
break;
}

!Line: 22 - error: no header providing "glm::perspective" is directly included [misc-include-cleaner,-warnings-as-errors]

projectionMatrix_ = glm::perspective(60.0f, 1.0f, 0.1f, 100.0f);
// buffer_type = render::FrameBufferType::CUBE;
}
break;
}

!Line: 22 - error: 60.0f is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,-warnings-as-errors]

projectionMatrix_ = glm::perspective(60.0f, 1.0f, 0.1f, 100.0f);
// buffer_type = render::FrameBufferType::CUBE;
}
break;
}

!Line: 22 - error: floating point literal has suffix 'f', which is not uppercase [hicpp-uppercase-literal-suffix,-warnings-as-errors]

projectionMatrix_ = glm::perspective(60.0f, 1.0f, 0.1f, 100.0f);
// buffer_type = render::FrameBufferType::CUBE;
}
break;
}

!Line: 22 - error: 0.1f is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,-warnings-as-errors]

biasMatrix_ = glm::translate(glm::mat4(1.0f), glm::vec3(0.5f))
* glm::scale(glm::mat4(1.0f), glm::vec3(0.5f));
lookAt_ = glm::vec3(0.0f, -1.0f, 0.0f);
upVec_ = glm::vec3(0.0f, 0.0f, 0.5f);
// m_shadowBuffer->MakeTextureResident();

!Line: 30 - error: no header providing "glm::translate" is directly included [misc-include-cleaner,-warnings-as-errors]

biasMatrix_ = glm::translate(glm::mat4(1.0f), glm::vec3(0.5f))
* glm::scale(glm::mat4(1.0f), glm::vec3(0.5f));
lookAt_ = glm::vec3(0.0f, -1.0f, 0.0f);
upVec_ = glm::vec3(0.0f, 0.0f, 0.5f);
// m_shadowBuffer->MakeTextureResident();

!Line: 30 - error: floating point literal has suffix 'f', which is not uppercase [hicpp-uppercase-literal-suffix,-warnings-as-errors]

biasMatrix_ = glm::translate(glm::mat4(1.0f), glm::vec3(0.5f))
* glm::scale(glm::mat4(1.0f), glm::vec3(0.5f));
lookAt_ = glm::vec3(0.0f, -1.0f, 0.0f);
upVec_ = glm::vec3(0.0f, 0.0f, 0.5f);
// m_shadowBuffer->MakeTextureResident();

!Line: 30 - error: 0.5f is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,-warnings-as-errors]

* glm::scale(glm::mat4(1.0f), glm::vec3(0.5f));
lookAt_ = glm::vec3(0.0f, -1.0f, 0.0f);
upVec_ = glm::vec3(0.0f, 0.0f, 0.5f);
// m_shadowBuffer->MakeTextureResident();
UpdateViewProjection();

!Line: 31 - error: no header providing "glm::scale" is directly included [misc-include-cleaner,-warnings-as-errors]

* glm::scale(glm::mat4(1.0f), glm::vec3(0.5f));
lookAt_ = glm::vec3(0.0f, -1.0f, 0.0f);
upVec_ = glm::vec3(0.0f, 0.0f, 0.5f);
// m_shadowBuffer->MakeTextureResident();
UpdateViewProjection();

!Line: 31 - error: floating point literal has suffix 'f', which is not uppercase [hicpp-uppercase-literal-suffix,-warnings-as-errors]

* glm::scale(glm::mat4(1.0f), glm::vec3(0.5f));
lookAt_ = glm::vec3(0.0f, -1.0f, 0.0f);
upVec_ = glm::vec3(0.0f, 0.0f, 0.5f);
// m_shadowBuffer->MakeTextureResident();
UpdateViewProjection();

!Line: 31 - error: 0.5f is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,-warnings-as-errors]

lookAt_ = glm::vec3(0.0f, -1.0f, 0.0f);
upVec_ = glm::vec3(0.0f, 0.0f, 0.5f);
// m_shadowBuffer->MakeTextureResident();
UpdateViewProjection();
}

!Line: 32 - error: floating point literal has suffix 'f', which is not uppercase [hicpp-uppercase-literal-suffix,-warnings-as-errors]

upVec_ = glm::vec3(0.0f, 0.0f, 0.5f);
// m_shadowBuffer->MakeTextureResident();
UpdateViewProjection();
}

!Line: 33 - error: floating point literal has suffix 'f', which is not uppercase [hicpp-uppercase-literal-suffix,-warnings-as-errors]

upVec_ = glm::vec3(0.0f, 0.0f, 0.5f);
// m_shadowBuffer->MakeTextureResident();
UpdateViewProjection();
}

!Line: 33 - error: 0.5f is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,-warnings-as-errors]

glm::tvec2< uint32_t >
Light::GetLightmapSize() const
{
return {shadowTextureWidth_, shadowTextureHeight_};
}

!Line: 75 - error: no header providing "glm::tvec2" is directly included [misc-include-cleaner,-warnings-as-errors]

glm::tvec2< uint32_t >
Light::GetLightmapSize() const
{
return {shadowTextureWidth_, shadowTextureHeight_};
}

!Line: 75 - error: no header providing "uint32_t" is directly included [misc-include-cleaner,-warnings-as-errors]

viewMatrix_ = glm::lookAt(position_, lookAt_, upVec_);
lightSpaceMatrix_ = projectionMatrix_ * viewMatrix_;
shadowMatrix_ = biasMatrix_ * lightSpaceMatrix_;
}
} // namespace shady::scene

!Line: 93 - error: no header providing "glm::lookAt" is directly included [misc-include-cleaner,-warnings-as-errors]

#include <fmt/format.h>
namespace shady::scene {
scene::Camera&

!Line: 7 - error: included header format.h is not used directly [misc-include-cleaner,-warnings-as-errors]

scene::Camera&
Scene::GetCamera()
{
return *m_camera;
}

!Line: 12 - error: no header providing "shady::scene::Camera" is directly included [misc-include-cleaner,-warnings-as-errors]

Scene::AddModel(const std::string& fileName, LoadFlags additionalFlags)
{
auto model = std::make_unique< Model >(fileName, additionalFlags);
m_models.push_back(std::move(model));
}

!Line: 19 - error: no header providing "std::string" is directly included [misc-include-cleaner,-warnings-as-errors]

Scene::AddModel(const std::string& fileName, LoadFlags additionalFlags)
{
auto model = std::make_unique< Model >(fileName, additionalFlags);
m_models.push_back(std::move(model));
}

!Line: 19 - error: no header providing "shady::scene::LoadFlags" is directly included [misc-include-cleaner,-warnings-as-errors]

auto model = std::make_unique< Model >(fileName, additionalFlags);
m_models.push_back(std::move(model));
}
Light&
Scene::GetLight()

!Line: 21 - error: no header providing "std::make_unique" is directly included [misc-include-cleaner,-warnings-as-errors]

auto model = std::make_unique< Model >(fileName, additionalFlags);
m_models.push_back(std::move(model));
}
Light&
Scene::GetLight()

!Line: 21 - error: no header providing "shady::scene::Model" is directly included [misc-include-cleaner,-warnings-as-errors]

m_models.push_back(std::move(model));
}
Light&
Scene::GetLight()
{

!Line: 22 - error: no header providing "std::move" is directly included [misc-include-cleaner,-warnings-as-errors]

Light&
Scene::GetLight()
{
return *m_light;
}

!Line: 25 - error: no header providing "shady::scene::Light" is directly included [misc-include-cleaner,-warnings-as-errors]

void Scene::Render(int32_t /*windowWidth*/, int32_t /*windowHeight*/)
{
render::Renderer::UpdateUniformBuffer(m_camera.get(), m_light.get());
render::Renderer::Draw();
}

!Line: 31 - error: no header providing "int32_t" is directly included [misc-include-cleaner,-warnings-as-errors]

m_models.back()->ScaleModel(glm::vec3(0.1f, 0.1f, 0.1f));
m_models.back()->Submit();
m_light =
std::make_unique< scene::Light >(glm::vec3(0.0f, 450.0f, 0.0f), glm::vec3(1.0f, 0.8f, 0.7f),
scene::LightType::DIRECTIONAL_LIGHT);

!Line: 45 - error: 0.1f is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,-warnings-as-errors]

m_models.back()->ScaleModel(glm::vec3(0.1f, 0.1f, 0.1f));
m_models.back()->Submit();
m_light =
std::make_unique< scene::Light >(glm::vec3(0.0f, 450.0f, 0.0f), glm::vec3(1.0f, 0.8f, 0.7f),
scene::LightType::DIRECTIONAL_LIGHT);

!Line: 45 - error: floating point literal has suffix 'f', which is not uppercase [hicpp-uppercase-literal-suffix,-warnings-as-errors]

std::make_unique< scene::Light >(glm::vec3(0.0f, 450.0f, 0.0f), glm::vec3(1.0f, 0.8f, 0.7f),
scene::LightType::DIRECTIONAL_LIGHT);
m_camera = std::make_unique< scene::PerspectiveCamera >(70.0f, 16.0f / 9.0f, 0.1f, 500.0f,
glm::vec3(0.0f, 20.0f, 0.0f));
}

!Line: 49 - error: floating point literal has suffix 'f', which is not uppercase [hicpp-uppercase-literal-suffix,-warnings-as-errors]

std::make_unique< scene::Light >(glm::vec3(0.0f, 450.0f, 0.0f), glm::vec3(1.0f, 0.8f, 0.7f),
scene::LightType::DIRECTIONAL_LIGHT);
m_camera = std::make_unique< scene::PerspectiveCamera >(70.0f, 16.0f / 9.0f, 0.1f, 500.0f,
glm::vec3(0.0f, 20.0f, 0.0f));
}

!Line: 49 - error: 450.0f is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,-warnings-as-errors]

std::make_unique< scene::Light >(glm::vec3(0.0f, 450.0f, 0.0f), glm::vec3(1.0f, 0.8f, 0.7f),
scene::LightType::DIRECTIONAL_LIGHT);
m_camera = std::make_unique< scene::PerspectiveCamera >(70.0f, 16.0f / 9.0f, 0.1f, 500.0f,
glm::vec3(0.0f, 20.0f, 0.0f));
}

!Line: 49 - error: 0.8f is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,-warnings-as-errors]

std::make_unique< scene::Light >(glm::vec3(0.0f, 450.0f, 0.0f), glm::vec3(1.0f, 0.8f, 0.7f),
scene::LightType::DIRECTIONAL_LIGHT);
m_camera = std::make_unique< scene::PerspectiveCamera >(70.0f, 16.0f / 9.0f, 0.1f, 500.0f,
glm::vec3(0.0f, 20.0f, 0.0f));
}

!Line: 49 - error: 0.7f is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,-warnings-as-errors]

scene::LightType::DIRECTIONAL_LIGHT);
m_camera = std::make_unique< scene::PerspectiveCamera >(70.0f, 16.0f / 9.0f, 0.1f, 500.0f,
glm::vec3(0.0f, 20.0f, 0.0f));
}

!Line: 50 - error: no header providing "shady::scene::LightType" is directly included [misc-include-cleaner,-warnings-as-errors]

m_camera = std::make_unique< scene::PerspectiveCamera >(70.0f, 16.0f / 9.0f, 0.1f, 500.0f,
glm::vec3(0.0f, 20.0f, 0.0f));
}
} // namespace shady::scene

!Line: 52 - error: 70.0f is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,-warnings-as-errors]

m_camera = std::make_unique< scene::PerspectiveCamera >(70.0f, 16.0f / 9.0f, 0.1f, 500.0f,
glm::vec3(0.0f, 20.0f, 0.0f));
}
} // namespace shady::scene

!Line: 52 - error: floating point literal has suffix 'f', which is not uppercase [hicpp-uppercase-literal-suffix,-warnings-as-errors]

m_camera = std::make_unique< scene::PerspectiveCamera >(70.0f, 16.0f / 9.0f, 0.1f, 500.0f,
glm::vec3(0.0f, 20.0f, 0.0f));
}
} // namespace shady::scene

!Line: 52 - error: 16.0f is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,-warnings-as-errors]

m_camera = std::make_unique< scene::PerspectiveCamera >(70.0f, 16.0f / 9.0f, 0.1f, 500.0f,
glm::vec3(0.0f, 20.0f, 0.0f));
}
} // namespace shady::scene

!Line: 52 - error: 9.0f is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,-warnings-as-errors]

m_camera = std::make_unique< scene::PerspectiveCamera >(70.0f, 16.0f / 9.0f, 0.1f, 500.0f,
glm::vec3(0.0f, 20.0f, 0.0f));
}
} // namespace shady::scene

!Line: 52 - error: 0.1f is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,-warnings-as-errors]

m_camera = std::make_unique< scene::PerspectiveCamera >(70.0f, 16.0f / 9.0f, 0.1f, 500.0f,
glm::vec3(0.0f, 20.0f, 0.0f));
}
} // namespace shady::scene

!Line: 52 - error: 500.0f is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,-warnings-as-errors]

glm::vec3(0.0f, 20.0f, 0.0f));
}
} // namespace shady::scene

!Line: 53 - error: floating point literal has suffix 'f', which is not uppercase [hicpp-uppercase-literal-suffix,-warnings-as-errors]

glm::vec3(0.0f, 20.0f, 0.0f));
}
} // namespace shady::scene

!Line: 53 - error: 20.0f is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,-warnings-as-errors]

#include <fmt/format.h>
namespace shady::render {
void
Buffer::Map(VkDeviceSize size)

!Line: 6 - error: included header format.h is not used directly [misc-include-cleaner,-warnings-as-errors]

Buffer::Map(VkDeviceSize size)
{
vkMapMemory(Data::vk_device, bufferMemory_, 0, size, 0, &mappedMemory_);
mapped_ = true;
}

!Line: 11 - error: no header providing "VkDeviceSize" is directly included [misc-include-cleaner,-warnings-as-errors]

vkMapMemory(Data::vk_device, bufferMemory_, 0, size, 0, &mappedMemory_);
mapped_ = true;
}
void
Buffer::Unmap()

!Line: 13 - error: no header providing "vkMapMemory" is directly included [misc-include-cleaner,-warnings-as-errors]

vkUnmapMemory(Data::vk_device, bufferMemory_);
mapped_ = false;
mappedMemory_ = nullptr;
}
}

!Line: 22 - error: no header providing "vkUnmapMemory" is directly included [misc-include-cleaner,-warnings-as-errors]

memcpy(mappedMemory_, data, bufferSize_);
}
void
Buffer::CopyDataWithStaging(void* data, size_t dataSize)
{

!Line: 32 - error: no header providing "memcpy" is directly included [misc-include-cleaner,-warnings-as-errors]

Buffer::CopyDataWithStaging(void* data, size_t dataSize)
{
VkBuffer stagingBuffer{};
VkDeviceMemory stagingBufferMemory{};
Buffer::CreateBuffer(dataSize, VK_BUFFER_USAGE_TRANSFER_SRC_BIT,
VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT | VK_MEMORY_PROPERTY_HOST_COHERENT_BIT,

!Line: 36 - error: no header providing "size_t" is directly included [misc-include-cleaner,-warnings-as-errors]

VkBuffer stagingBuffer{};
VkDeviceMemory stagingBufferMemory{};
Buffer::CreateBuffer(dataSize, VK_BUFFER_USAGE_TRANSFER_SRC_BIT,
VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT | VK_MEMORY_PROPERTY_HOST_COHERENT_BIT,
stagingBuffer, stagingBufferMemory);

!Line: 38 - error: no header providing "VkBuffer" is directly included [misc-include-cleaner,-warnings-as-errors]

VkDeviceMemory stagingBufferMemory{};
Buffer::CreateBuffer(dataSize, VK_BUFFER_USAGE_TRANSFER_SRC_BIT,
VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT | VK_MEMORY_PROPERTY_HOST_COHERENT_BIT,
stagingBuffer, stagingBufferMemory);
void* mapped_data{};

!Line: 39 - error: no header providing "VkDeviceMemory" is directly included [misc-include-cleaner,-warnings-as-errors]

Buffer::CreateBuffer(dataSize, VK_BUFFER_USAGE_TRANSFER_SRC_BIT,
VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT | VK_MEMORY_PROPERTY_HOST_COHERENT_BIT,
stagingBuffer, stagingBufferMemory);
void* mapped_data{};
vkMapMemory(Data::vk_device, stagingBufferMemory, 0, dataSize, 0, &mapped_data);

!Line: 40 - error: no header providing "VK_BUFFER_USAGE_TRANSFER_SRC_BIT" is directly included [misc-include-cleaner,-warnings-as-errors]

VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT | VK_MEMORY_PROPERTY_HOST_COHERENT_BIT,
stagingBuffer, stagingBufferMemory);
void* mapped_data{};
vkMapMemory(Data::vk_device, stagingBufferMemory, 0, dataSize, 0, &mapped_data);
memcpy(mapped_data, data, dataSize);

!Line: 41 - error: no header providing "VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT" is directly included [misc-include-cleaner,-warnings-as-errors]

VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT | VK_MEMORY_PROPERTY_HOST_COHERENT_BIT,
stagingBuffer, stagingBufferMemory);
void* mapped_data{};
vkMapMemory(Data::vk_device, stagingBufferMemory, 0, dataSize, 0, &mapped_data);
memcpy(mapped_data, data, dataSize);

!Line: 41 - error: no header providing "VK_MEMORY_PROPERTY_HOST_COHERENT_BIT" is directly included [misc-include-cleaner,-warnings-as-errors]

Buffer::CopyDataToImageWithStaging(VkImage image, void* data, size_t dataSize,
const std::vector< VkBufferImageCopy >& copyRegions)
{
VkBuffer stagingBuffer{};
VkDeviceMemory stagingBufferMemory{};
Buffer::CreateBuffer(dataSize, VK_BUFFER_USAGE_TRANSFER_SRC_BIT,

!Line: 53 - error: no header providing "VkImage" is directly included [misc-include-cleaner,-warnings-as-errors]

const std::vector< VkBufferImageCopy >& copyRegions)
{
VkBuffer stagingBuffer{};
VkDeviceMemory stagingBufferMemory{};
Buffer::CreateBuffer(dataSize, VK_BUFFER_USAGE_TRANSFER_SRC_BIT,
VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT | VK_MEMORY_PROPERTY_HOST_COHERENT_BIT,

!Line: 54 - error: no header providing "std::vector" is directly included [misc-include-cleaner,-warnings-as-errors]

const std::vector< VkBufferImageCopy >& copyRegions)
{
VkBuffer stagingBuffer{};
VkDeviceMemory stagingBufferMemory{};
Buffer::CreateBuffer(dataSize, VK_BUFFER_USAGE_TRANSFER_SRC_BIT,
VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT | VK_MEMORY_PROPERTY_HOST_COHERENT_BIT,

!Line: 54 - error: no header providing "VkBufferImageCopy" is directly included [misc-include-cleaner,-warnings-as-errors]

VkCommandBuffer commandBuffer = Command::BeginSingleTimeCommands();
vkCmdCopyBufferToImage(commandBuffer, stagingBuffer, image, VK_IMAGE_LAYOUT_TRANSFER_DST_OPTIMAL,
static_cast< uint32_t >(copyRegions.size()), copyRegions.data());
Command::EndSingleTimeCommands(commandBuffer);

!Line: 67 - error: no header providing "VkCommandBuffer" is directly included [misc-include-cleaner,-warnings-as-errors]

vkCmdCopyBufferToImage(commandBuffer, stagingBuffer, image, VK_IMAGE_LAYOUT_TRANSFER_DST_OPTIMAL,
static_cast< uint32_t >(copyRegions.size()), copyRegions.data());
Command::EndSingleTimeCommands(commandBuffer);
vkDestroyBuffer(Data::vk_device, stagingBuffer, nullptr);

!Line: 69 - error: no header providing "vkCmdCopyBufferToImage" is directly included [misc-include-cleaner,-warnings-as-errors]

vkCmdCopyBufferToImage(commandBuffer, stagingBuffer, image, VK_IMAGE_LAYOUT_TRANSFER_DST_OPTIMAL,
static_cast< uint32_t >(copyRegions.size()), copyRegions.data());
Command::EndSingleTimeCommands(commandBuffer);
vkDestroyBuffer(Data::vk_device, stagingBuffer, nullptr);

!Line: 69 - error: no header providing "VK_IMAGE_LAYOUT_TRANSFER_DST_OPTIMAL" is directly included [misc-include-cleaner,-warnings-as-errors]

static_cast< uint32_t >(copyRegions.size()), copyRegions.data());
Command::EndSingleTimeCommands(commandBuffer);
vkDestroyBuffer(Data::vk_device, stagingBuffer, nullptr);
vkFreeMemory(Data::vk_device, stagingBufferMemory, nullptr);

!Line: 70 - error: no header providing "uint32_t" is directly included [misc-include-cleaner,-warnings-as-errors]

vkDestroyBuffer(Data::vk_device, stagingBuffer, nullptr);
vkFreeMemory(Data::vk_device, stagingBufferMemory, nullptr);
}
void
Buffer::SetupDescriptor(VkDeviceSize /*size*/, VkDeviceSize offset)

!Line: 74 - error: no header providing "vkDestroyBuffer" is directly included [misc-include-cleaner,-warnings-as-errors]

vkFreeMemory(Data::vk_device, stagingBufferMemory, nullptr);
}
void
Buffer::SetupDescriptor(VkDeviceSize /*size*/, VkDeviceSize offset)
{

!Line: 75 - error: no header providing "vkFreeMemory" is directly included [misc-include-cleaner,-warnings-as-errors]

AllocateMemory(VkMemoryRequirements memReq, VkDeviceMemory& bufferMemory,
VkMemoryPropertyFlags properties)
{
VkMemoryAllocateInfo allocInfo{};
allocInfo.sType = VK_STRUCTURE_TYPE_MEMORY_ALLOCATE_INFO;
allocInfo.allocationSize = memReq.size;

!Line: 87 - error: no header providing "VkMemoryRequirements" is directly included [misc-include-cleaner,-warnings-as-errors]

VkMemoryPropertyFlags properties)
{
VkMemoryAllocateInfo allocInfo{};
allocInfo.sType = VK_STRUCTURE_TYPE_MEMORY_ALLOCATE_INFO;
allocInfo.allocationSize = memReq.size;
allocInfo.memoryTypeIndex = FindMemoryType(memReq.memoryTypeBits, properties);

!Line: 88 - error: no header providing "VkMemoryPropertyFlags" is directly included [misc-include-cleaner,-warnings-as-errors]

VkMemoryAllocateInfo allocInfo{};
allocInfo.sType = VK_STRUCTURE_TYPE_MEMORY_ALLOCATE_INFO;
allocInfo.allocationSize = memReq.size;
allocInfo.memoryTypeIndex = FindMemoryType(memReq.memoryTypeBits, properties);
VK_CHECK(vkAllocateMemory(Data::vk_device, &allocInfo, nullptr, &bufferMemory),

!Line: 90 - error: no header providing "VkMemoryAllocateInfo" is directly included [misc-include-cleaner,-warnings-as-errors]

allocInfo.sType = VK_STRUCTURE_TYPE_MEMORY_ALLOCATE_INFO;
allocInfo.allocationSize = memReq.size;
allocInfo.memoryTypeIndex = FindMemoryType(memReq.memoryTypeBits, properties);
VK_CHECK(vkAllocateMemory(Data::vk_device, &allocInfo, nullptr, &bufferMemory),
"failed to allocate buffer memory!");

!Line: 91 - error: no header providing "VK_STRUCTURE_TYPE_MEMORY_ALLOCATE_INFO" is directly included [misc-include-cleaner,-warnings-as-errors]

VK_CHECK(vkAllocateMemory(Data::vk_device, &allocInfo, nullptr, &bufferMemory),
"failed to allocate buffer memory!");
}
void
Buffer::AllocateImageMemory(VkImage image, VkDeviceMemory& bufferMemory,

!Line: 95 - error: no header providing "vkAllocateMemory" is directly included [misc-include-cleaner,-warnings-as-errors]

Shady/src/render/buffer.cpp

Lines 104 to 109 in 475cc00

vkGetImageMemoryRequirements(Data::vk_device, image, &memRequirements);
AllocateMemory(memRequirements, bufferMemory, properties);
}
void

!Line: 104 - error: no header providing "vkGetImageMemoryRequirements" is directly included [misc-include-cleaner,-warnings-as-errors]

Shady/src/render/buffer.cpp

Lines 114 to 119 in 475cc00

vkGetBufferMemoryRequirements(Data::vk_device, buffer, &memRequirements);
AllocateMemory(memRequirements, bufferMemory, properties);
}
Buffer

!Line: 114 - error: no header providing "vkGetBufferMemoryRequirements" is directly included [misc-include-cleaner,-warnings-as-errors]

Shady/src/render/buffer.cpp

Lines 120 to 125 in 475cc00

Buffer::CreateBuffer(VkDeviceSize size, VkBufferUsageFlags usage, VkMemoryPropertyFlags properties)
{
Buffer newBuffer;
newBuffer.bufferSize_ = size;
CreateBuffer(size, usage, properties, newBuffer.buffer_, newBuffer.bufferMemory_);
newBuffer.SetupDescriptor();

!Line: 120 - error: no header providing "VkBufferUsageFlags" is directly included [misc-include-cleaner,-warnings-as-errors]

Shady/src/render/buffer.cpp

Lines 134 to 139 in 475cc00

VkBufferCreateInfo bufferInfo{};
bufferInfo.sType = VK_STRUCTURE_TYPE_BUFFER_CREATE_INFO;
bufferInfo.size = size;
bufferInfo.usage = usage;
bufferInfo.sharingMode = VK_SHARING_MODE_EXCLUSIVE;

!Line: 134 - error: no header providing "VkBufferCreateInfo" is directly included [misc-include-cleaner,-warnings-as-errors]

Shady/src/render/buffer.cpp

Lines 135 to 140 in 475cc00

bufferInfo.sType = VK_STRUCTURE_TYPE_BUFFER_CREATE_INFO;
bufferInfo.size = size;
bufferInfo.usage = usage;
bufferInfo.sharingMode = VK_SHARING_MODE_EXCLUSIVE;
VK_CHECK(vkCreateBuffer(Data::vk_device, &bufferInfo, nullptr, &buffer),

!Line: 135 - error: no header providing "VK_STRUCTURE_TYPE_BUFFER_CREATE_INFO" is directly included [misc-include-cleaner,-warnings-as-errors]

Shady/src/render/buffer.cpp

Lines 138 to 143 in 475cc00

bufferInfo.sharingMode = VK_SHARING_MODE_EXCLUSIVE;
VK_CHECK(vkCreateBuffer(Data::vk_device, &bufferInfo, nullptr, &buffer),
"failed to create buffer!");
AllocateBufferMemory(buffer, bufferMemory, properties);

!Line: 138 - error: no header providing "VK_SHARING_MODE_EXCLUSIVE" is directly included [misc-include-cleaner,-warnings-as-errors]

Shady/src/render/buffer.cpp

Lines 140 to 145 in 475cc00

VK_CHECK(vkCreateBuffer(Data::vk_device, &bufferInfo, nullptr, &buffer),
"failed to create buffer!");
AllocateBufferMemory(buffer, bufferMemory, properties);
vkBindBufferMemory(Data::vk_device, buffer, bufferMemory, 0);

!Line: 140 - error: no header providing "vkCreateBuffer" is directly included [misc-include-cleaner,-warnings-as-errors]

Shady/src/render/buffer.cpp

Lines 145 to 150 in 475cc00

vkBindBufferMemory(Data::vk_device, buffer, bufferMemory, 0);
}
void
Buffer::CopyBuffer(VkBuffer srcBuffer, VkBuffer dstBuffer, VkDeviceSize size)
{

!Line: 145 - error: no header providing "vkBindBufferMemory" is directly included [misc-include-cleaner,-warnings-as-errors]

Shady/src/render/buffer.cpp

Lines 153 to 158 in 475cc00

VkBufferCopy copyRegion{};
copyRegion.size = size;
vkCmdCopyBuffer(commandBuffer, srcBuffer, dstBuffer, 1, &copyRegion);
Command::EndSingleTimeCommands(commandBuffer);
}

!Line: 153 - error: no header providing "VkBufferCopy" is directly included [misc-include-cleaner,-warnings-as-errors]

Shady/src/render/buffer.cpp

Lines 155 to 160 in 475cc00

vkCmdCopyBuffer(commandBuffer, srcBuffer, dstBuffer, 1, &copyRegion);
Command::EndSingleTimeCommands(commandBuffer);
}
void

!Line: 155 - error: no header providing "vkCmdCopyBuffer" is directly included [misc-include-cleaner,-warnings-as-errors]

Shady/src/render/buffer.cpp

Lines 163 to 168 in 475cc00

VkMappedMemoryRange mappedRange = {};
mappedRange.sType = VK_STRUCTURE_TYPE_MAPPED_MEMORY_RANGE;
mappedRange.memory = bufferMemory_;
mappedRange.offset = offset;
mappedRange.size = size;

!Line: 163 - error: no header providing "VkMappedMemoryRange" is directly included [misc-include-cleaner,-warnings-as-errors]

Shady/src/render/buffer.cpp

Lines 164 to 169 in 475cc00

mappedRange.sType = VK_STRUCTURE_TYPE_MAPPED_MEMORY_RANGE;
mappedRange.memory = bufferMemory_;
mappedRange.offset = offset;
mappedRange.size = size;
VK_CHECK(vkFlushMappedMemoryRanges(Data::vk_device, 1, &mappedRange), "Buffer::Flush error!");

!Line: 164 - error: no header providing "VK_STRUCTURE_TYPE_MAPPED_MEMORY_RANGE" is directly included [misc-include-cleaner,-warnings-as-errors]

Shady/src/render/buffer.cpp

Lines 169 to 174 in 475cc00

VK_CHECK(vkFlushMappedMemoryRanges(Data::vk_device, 1, &mappedRange), "Buffer::Flush error!");
}
void
Buffer::Destroy()
{

!Line: 169 - error: no header providing "vkFlushMappedMemoryRanges" is directly included [misc-include-cleaner,-warnings-as-errors]

#include "renderer.hpp"
#include "scene/scene.hpp"
#include "shader.hpp"
#include "texture.hpp"
#include "utils/file_manager.hpp"

!Line: 5 - error: included header renderer.hpp is not used directly [misc-include-cleaner,-warnings-as-errors]

#include <fmt/format.h>
#include <imgui.h>
#include <array>
namespace shady::app::gui {

!Line: 12 - error: included header format.h is not used directly [misc-include-cleaner,-warnings-as-errors]

SetStyle()
{
ImGuiStyle& style = ImGui::GetStyle();
auto* colors = &style.Colors[0];
/// 0 = FLAT APPEARENCE

!Line: 21 - error: function 'SetStyle' declared 'static', move to anonymous namespace instead [misc-use-anonymous-namespace,-warnings-as-errors]

colors[ImGuiCol_Text] = ImVec4(1.00f, 1.00f, 1.00f, 1.00f);
colors[ImGuiCol_TextDisabled] = ImVec4(0.40f, 0.40f, 0.40f, 1.00f);
colors[ImGuiCol_ChildBg] = ImVec4(1.25f, 0.25f, 0.25f, 1.00f);
colors[ImGuiCol_WindowBg] = ImVec4(0.025f, 0.025f, 0.025f, 1.00f);
colors[ImGuiCol_PopupBg] = ImVec4(0.25f, 0.25f, 0.25f, 1.00f);
colors[ImGuiCol_Border] = ImVec4(0.12f, 0.12f, 0.12f, 0.71f);

!Line: 30 - error: do not use pointer arithmetic [cppcoreguidelines-pro-bounds-pointer-arithmetic,-warnings-as-errors]

colors[ImGuiCol_Text] = ImVec4(1.00f, 1.00f, 1.00f, 1.00f);
colors[ImGuiCol_TextDisabled] = ImVec4(0.40f, 0.40f, 0.40f, 1.00f);
colors[ImGuiCol_ChildBg] = ImVec4(1.25f, 0.25f, 0.25f, 1.00f);
colors[ImGuiCol_WindowBg] = ImVec4(0.025f, 0.025f, 0.025f, 1.00f);
colors[ImGuiCol_PopupBg] = ImVec4(0.25f, 0.25f, 0.25f, 1.00f);
colors[ImGuiCol_Border] = ImVec4(0.12f, 0.12f, 0.12f, 0.71f);

!Line: 30 - error: floating point literal has suffix 'f', which is not uppercase [hicpp-uppercase-literal-suffix,-warnings-as-errors]

colors[ImGuiCol_TextDisabled] = ImVec4(0.40f, 0.40f, 0.40f, 1.00f);
colors[ImGuiCol_ChildBg] = ImVec4(1.25f, 0.25f, 0.25f, 1.00f);
colors[ImGuiCol_WindowBg] = ImVec4(0.025f, 0.025f, 0.025f, 1.00f);
colors[ImGuiCol_PopupBg] = ImVec4(0.25f, 0.25f, 0.25f, 1.00f);
colors[ImGuiCol_Border] = ImVec4(0.12f, 0.12f, 0.12f, 0.71f);
colors[ImGuiCol_BorderShadow] = ImVec4(1.00f, 1.00f, 1.00f, 0.06f);

!Line: 31 - error: do not use pointer arithmetic [cppcoreguidelines-pro-bounds-pointer-arithmetic,-warnings-as-errors]

colors[ImGuiCol_TextDisabled] = ImVec4(0.40f, 0.40f, 0.40f, 1.00f);
colors[ImGuiCol_ChildBg] = ImVec4(1.25f, 0.25f, 0.25f, 1.00f);
colors[ImGuiCol_WindowBg] = ImVec4(0.025f, 0.025f, 0.025f, 1.00f);
colors[ImGuiCol_PopupBg] = ImVec4(0.25f, 0.25f, 0.25f, 1.00f);
colors[ImGuiCol_Border] = ImVec4(0.12f, 0.12f, 0.12f, 0.71f);
colors[ImGuiCol_BorderShadow] = ImVec4(1.00f, 1.00f, 1.00f, 0.06f);

!Line: 31 - error: 0.40f is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,-warnings-as-errors]

colors[ImGuiCol_TextDisabled] = ImVec4(0.40f, 0.40f, 0.40f, 1.00f);
colors[ImGuiCol_ChildBg] = ImVec4(1.25f, 0.25f, 0.25f, 1.00f);
colors[ImGuiCol_WindowBg] = ImVec4(0.025f, 0.025f, 0.025f, 1.00f);
colors[ImGuiCol_PopupBg] = ImVec4(0.25f, 0.25f, 0.25f, 1.00f);
colors[ImGuiCol_Border] = ImVec4(0.12f, 0.12f, 0.12f, 0.71f);
colors[ImGuiCol_BorderShadow] = ImVec4(1.00f, 1.00f, 1.00f, 0.06f);

!Line: 31 - error: floating point literal has suffix 'f', which is not uppercase [hicpp-uppercase-literal-suffix,-warnings-as-errors]

colors[ImGuiCol_ChildBg] = ImVec4(1.25f, 0.25f, 0.25f, 1.00f);
colors[ImGuiCol_WindowBg] = ImVec4(0.025f, 0.025f, 0.025f, 1.00f);
colors[ImGuiCol_PopupBg] = ImVec4(0.25f, 0.25f, 0.25f, 1.00f);
colors[ImGuiCol_Border] = ImVec4(0.12f, 0.12f, 0.12f, 0.71f);
colors[ImGuiCol_BorderShadow] = ImVec4(1.00f, 1.00f, 1.00f, 0.06f);
colors[ImGuiCol_FrameBg] = ImVec4(0.02f, 0.02f, 0.02f, 0.54f);

!Line: 32 - error: do not use pointer arithmetic [cppcoreguidelines-pro-bounds-pointer-arithmetic,-warnings-as-errors]

colors[ImGuiCol_ChildBg] = ImVec4(1.25f, 0.25f, 0.25f, 1.00f);
colors[ImGuiCol_WindowBg] = ImVec4(0.025f, 0.025f, 0.025f, 1.00f);
colors[ImGuiCol_PopupBg] = ImVec4(0.25f, 0.25f, 0.25f, 1.00f);
colors[ImGuiCol_Border] = ImVec4(0.12f, 0.12f, 0.12f, 0.71f);
colors[ImGuiCol_BorderShadow] = ImVec4(1.00f, 1.00f, 1.00f, 0.06f);
colors[ImGuiCol_FrameBg] = ImVec4(0.02f, 0.02f, 0.02f, 0.54f);

!Line: 32 - error: 1.25f is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,-warnings-as-errors]

colors[ImGuiCol_ChildBg] = ImVec4(1.25f, 0.25f, 0.25f, 1.00f);
colors[ImGuiCol_WindowBg] = ImVec4(0.025f, 0.025f, 0.025f, 1.00f);
colors[ImGuiCol_PopupBg] = ImVec4(0.25f, 0.25f, 0.25f, 1.00f);
colors[ImGuiCol_Border] = ImVec4(0.12f, 0.12f, 0.12f, 0.71f);
colors[ImGuiCol_BorderShadow] = ImVec4(1.00f, 1.00f, 1.00f, 0.06f);
colors[ImGuiCol_FrameBg] = ImVec4(0.02f, 0.02f, 0.02f, 0.54f);

!Line: 32 - error: floating point literal has suffix 'f', which is not uppercase [hicpp-uppercase-literal-suffix,-warnings-as-errors]

colors[ImGuiCol_ChildBg] = ImVec4(1.25f, 0.25f, 0.25f, 1.00f);
colors[ImGuiCol_WindowBg] = ImVec4(0.025f, 0.025f, 0.025f, 1.00f);
colors[ImGuiCol_PopupBg] = ImVec4(0.25f, 0.25f, 0.25f, 1.00f);
colors[ImGuiCol_Border] = ImVec4(0.12f, 0.12f, 0.12f, 0.71f);
colors[ImGuiCol_BorderShadow] = ImVec4(1.00f, 1.00f, 1.00f, 0.06f);
colors[ImGuiCol_FrameBg] = ImVec4(0.02f, 0.02f, 0.02f, 0.54f);

!Line: 32 - error: 0.25f is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,-warnings-as-errors]

colors[ImGuiCol_WindowBg] = ImVec4(0.025f, 0.025f, 0.025f, 1.00f);
colors[ImGuiCol_PopupBg] = ImVec4(0.25f, 0.25f, 0.25f, 1.00f);
colors[ImGuiCol_Border] = ImVec4(0.12f, 0.12f, 0.12f, 0.71f);
colors[ImGuiCol_BorderShadow] = ImVec4(1.00f, 1.00f, 1.00f, 0.06f);
colors[ImGuiCol_FrameBg] = ImVec4(0.02f, 0.02f, 0.02f, 0.54f);
colors[ImGuiCol_FrameBgHovered] = ImVec4(0.42f, 0.42f, 0.42f, 0.40f);

!Line: 33 - error: do not use pointer arithmetic [cppcoreguidelines-pro-bounds-pointer-arithmetic,-warnings-as-errors]

colors[ImGuiCol_WindowBg] = ImVec4(0.025f, 0.025f, 0.025f, 1.00f);
colors[ImGuiCol_PopupBg] = ImVec4(0.25f, 0.25f, 0.25f, 1.00f);
colors[ImGuiCol_Border] = ImVec4(0.12f, 0.12f, 0.12f, 0.71f);
colors[ImGuiCol_BorderShadow] = ImVec4(1.00f, 1.00f, 1.00f, 0.06f);
colors[ImGuiCol_FrameBg] = ImVec4(0.02f, 0.02f, 0.02f, 0.54f);
colors[ImGuiCol_FrameBgHovered] = ImVec4(0.42f, 0.42f, 0.42f, 0.40f);

!Line: 33 - error: 0.025f is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,-warnings-as-errors]

colors[ImGuiCol_WindowBg] = ImVec4(0.025f, 0.025f, 0.025f, 1.00f);
colors[ImGuiCol_PopupBg] = ImVec4(0.25f, 0.25f, 0.25f, 1.00f);
colors[ImGuiCol_Border] = ImVec4(0.12f, 0.12f, 0.12f, 0.71f);
colors[ImGuiCol_BorderShadow] = ImVec4(1.00f, 1.00f, 1.00f, 0.06f);
colors[ImGuiCol_FrameBg] = ImVec4(0.02f, 0.02f, 0.02f, 0.54f);
colors[ImGuiCol_FrameBgHovered] = ImVec4(0.42f, 0.42f, 0.42f, 0.40f);

!Line: 33 - error: floating point literal has suffix 'f', which is not uppercase [hicpp-uppercase-literal-suffix,-warnings-as-errors]

colors[ImGuiCol_PopupBg] = ImVec4(0.25f, 0.25f, 0.25f, 1.00f);
colors[ImGuiCol_Border] = ImVec4(0.12f, 0.12f, 0.12f, 0.71f);
colors[ImGuiCol_BorderShadow] = ImVec4(1.00f, 1.00f, 1.00f, 0.06f);
colors[ImGuiCol_FrameBg] = ImVec4(0.02f, 0.02f, 0.02f, 0.54f);
colors[ImGuiCol_FrameBgHovered] = ImVec4(0.42f, 0.42f, 0.42f, 0.40f);
colors[ImGuiCol_FrameBgActive] = ImVec4(0.56f, 0.56f, 0.56f, 0.67f);

!Line: 34 - error: do not use pointer arithmetic [cppcoreguidelines-pro-bounds-pointer-arithmetic,-warnings-as-errors]

colors[ImGuiCol_PopupBg] = ImVec4(0.25f, 0.25f, 0.25f, 1.00f);
colors[ImGuiCol_Border] = ImVec4(0.12f, 0.12f, 0.12f, 0.71f);
colors[ImGuiCol_BorderShadow] = ImVec4(1.00f, 1.00f, 1.00f, 0.06f);
colors[ImGuiCol_FrameBg] = ImVec4(0.02f, 0.02f, 0.02f, 0.54f);
colors[ImGuiCol_FrameBgHovered] = ImVec4(0.42f, 0.42f, 0.42f, 0.40f);
colors[ImGuiCol_FrameBgActive] = ImVec4(0.56f, 0.56f, 0.56f, 0.67f);

!Line: 34 - error: 0.25f is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,-warnings-as-errors]

colors[ImGuiCol_PopupBg] = ImVec4(0.25f, 0.25f, 0.25f, 1.00f);
colors[ImGuiCol_Border] = ImVec4(0.12f, 0.12f, 0.12f, 0.71f);
colors[ImGuiCol_BorderShadow] = ImVec4(1.00f, 1.00f, 1.00f, 0.06f);
colors[ImGuiCol_FrameBg] = ImVec4(0.02f, 0.02f, 0.02f, 0.54f);
colors[ImGuiCol_FrameBgHovered] = ImVec4(0.42f, 0.42f, 0.42f, 0.40f);
colors[ImGuiCol_FrameBgActive] = ImVec4(0.56f, 0.56f, 0.56f, 0.67f);

!Line: 34 - error: floating point literal has suffix 'f', which is not uppercase [hicpp-uppercase-literal-suffix,-warnings-as-errors]

colors[ImGuiCol_Border] = ImVec4(0.12f, 0.12f, 0.12f, 0.71f);
colors[ImGuiCol_BorderShadow] = ImVec4(1.00f, 1.00f, 1.00f, 0.06f);
colors[ImGuiCol_FrameBg] = ImVec4(0.02f, 0.02f, 0.02f, 0.54f);
colors[ImGuiCol_FrameBgHovered] = ImVec4(0.42f, 0.42f, 0.42f, 0.40f);
colors[ImGuiCol_FrameBgActive] = ImVec4(0.56f, 0.56f, 0.56f, 0.67f);
colors[ImGuiCol_TitleBg] = ImVec4(0.02f, 0.02f, 0.02f, 1.00f);

!Line: 35 - error: do not use pointer arithmetic [cppcoreguidelines-pro-bounds-pointer-arithmetic,-warnings-as-errors]

colors[ImGuiCol_Border] = ImVec4(0.12f, 0.12f, 0.12f, 0.71f);
colors[ImGuiCol_BorderShadow] = ImVec4(1.00f, 1.00f, 1.00f, 0.06f);
colors[ImGuiCol_FrameBg] = ImVec4(0.02f, 0.02f, 0.02f, 0.54f);
colors[ImGuiCol_FrameBgHovered] = ImVec4(0.42f, 0.42f, 0.42f, 0.40f);
colors[ImGuiCol_FrameBgActive] = ImVec4(0.56f, 0.56f, 0.56f, 0.67f);
colors[ImGuiCol_TitleBg] = ImVec4(0.02f, 0.02f, 0.02f, 1.00f);

!Line: 35 - error: 0.12f is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,-warnings-as-errors]

colors[ImGuiCol_Border] = ImVec4(0.12f, 0.12f, 0.12f, 0.71f);
colors[ImGuiCol_BorderShadow] = ImVec4(1.00f, 1.00f, 1.00f, 0.06f);
colors[ImGuiCol_FrameBg] = ImVec4(0.02f, 0.02f, 0.02f, 0.54f);
colors[ImGuiCol_FrameBgHovered] = ImVec4(0.42f, 0.42f, 0.42f, 0.40f);
colors[ImGuiCol_FrameBgActive] = ImVec4(0.56f, 0.56f, 0.56f, 0.67f);
colors[ImGuiCol_TitleBg] = ImVec4(0.02f, 0.02f, 0.02f, 1.00f);

!Line: 35 - error: floating point literal has suffix 'f', which is not uppercase [hicpp-uppercase-literal-suffix,-warnings-as-errors]


!Maximum character count per GitHub comment has been reached! Not all warnings/errors has been parsed!

@JacobDomagala JacobDomagala merged commit 861dc12 into master Apr 25, 2024
2 of 3 checks passed
@JacobDomagala JacobDomagala deleted the 117-update-readme branch April 25, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update README
1 participant