Update Card+ImageUris.swift #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed artCrop and borderCrop not decoding properly by removing custom CodingKeys. The JSON decoder used in the networking client already converts from snakeCase when decoding the API response; these coding keys were inadvertently causing a coding key mis-match. JSON decoder as set up in `NetworkService.swift`, lines 75 & 76: ```swift let decoder = JSONDecoder() decoder.keyDecodingStrategy = .convertFromSnakeCase ```
JacobHearst
approved these changes
May 14, 2024
|
Thanks for the contribution! |
|
My pleasure! Thank you for all your hard work on this project! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #21
Fixed artCrop and borderCrop not decoding properly by removing custom CodingKeys. The JSON decoder used in the networking client already converts from snakeCase when decoding the API response; these coding keys were inadvertently causing a coding key mis-match.
JSON decoder as set up in
NetworkService.swift, lines 75 & 76:A quick test with the local changes (removing the custom coding keys) has solved the issue in my test app.