Sync Forked Repo With Main Repo #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-function is used
JacobYiu
pushed a commit
that referenced
this pull request
Apr 15, 2024
Previously, esbmc would try to parse fields of forward declarations. Consider this code: ```cpp class a; // #1 class b; // #2 class a { // #3 b *c; }; class b : a {}; // #4 ``` When parsing #1, clang would resolve the actual definition for us. This means that we would skip ahead to #3 and try to parse the fields of `a`. When doing this, we will encounter `b` and try to get a type for it. This will ultimately fail, because we are still defining `a`, but `b` extends `a` and so `a` must be a _complete_ type which it is not at that point. We can avoid this problem by _not_ continuing to parse fields if the declaration is not a complete one. When now parsing #1, we would not skip ahead to #3 anymore. Similarly, when parsing #2, we would not skip ahead to #4 anymore. There is still a slight problem: when parsing #3 we would however still have a problem. We would try to get a type for `b` again, which would then fail again, because `a` is not yet complete. This problem is easily solved, by not recording structs in the context if we already have a symbol there for it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.