-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use of system class loader in ClassFinder #42
Comments
Hi, |
Hi, Of course, I will test it! Thanks, |
Hi, Thanks, Andy |
Hi Andy, Ok, thanks, I will test it asap. Cheers,
|
Hi Andy, I have just tested it and it does not work unfortunately: it is my mistake in fact. The issue is not the reported one but it comes from the fact that packages scanning is done before initializing the Spring context. As it is done before, classes are loaded with a class loader which has not been yet instrumented. So in
by
and
by
I am really sorry for that mistake. Cheers, |
Hi, Andy
|
Hi Andy, Can I ask you if you got any chance to perform the change? Thanks in advance for your answer! Best regards, |
Hi, sorry I am still at J1. I’ll try to make either today at the hackergarden or in the airplane tomorrow. Andy
|
Hi, |
Fixed by 2.1-RC4. Thank you very much! Cheers, |
Hello !
First of all, a big thank for your work and framework that is very useful for us!
I have recently tried to plug Load Time Weaving (LTW) in our application using Spring and AspectJ and I faced an issue: my aspect was not weaved.
It was due to the fact that the ClassFinder loads classes in base packages using the system class loader (see
org.jacpfx.rcp.util.ClassFinder.loadClass(String)
). Indeed, to be weaved, the class must be loaded thanks to the Springorg.springframework.core.OverridingClassLoader
which does not always delegate to the parent class loader.So, I think that
should be replaced by
Current workaround consists in locating the aspect outside of the JacpFX base packages.
Many thanks in advance,
Cheers,
Jean.
The text was updated successfully, but these errors were encountered: