Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ResourceBundle injection in FXPerspective #45

Closed
jlepropre opened this issue Oct 29, 2015 · 4 comments
Closed

ResourceBundle injection in FXPerspective #45

jlepropre opened this issue Oct 29, 2015 · 4 comments

Comments

@jlepropre
Copy link

Hi Andy,

It seems that resource bundle is never injected the first time a FXPerspective is accessed.

Indeed, in case of FXPerspective, resource bundle injection is done at line 253 of org.jacpfx.rcp.handler.PerspectiveHandlerImpl.initComponent(Message<Event, Object>, Perspective<Node, EventHandler<Event>, Event, Object>) (calling org.jacpfx.rcp.util.FXUtil.performResourceInjection(Injectable, JacpContext<EventHandler<Event>, Object>) which will use the resource bundle associated to the context) while the association of the resource bundle to the context will only be done at line 255 of org.jacpfx.rcp.handler.PerspectiveHandlerImpl.initComponent(Message<Event, Object>, Perspective<Node, EventHandler<Event>, Event, Object>) by the call to org.jacpfx.rcp.handler.PerspectiveHandlerImpl.handlePerspectiveInitialization(Perspective<Node, EventHandler<Event>, Event, Object>).

Current workaround consists in getting the resource bundle from the context directly or in using the resource bundle provided as argument of the method annotated by @PostConstruct.

Note that everything works well for managed fragments.

Thanks in advance!

Cheers,
Jean.

@amoAHCP
Copy link
Collaborator

amoAHCP commented Oct 29, 2015

Hi.... can you provide the version of JacpFX (2.1-RC3 ?)

Andy

@jlepropre
Copy link
Author

Sorry. It is 2.1-RC3.

Jean.

JacpFX added a commit that referenced this issue Oct 29, 2015
JacpFX added a commit that referenced this issue Oct 29, 2015
@amoAHCP
Copy link
Collaborator

amoAHCP commented Oct 29, 2015

OK... so I pushed RC4 to maven central. I had very little time to test, hopefully nothing is broken... at least the UnitTests were fine ;-)
So let me know if both bugs are gone and thank you for your help.

Andy

@jlepropre
Copy link
Author

Fixed by 2.1-RC4.

Thanks!

Jean.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants