-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ResourceBundle injection in FXPerspective #45
Comments
Hi.... can you provide the version of JacpFX (2.1-RC3 ?) Andy |
Sorry. It is 2.1-RC3. Jean. |
OK... so I pushed RC4 to maven central. I had very little time to test, hopefully nothing is broken... at least the UnitTests were fine ;-) Andy |
Fixed by 2.1-RC4. Thanks! Jean. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi Andy,
It seems that resource bundle is never injected the first time a FXPerspective is accessed.
Indeed, in case of
FXPerspective
, resource bundle injection is done at line 253 oforg.jacpfx.rcp.handler.PerspectiveHandlerImpl.initComponent(Message<Event, Object>, Perspective<Node, EventHandler<Event>, Event, Object>)
(callingorg.jacpfx.rcp.util.FXUtil.performResourceInjection(Injectable, JacpContext<EventHandler<Event>, Object>)
which will use the resource bundle associated to the context) while the association of the resource bundle to the context will only be done at line 255 oforg.jacpfx.rcp.handler.PerspectiveHandlerImpl.initComponent(Message<Event, Object>, Perspective<Node, EventHandler<Event>, Event, Object>)
by the call toorg.jacpfx.rcp.handler.PerspectiveHandlerImpl.handlePerspectiveInitialization(Perspective<Node, EventHandler<Event>, Event, Object>)
.Current workaround consists in getting the resource bundle from the context directly or in using the resource bundle provided as argument of the method annotated by @PostConstruct.
Note that everything works well for managed fragments.
Thanks in advance!
Cheers,
Jean.
The text was updated successfully, but these errors were encountered: