You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm sure there is an example that breaks my simple-minded approach, but my first instinct is for everything (even Crawford) to be lowercase in the data. The generator knows that Crawford is a proper noun, so it adds the capital at generation time. The exception would be acronyms that use funky capitalization, like LaTeX.
#3534 is the original issue, where @samm82 found some problematic sentence and/or noun phrase entries that carried capital letters. We really want Drasil to do the capitalization for us, purely on its own. We need to do that by enriching the data as much as we can, trying to minimize the raw capital letters we enter. To do this, we can add a simple error case in all of our sentence and noun phrase constructors so that we strictly forbid capital letter entry.
You can find a few examples of these problematic string entries that would need to be fixed using grep or rg commands, similar to how I did in my comment on #3692.
The text was updated successfully, but these errors were encountered:
Originally posted by @smiths in #3692 (comment)
#3534 is the original issue, where @samm82 found some problematic sentence and/or noun phrase entries that carried capital letters. We really want Drasil to do the capitalization for us, purely on its own. We need to do that by enriching the data as much as we can, trying to minimize the raw capital letters we enter. To do this, we can add a simple error case in all of our sentence and noun phrase constructors so that we strictly forbid capital letter entry.
You can find a few examples of these problematic string entries that would need to be fixed using
grep
orrg
commands, similar to how I did in my comment on #3692.The text was updated successfully, but these errors were encountered: