addon_folders.ts: assign scheme to URIs created for mockups #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Griperis
reviewed
Oct 11, 2023
| @@ -46,7 +46,7 @@ export function handleErrors(func: () => Promise<void>) { | |||
| try { | |||
| await func(); | |||
| } | |||
| catch (err) { | |||
| catch (err: any) { | |||
There was a problem hiding this comment.
This seems like a drive-by typing change.
There was a problem hiding this comment.
I believe the new typescript version didn't compile without it.
|
looking at MR now, it should have been two MRs with the a "assign a scheme" depending on the "update packages". I can fix it if needed - I was kinda in a hurry to compile a working version for myself. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correctly constructs URI objects that are passed to functions related to searching addon files.
Additionally, vscode dependency is updated to a non-depricated version, compatible with the same engine version, and typescript is updated to a version that is compatible with that version.
Small changes in addon_folder.ts are to make the new typescript version happy.
Closes #146