Revamp dvd support #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you so much, I'll review this code asap. |
This just gets the first track
The value of the prop matches the _Field property convention for repeated fields and is -1 if both fields in the frame are unique.
Add RepeatedField frame prop to RFF'd output
Setsugennoao
merged commit fd2ef6f
into
Jaded-Encoding-Thaumaturgy:master
2 checks passed
|
Thank you again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most stuff should work, but there are some arbitrary restrictions on some uncommon features.
example: audio (lpcm,ac3) stereo only, title only one program chain.
Mainly due to not having a lot/no samples.
I personally only use a small subset of the code commited, so some stuff isn't tested that much and most bugs will need to be ironed out when their found anyway, since there are many assumptions done that can't be checked due no access to spec.
I also don't really know any tooling for cross checking audio delay stuff.