In FMTCImageProvider compare based on both coords and store name #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaffaKetchup
approved these changes
Jul 5, 2022
There was a problem hiding this comment.
Wow, I'm surprised this works! I kind of ignored it here #44 (comment) (sorry, my fault :|), because it was never called in this library. But I guess flutter_map must use it at some point.
I'm not going to test this now, as it's (correctly) being merged into v5. I'll test it later :)
Thanks @sn4k3ch4rm3r and @tonyshkurenko!
JaffaKetchup
added a commit
that referenced
this pull request
Aug 3, 2022
* Deprecated old APIs Added `recreateStore` to `MapCachingManager`s * Changes to structure of directories * Added basics for statistic caching Added basics for multi-recovery support Added basics for recovery identification/description Added internal extensions on `Directory` * Improved `Recovery` time infomation flow Improved `StoreDirectory` construction Remove `rootDirectory` option from `StorageCachingTileProvider` Bug fixes * Edited report templates Improved workflows to enforce consistency Tried new dot syntax access (broken) * Fully-ish migrated `StoreDirectory` to new access methods Improved project source file organisation * Migrate `RootDirectory` to new format similar to `StoreDirectory` Organise project * Finished migrating statistic getters Improved statistic getters performances Removed unnecessary 'collection' dependency Deleted only `MapCachingManager` files * Added watchers * Migrated tile provider to new system Made `FMTCSettings` easier to use and maintain Made tile provider easier to use * Improved package import files Removed debugging stopwatch Started bulk download tools migration Moved tile provider source file to better location Improved documentation * Add Flutter 3 Support * Changed linter rules to more strict custom linting * Updated linter rules Refactored validators and santisers Fixed documentation comments Improve recovery system reliability * Change recovery system to be more reliable Introduce `downloadID` Finish migration from old syntax * Start new example application Bug fixes Linting rules changes * Added basic key-value pair storage as `StoreMetadata` Started adding new store screen to example application Improved example application appearance on Android devices Overriden dependency on flutter_map to get newest functionality Fixed bugs in example applications Fixed potential bug in `invalidateCachedStatistics` method * Prepare for initial prerelease for v5.0.0-dev.1 * Improved example application Improved documentation Fixed bugs * Example application improvements * Deprecated `preDownloadChecksCallback` argument and associated type Example application improvements * Improved example application Added synchronous version of `invalidateCachedStatistics` Added `checkTileCached(Async)` method Refactored and reorganised public APIs Improved `coverImage` (now `tileImage`) methods Removed unnecessary code * Prepared for release of 5.0.0-dev.2 version Updated flutter_map version in pubspec.yaml Improved README documentation Improved example application Improved performance Moved `tileImage` method from `stats` to `manage` * Fix mistake in README * Fixed README mistake Added project icon Added example application icon * Fixed README mistakes * Fixed download region areas/positions Started download start popup Changed theme primary color * Updated dependencies Reorganised code structure Fixed example application bugs Updated region drawing methods * Updated Gradle version of example application Moved `requestIgnoreBatteryOptimizations` method Added documentation website to README and pubspec.yaml Updated dependencies Added Discord server link to issue template selector Removed question/help issue template * Improved example application Improved statistics watchers * Improved example application * Updated dependencies * Added Basic Downloading Page To Example Application * Make `FMTCImageProvider` compare store names (#57) * Add credit for @tonyshkurenko Co-Authored-By: Anton Shkurenko <tonyshkurenko@gmail.com> * Fixed formatting issues Fixed lint issues * Begin changing background download method Update Gradle version * Updated to support 'flutter_map' v2 Fixed issue #31 * Added Windows build support (#58) Co-authored-by: Mathew Lawrence <Mathew.Lawrence@Snapcomms.com> Co-authored-by: Luka S <github@jaffaketchup.dev> * Updated Windows support Added horizontal orientation support to example application * Improved background downloading implementation * Removed unnecessary permissions from example app Improved in-code documentation Fixed spelling and grammar mistakes Refactored internal structure Removed unecessary code * Prepared for v5.0.0-dev.3 version release * Reworked `invalidateCachedStatistics` Added cache hits and misses statistics * Fixed cache hits and misses statistics Updated in-code documentation * Added v4 to v5 migration methods * Fixed migrator method * Prepared for v5.0.0-dev.4 verison release * Improved example application Internal refactoring Improved recovery system Reworked (partially) statistic change watcher * Started Reimplementing Estimated Download Durations * Fixed bugs in example application Added filesystem sanitiser customisation to `FMTCSettings` Improved in-code documentation Broken progress measurements further * Fixed download estimation calculations Improved example application Improved in-code documentation * Improved example application Improved in-code documentation * Improved example application Prepare for v5.0.0-dev.5 release * Added example application info page Improved example application Removed androidBuilder.sh * Update README with new donation options * Fix README donation window * Improve README donation section * Attempt 1 @ Adding Auto Build * Attempt 2 @ Adding Auto Build * Attempt 3 @ Adding Auto Build * Attempt 4 @ Adding Auto Build * Built Example Applications * Attempt 5 @ Adding Auto Build * Attempt 6 @ Adding Auto Build * Attempt 7 @ Adding Auto Build * Built Example Applications * Improve auto-builder * Improve auto-builder * Test trigger auto-builder * Built Example Applications * Improve GitHub Actions Workflows * Empty Commit * Revert Changes Add Automatic Workflow Runs Deleter * Added Workflow Dipatch To "Delete Old Workflow Runs" * Improve Workflows Trigger Example Application Rebuild * Built Example Applications * Updated To 'actions/checkout@v3' Remove 10pt Error Allowance From Package Analysis * Finished example application * Built Example Applications * Fixed spelling mistakes in in-code documentation Moved `migrator` to `RootDirectory` Internal structure reorganisation * Prepare for v5.0.0-dev.6 release Fixed multiple bugs in library and example application Added cancel download button to example application Converted `DownloadManagement` to a singleton object Improved in-code documentation * Built Example Applications * Renamed and refactored internal and public APIs, ready for release Added `successfulSize` statistic to `DownloadProgress` Improved example application Improved documentation Fixed bugs * Built Example Applications * Fixed misleading `DownloadProgress` statistic `remainingTiles` * Improved documentation Co-authored-by: Boldizsár Tóth <39193138+sn4k3ch4rm3r@users.noreply.github.com> Co-authored-by: Anton Shkurenko <tonyshkurenko@gmail.com> Co-authored-by: FireAndIceFrog <60675668+FireAndIceFrog@users.noreply.github.com> Co-authored-by: Mathew Lawrence <Mathew.Lawrence@Snapcomms.com> Co-authored-by: JaffaKetchup <JaffaKetchup@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
zeykafx
pushed a commit
to zeykafx/flutter_map_tile_caching
that referenced
this pull request
Jun 26, 2024
* Deprecated old APIs Added `recreateStore` to `MapCachingManager`s * Changes to structure of directories * Added basics for statistic caching Added basics for multi-recovery support Added basics for recovery identification/description Added internal extensions on `Directory` * Improved `Recovery` time infomation flow Improved `StoreDirectory` construction Remove `rootDirectory` option from `StorageCachingTileProvider` Bug fixes * Edited report templates Improved workflows to enforce consistency Tried new dot syntax access (broken) * Fully-ish migrated `StoreDirectory` to new access methods Improved project source file organisation * Migrate `RootDirectory` to new format similar to `StoreDirectory` Organise project * Finished migrating statistic getters Improved statistic getters performances Removed unnecessary 'collection' dependency Deleted only `MapCachingManager` files * Added watchers * Migrated tile provider to new system Made `FMTCSettings` easier to use and maintain Made tile provider easier to use * Improved package import files Removed debugging stopwatch Started bulk download tools migration Moved tile provider source file to better location Improved documentation * Add Flutter 3 Support * Changed linter rules to more strict custom linting * Updated linter rules Refactored validators and santisers Fixed documentation comments Improve recovery system reliability * Change recovery system to be more reliable Introduce `downloadID` Finish migration from old syntax * Start new example application Bug fixes Linting rules changes * Added basic key-value pair storage as `StoreMetadata` Started adding new store screen to example application Improved example application appearance on Android devices Overriden dependency on flutter_map to get newest functionality Fixed bugs in example applications Fixed potential bug in `invalidateCachedStatistics` method * Prepare for initial prerelease for v5.0.0-dev.1 * Improved example application Improved documentation Fixed bugs * Example application improvements * Deprecated `preDownloadChecksCallback` argument and associated type Example application improvements * Improved example application Added synchronous version of `invalidateCachedStatistics` Added `checkTileCached(Async)` method Refactored and reorganised public APIs Improved `coverImage` (now `tileImage`) methods Removed unnecessary code * Prepared for release of 5.0.0-dev.2 version Updated flutter_map version in pubspec.yaml Improved README documentation Improved example application Improved performance Moved `tileImage` method from `stats` to `manage` * Fix mistake in README * Fixed README mistake Added project icon Added example application icon * Fixed README mistakes * Fixed download region areas/positions Started download start popup Changed theme primary color * Updated dependencies Reorganised code structure Fixed example application bugs Updated region drawing methods * Updated Gradle version of example application Moved `requestIgnoreBatteryOptimizations` method Added documentation website to README and pubspec.yaml Updated dependencies Added Discord server link to issue template selector Removed question/help issue template * Improved example application Improved statistics watchers * Improved example application * Updated dependencies * Added Basic Downloading Page To Example Application * Make `FMTCImageProvider` compare store names (JaffaKetchup#57) * Add credit for @tonyshkurenko Co-Authored-By: Anton Shkurenko <tonyshkurenko@gmail.com> * Fixed formatting issues Fixed lint issues * Begin changing background download method Update Gradle version * Updated to support 'flutter_map' v2 Fixed issue JaffaKetchup#31 * Added Windows build support (JaffaKetchup#58) Co-authored-by: Mathew Lawrence <Mathew.Lawrence@Snapcomms.com> Co-authored-by: Luka S <github@jaffaketchup.dev> * Updated Windows support Added horizontal orientation support to example application * Improved background downloading implementation * Removed unnecessary permissions from example app Improved in-code documentation Fixed spelling and grammar mistakes Refactored internal structure Removed unecessary code * Prepared for v5.0.0-dev.3 version release * Reworked `invalidateCachedStatistics` Added cache hits and misses statistics * Fixed cache hits and misses statistics Updated in-code documentation * Added v4 to v5 migration methods * Fixed migrator method * Prepared for v5.0.0-dev.4 verison release * Improved example application Internal refactoring Improved recovery system Reworked (partially) statistic change watcher * Started Reimplementing Estimated Download Durations * Fixed bugs in example application Added filesystem sanitiser customisation to `FMTCSettings` Improved in-code documentation Broken progress measurements further * Fixed download estimation calculations Improved example application Improved in-code documentation * Improved example application Improved in-code documentation * Improved example application Prepare for v5.0.0-dev.5 release * Added example application info page Improved example application Removed androidBuilder.sh * Update README with new donation options * Fix README donation window * Improve README donation section * Attempt 1 @ Adding Auto Build * Attempt 2 @ Adding Auto Build * Attempt 3 @ Adding Auto Build * Attempt 4 @ Adding Auto Build * Built Example Applications * Attempt 5 @ Adding Auto Build * Attempt 6 @ Adding Auto Build * Attempt 7 @ Adding Auto Build * Built Example Applications * Improve auto-builder * Improve auto-builder * Test trigger auto-builder * Built Example Applications * Improve GitHub Actions Workflows * Empty Commit * Revert Changes Add Automatic Workflow Runs Deleter * Added Workflow Dipatch To "Delete Old Workflow Runs" * Improve Workflows Trigger Example Application Rebuild * Built Example Applications * Updated To 'actions/checkout@v3' Remove 10pt Error Allowance From Package Analysis * Finished example application * Built Example Applications * Fixed spelling mistakes in in-code documentation Moved `migrator` to `RootDirectory` Internal structure reorganisation * Prepare for v5.0.0-dev.6 release Fixed multiple bugs in library and example application Added cancel download button to example application Converted `DownloadManagement` to a singleton object Improved in-code documentation * Built Example Applications * Renamed and refactored internal and public APIs, ready for release Added `successfulSize` statistic to `DownloadProgress` Improved example application Improved documentation Fixed bugs * Built Example Applications * Fixed misleading `DownloadProgress` statistic `remainingTiles` * Improved documentation Co-authored-by: Boldizsár Tóth <39193138+sn4k3ch4rm3r@users.noreply.github.com> Co-authored-by: Anton Shkurenko <tonyshkurenko@gmail.com> Co-authored-by: FireAndIceFrog <60675668+FireAndIceFrog@users.noreply.github.com> Co-authored-by: Mathew Lawrence <Mathew.Lawrence@Snapcomms.com> Co-authored-by: JaffaKetchup <JaffaKetchup@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Former-commit-id: c238a9accef18f4cef0f2dda369e14e91e1b65d8 [formerly 3b3a658] Former-commit-id: c0cbff97269ae411bd4023f0c15d9be7b49316e2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned by @tonyshkurenko this seems to have fixed the issue, where it won't display more than one layer at a time.