Performance improvement to loadTiles #6
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the following to the loadTiles function: - Create an http.client prior to looping through the downloading of the tiles - Within the loop, get the tile data using the client - Close the client at the end of the download loop This avoids the opening and closing of a client connection for each tile request, improves performance at the end user level and is easier on the server side as we won't be slamming the server with hundereds / thousands of new connection requests.
|
This made a pretty big difference in performance in my use case since I am using a server that requires authentication. By keeping the connection open this allows all the tiles to be downloaded using the same connection, so only one authentication request required per area downloaded. |
|
Made this one against master, will re-submit against V3.0.0 |
JaffaKetchup
added
won't fix
|
Please see #7 for further information. |
Repository owner
locked and limited conversation to collaborators
Jun 3, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the following to the loadTiles function:
This avoids the opening and closing of a client connection for each tile request, improves performance at the end user level and is easier on the server side as we won't be slamming the server with hundereds / thousands of new connection requests.