refactor(flavor): rename "internal" to "develop"

JagandeepBrar · Jan 25, 2022 · 5652cb0 · 5652cb0
1 parent c96e970
commit 5652cb0
Show file tree

Hide file tree

Showing 4 changed files with 20 additions and 19 deletions.
diff --git a/.github/workflows/release_internal.yml → .github/workflows/release_develop.yml b/.github/workflows/release_internal.yml → .github/workflows/release_develop.yml
@@ -1,4 +1,4 @@
-name: '[Release] Internal'
+name: '[Release] Develop'
 
 on:
   push:
@@ -16,7 +16,7 @@ jobs:
           access_token: ${{ github.token }}
 
   build:
-    name: Internal Release
+    name: Develop Release
     uses: CometTools/LunaSea/.github/workflows/build_all_platforms.yml@master
     needs: cancel
     with:

diff --git a/lib/core/modules.dart b/lib/core/modules.dart
@@ -59,7 +59,7 @@ extension LunaModuleExtension on LunaModule {
       case LunaModule.NZBGET:
         return true;
       case LunaModule.OVERSEERR:
-        return LunaFlavor().isLowerOrEqualTo(LunaEnvironment.INTERNAL);
+        return LunaFlavor().isLowerOrEqualTo(LunaEnvironment.DEVELOP);
       case LunaModule.RADARR:
         return true;
       case LunaModule.SABNZBD:

diff --git a/lib/core/system/flavor.dart b/lib/core/system/flavor.dart
@@ -5,7 +5,8 @@ import 'package:envify/envify.dart';
 
 part 'flavor.g.dart';
 
-const _INTERNAL = 'internal';
+/// Keep it as `internal` for easier flavor pushing to Play Store and App Store Connect test groups
+const _DEVELOP = 'internal';
 const _ALPHA = 'alpha';
 const _BETA = 'beta';
 const _PRODUCTION = 'production';
@@ -18,10 +19,10 @@ class LunaFlavor {
 
 extension FlavorExtension on LunaFlavor {
   LunaEnvironment get environment {
-    if (kDebugMode) return LunaEnvironment.INTERNAL;
+    if (kDebugMode) return LunaEnvironment.DEVELOP;
     switch (LunaFlavor.flavor) {
-      case _INTERNAL:
-        return LunaEnvironment.INTERNAL;
+      case _DEVELOP:
+        return LunaEnvironment.DEVELOP;
       case _ALPHA:
         return LunaEnvironment.ALPHA;
       case _BETA:
@@ -44,12 +45,12 @@ extension FlavorExtension on LunaFlavor {
   bool isLowerOrEqualTo(LunaEnvironment env) {
     if (this.environment == env) return true;
     switch (env) {
-      case LunaEnvironment.INTERNAL:
+      case LunaEnvironment.DEVELOP:
         return false;
       case LunaEnvironment.ALPHA:
-        return this.environment == LunaEnvironment.INTERNAL;
+        return this.environment == LunaEnvironment.DEVELOP;
       case LunaEnvironment.BETA:
-        return this.environment == LunaEnvironment.INTERNAL ||
+        return this.environment == LunaEnvironment.DEVELOP ||
             this.environment == LunaEnvironment.ALPHA;
       case LunaEnvironment.PRODUCTION:
         return true;
@@ -58,7 +59,7 @@ extension FlavorExtension on LunaFlavor {
 }
 
 enum LunaEnvironment {
-  INTERNAL,
+  DEVELOP,
   ALPHA,
   BETA,
   PRODUCTION,
@@ -67,8 +68,8 @@ enum LunaEnvironment {
 extension LunaEnvironmentExtension on LunaEnvironment {
   String get key {
     switch (this) {
-      case LunaEnvironment.INTERNAL:
-        return _INTERNAL;
+      case LunaEnvironment.DEVELOP:
+        return _DEVELOP;
       case LunaEnvironment.ALPHA:
         return _ALPHA;
       case LunaEnvironment.BETA:
@@ -80,8 +81,8 @@ extension LunaEnvironmentExtension on LunaEnvironment {
 
   String get name {
     switch (this) {
-      case LunaEnvironment.INTERNAL:
-        return 'lunasea.Internal'.tr();
+      case LunaEnvironment.DEVELOP:
+        return 'lunasea.Develop'.tr();
       case LunaEnvironment.ALPHA:
         return 'lunasea.Alpha'.tr();
       case LunaEnvironment.BETA:
@@ -93,7 +94,7 @@ extension LunaEnvironmentExtension on LunaEnvironment {
 
   Color get color {
     switch (this) {
-      case LunaEnvironment.INTERNAL:
+      case LunaEnvironment.DEVELOP:
         return LunaColours.red;
       case LunaEnvironment.ALPHA:
         return LunaColours.orange;
@@ -106,8 +107,8 @@ extension LunaEnvironmentExtension on LunaEnvironment {
 
   LunaEnvironment from(String key) {
     switch (key) {
-      case _INTERNAL:
-        return LunaEnvironment.INTERNAL;
+      case _DEVELOP:
+        return LunaEnvironment.DEVELOP;
       case _ALPHA:
         return LunaEnvironment.ALPHA;
       case _BETA:

diff --git a/lib/modules/settings/routes/settings/route.dart b/lib/modules/settings/routes/settings/route.dart
@@ -89,7 +89,7 @@ class _State extends State<_Widget> with LunaScrollControllerMixin {
           trailing: const LunaIconButton(icon: Icons.settings_rounded),
           onTap: () async => SettingsSystemRouter().navigateTo(context),
         ),
-        if (LunaFlavor().isLowerOrEqualTo(LunaEnvironment.INTERNAL))
+        if (LunaFlavor().isLowerOrEqualTo(LunaEnvironment.DEVELOP))
           LunaBlock(
             title: 'settings.DebugMenu'.tr(),
             body: [TextSpan(text: 'settings.DebugMenuDescription'.tr())],