Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade for Python 3 #61

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Upgrade for Python 3 #61

wants to merge 6 commits into from

Conversation

zevaryx
Copy link

@zevaryx zevaryx commented Sep 11, 2020

Upgrade to support Python 3

Drops support for Python 2, but since Python 2 has been deprecated, this should not be an issue

Known Issues

  • UnicodeDecodeError about wrong starting byte when opening some logs
    • Error handling for this error needs added. This wasn't an issue before due to Unicode not being native in Python 2

@Jahaja
Copy link
Owner

Jahaja commented Oct 1, 2020

Thanks for the PR. What's the reason for the bootstrap version bump?

@zevaryx
Copy link
Author

zevaryx commented Oct 2, 2020

The Bootstrap version bump was due to Flask dropping support for Request.is_xhr, and to bundle all of the required JavaScript in a single file in bootstrap.bundle.min.js for all of the functionality. The bundle file wasn't an option in Bootstrap 3, and is new to Bootstrap 4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zevaryx @Jahaja