Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Junit Rules/Extensions #155

Closed
JaidenAshmore opened this issue Jun 15, 2020 · 0 comments
Closed

Remove Junit Rules/Extensions #155

JaidenAshmore opened this issue Jun 15, 2020 · 0 comments
Assignees
@JaidenAshmore
Labels
engineering task A more technically focused task
Milestone
4.0.0

Comments

@JaidenAshmore
Copy link
Owner

I don't want to support JUnit 4 rules and the JUnit 5 extension doesn't provide a significant amount of value as the fix in #154 will result in this extension not doing much at all.
@JaidenAshmore JaidenAshmore added the engineering task A more technically focused task label Jun 15, 2020
@JaidenAshmore JaidenAshmore added this to the 4.0.0 milestone Jun 15, 2020
@JaidenAshmore JaidenAshmore self-assigned this Jun 15, 2020
JaidenAshmore added a commit that referenced this issue Jun 17, 2020
@JaidenAshmore
refs #155 refs #154: Fix Exceptions in Spring Tests
f3a807a 
Removes JUnit4 Rules and JUnit5 extensions in favour of manually
using the LocalSqsAsyncClient and ElasticMqSqsAsyncClient
JaidenAshmore added a commit that referenced this issue Jun 17, 2020
@JaidenAshmore
154 remove spring sqs integration test exceptions (#158)
cc95497 
* refs #153: Make it not require google imports to be in a separate section

* refs #155 refs #154: Fix Exceptions in Spring Tests

Removes JUnit4 Rules and JUnit5 extensions in favour of manually
using the LocalSqsAsyncClient and ElasticMqSqsAsyncClient

* refs #154: Fix builds
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JaidenAshmore JaidenAshmore

Labels
engineering task A more technically focused task
Projects
None yet
Milestone
4.0.0
Development

No branches or pull requests
1 participant
@JaidenAshmore